From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0262AC4361B for ; Wed, 16 Dec 2020 18:33:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7393623AA3 for ; Wed, 16 Dec 2020 18:33:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7393623AA3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpbbg-0008Rk-BS for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 13:33:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpbZd-00073O-4a for qemu-devel@nongnu.org; Wed, 16 Dec 2020 13:30:53 -0500 Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]:37339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpbZZ-0001ZS-1g for qemu-devel@nongnu.org; Wed, 16 Dec 2020 13:30:52 -0500 Received: by mail-oi1-x236.google.com with SMTP id l207so28638783oib.4 for ; Wed, 16 Dec 2020 10:30:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=edvCumAF1YT2/zB80ax6vbZoo4BbP6LxNmFIFOvMYLQ=; b=A91IzgyrnhTtAioexEykevWKrwTTpnRP4X6vBJY8ZjYC5xc0/QxoGjxkrbrw7rrLuL 3OLAOt3wOz605D6g3ogqouWHJFIXN+8HWz+J97gr1VxVsdXsnZ585lxj0owC+j/OnimO kX82sj47Mo07V7BWuY+3qb/+wLP8vAxIEgd+0/3LLXimAe9Id4kF0491GfnT5Oy/h+oX 8/dv9fpYsUTOt6dchHUcVBJxPXwD2sNeF6d1lvi6AGgY78yMFnBrA6WJp2w5zRe7+D0I klotvlza/WBByVCQ9q72o5BeXAW8coO1+x1izfV+Z86T+/E6LRpsOxuUXMbCMvM49Lrl qujQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=edvCumAF1YT2/zB80ax6vbZoo4BbP6LxNmFIFOvMYLQ=; b=gXq4o7wRG3U3FCUnvu6kYUswtpivt8zK5LBk44gRrWnzKz9Xn7Nf4tdXvl6MO+oQEb lgGMN8mBN4cR5Mw2N3/QBksGs1HyrSHMkrryW/Afy7h1g6Vv1IXimSxMJrK6LDa4puek AkKM2EQZWFzf0CB5ec3M+FOpwfAmcqGMtWYbtlJcTBYm6ag3iPmpunErImfhaZBEdGLx wH8nvzc2Cjbk32rxGkjYSimfzxs3q7rcan+HiRyIyMMvzGcg45D2ApSOa+HIRtTttday E0O92QKeO8pKCOdUr/DnCbywA5zrgIi8NEj1r/JhgknnwB78Hon0C5N0u6flFZCY1IXc JqHQ== X-Gm-Message-State: AOAM533l89lSTcj453G9lA38Z72BP+idc7KTC0hZnH7ESzprhzhxBiSz XvCf0/JVzYB78e6UdBXhmCX2gw== X-Google-Smtp-Source: ABdhPJzgyGh7NtgvKGItysLJjnvElpxCFGI3ijf0oxJkRXav2uAkMOSvEBRgZmOmypT7XR7+s34meQ== X-Received: by 2002:aca:f15:: with SMTP id 21mr2848438oip.109.1608143447733; Wed, 16 Dec 2020 10:30:47 -0800 (PST) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id v92sm606495otb.75.2020.12.16.10.30.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Dec 2020 10:30:47 -0800 (PST) Subject: Re: [RFC v2 14/15] target/riscv: rvb: add/sub with postfix zero-extend To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20201216020150.3157-1-frank.chang@sifive.com> <20201216020150.3157-15-frank.chang@sifive.com> From: Richard Henderson Message-ID: Date: Wed, 16 Dec 2020 12:30:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201216020150.3157-15-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::236; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x236.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Kito Cheng , Alistair Francis , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/15/20 8:01 PM, frank.chang@sifive.com wrote: > From: Kito Cheng > > Signed-off-by: Kito Cheng > Signed-off-by: Frank Chang > --- > target/riscv/insn32-64.decode | 3 +++ > target/riscv/insn_trans/trans_rvb.c.inc | 22 ++++++++++++++++++++++ > target/riscv/translate.c | 6 ++++++ > 3 files changed, 31 insertions(+) Subject should be add/slli as there is no sub. Otherwise, Reviewed-by: Richard Henderson r~