From: Thomas Huth <thuth@redhat.com>
To: "Stefan Weil" <sw@weilnetz.de>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 11/11] dockerfiles/debian-win64-cross: Download WHPX MinGW headers
Date: Wed, 5 Aug 2020 08:28:12 +0200 [thread overview]
Message-ID: <ce473498-1be8-2ec1-ff54-6b52d07f7038@redhat.com> (raw)
In-Reply-To: <4cdba8c7-c6a1-e561-9e84-1dae8cf4cd04@weilnetz.de>
On 04/08/2020 20.32, Stefan Weil wrote:
> Am 04.08.20 um 19:00 schrieb Thomas Huth:
>
>> To compile-test the WHPX accelerator, we need to download these system
>> headers first (they are unfortunately not part of any released and
>> packaged MinGW toolchain yet).
>>
>> Idea taken from another patch by Stefan Weil.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> tests/docker/dockerfiles/debian-win64-cross.docker | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/docker/dockerfiles/debian-win64-cross.docker b/tests/docker/dockerfiles/debian-win64-cross.docker
>> index 2fc9cfcbc6..4cc4a3f365 100644
>> --- a/tests/docker/dockerfiles/debian-win64-cross.docker
>> +++ b/tests/docker/dockerfiles/debian-win64-cross.docker
>> @@ -32,7 +32,14 @@ RUN apt-get update && \
>> mxe-$TARGET-w64-mingw32.shared-sdl2 \
>> mxe-$TARGET-w64-mingw32.shared-sdl2-mixer \
>> mxe-$TARGET-w64-mingw32.shared-sdl2-gfx \
>> - mxe-$TARGET-w64-mingw32.shared-zlib
>> + mxe-$TARGET-w64-mingw32.shared-zlib \
>> + curl && \
>> + curl -s -S -o /usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/WinHvEmulation.h \
>> + "https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/winhvemulation.h?format=raw" && \
>> + curl -s -S -o /usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/WinHvPlatform.h \
>> + "https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/winhvplatform.h?format=raw" && \
>> + curl -s -S -o /usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/winhvplatformdefs.h \
>> + "https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/winhvplatformdefs.h?format=raw"
>>
>> # Specify the cross prefix for this image (see tests/docker/common.rc)
>> ENV QEMU_CONFIGURE_OPTS --cross-prefix=x86_64-w64-mingw32.shared-
>
>
> I expect a build failure: Mingw-w64 decided to use lower case filenames,
> and those header files include each other.
The first two headers include the third header, that's why I've used
lowercase for the third header (which is apparently not included by QEMU
directly).
But yes, all that CamelCase vs. lower-case stuff is very annoying. I
think once there is a new MinGW release available in the major Linux
distros that ships with these headers, we should change the QEMU source
code to always use the lowercase headers, too.
Thomas
next prev parent reply other threads:[~2020-08-05 6:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 17:00 [PATCH 00/11] Run cross-compilation build tests in the gitlab-CI Thomas Huth
2020-08-04 17:00 ` [PATCH 01/11] virtio-mem: Correct format specifier mismatch for RISC-V Thomas Huth
2020-08-04 17:00 ` [PATCH 02/11] target/riscv/vector_helper: Fix build on 32-bit big endian targets Thomas Huth
2020-08-04 17:34 ` Richard Henderson
2020-08-04 17:46 ` Philippe Mathieu-Daudé
2020-08-05 8:45 ` Thomas Huth
2020-08-04 17:00 ` [PATCH 03/11] tests/Makefile: test-image-locking needs CONFIG_POSIX Thomas Huth
2020-08-04 17:00 ` [PATCH 04/11] tests/Makefile: test-replication " Thomas Huth
2020-08-04 17:00 ` [PATCH 05/11] tests/Makefile: Only build usable targets during 'make check-build' Thomas Huth
2020-08-04 17:00 ` [PATCH 06/11] tests/Makefile: Add $(EXESUF) to fp-test target Thomas Huth
2020-08-04 17:45 ` Richard Henderson
2020-08-04 17:51 ` Philippe Mathieu-Daudé
2020-08-12 9:47 ` Paolo Bonzini
2020-08-04 17:00 ` [PATCH 07/11] Get rid of the libqemustub.a remainders Thomas Huth
2020-08-04 17:46 ` Richard Henderson
2020-08-04 17:00 ` [PATCH 08/11] stubs/notify-event: Mark qemu_notify_event() stub as "weak" Thomas Huth
2020-08-04 17:50 ` Richard Henderson
2020-08-04 18:20 ` Thomas Huth
2020-08-12 9:47 ` Paolo Bonzini
2020-08-04 17:00 ` [PATCH 09/11] gitlab-ci: Add cross-compiling build tests Thomas Huth
2020-08-04 17:00 ` [PATCH 10/11] configure: Allow automatic WHPX detection Thomas Huth
2020-08-04 17:47 ` Philippe Mathieu-Daudé
2020-08-04 18:25 ` Stefan Weil
2020-08-04 17:00 ` [PATCH 11/11] dockerfiles/debian-win64-cross: Download WHPX MinGW headers Thomas Huth
2020-08-04 18:07 ` Philippe Mathieu-Daudé
2020-08-04 18:32 ` Stefan Weil
2020-08-05 6:28 ` Thomas Huth [this message]
2020-08-05 9:11 ` Daniel P. Berrangé
2020-08-05 12:54 ` 罗勇刚(Yonggang Luo)
2020-08-04 17:05 ` [PATCH 00/11] Run cross-compilation build tests in the gitlab-CI Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce473498-1be8-2ec1-ff54-6b52d07f7038@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).