From: Eric Blake <eblake@redhat.com>
To: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,
Greg Kurz <groug@kaod.org>,
Pradeep Jagadeesh <pradeepkiruvale@gmail.com>
Cc: alberto garcia <berto@igalia.com>,
jani kokkonen <jani.kokkonen@huawei.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code
Date: Wed, 10 May 2017 14:48:05 -0500 [thread overview]
Message-ID: <ce4f0817-64a0-a3c9-2e2c-1617c0c1bd62@redhat.com> (raw)
In-Reply-To: <22325f3a-133a-a1e3-77ae-57e0c8235696@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
On 05/10/2017 10:27 AM, Pradeep Jagadeesh wrote:
>>
>> Isn't it a bit overkill to introduce a new file for a single function ?
>> Maybe you could simply move this to util/throttle.c ?
>>
> OK, but I will add one more function later patch. Still do you think
> better to move to util/thottle.c?
As long as util/throttle.c is not already huge, adding multiple new
functions to that file over the course of the series should be just fine.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-05-10 19:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 8:41 [Qemu-devel] [PATCH v4 0/4] fsdev: qmp interface for io throttling Pradeep Jagadeesh
2017-05-10 8:41 ` [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code Pradeep Jagadeesh
2017-05-10 14:12 ` Greg Kurz
2017-05-10 15:27 ` Pradeep Jagadeesh
2017-05-10 19:48 ` Eric Blake [this message]
2017-05-11 16:12 ` Pradeep Jagadeesh
2017-05-10 8:41 ` [Qemu-devel] [PATCH v4 2/4] qmp: Create IOThrottle structure Pradeep Jagadeesh
2017-05-10 8:41 ` [Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code Pradeep Jagadeesh
2017-05-10 19:56 ` Eric Blake
2017-05-11 16:14 ` Pradeep Jagadeesh
2017-05-11 7:50 ` Greg Kurz
2017-05-12 8:03 ` Pradeep Jagadeesh
2017-06-08 14:20 ` Greg Kurz
2017-06-09 8:32 ` Pradeep Jagadeesh
2017-05-10 8:41 ` [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling Pradeep Jagadeesh
2017-05-10 20:00 ` Eric Blake
2017-05-17 14:53 ` Pradeep Jagadeesh
2017-05-17 15:28 ` Eric Blake
2017-05-17 16:29 ` Greg Kurz
2017-05-17 17:09 ` Eric Blake
2017-05-18 13:30 ` Pradeep Jagadeesh
2017-06-08 16:49 ` Greg Kurz
2017-06-09 8:31 ` Pradeep Jagadeesh
2017-06-09 9:07 ` Greg Kurz
2017-06-09 9:13 ` Pradeep Jagadeesh
2017-06-09 9:20 ` Greg Kurz
2017-05-10 10:02 ` [Qemu-devel] [PATCH v4 0/4] fsdev: qmp interface for io throttling no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce4f0817-64a0-a3c9-2e2c-1617c0c1bd62@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=groug@kaod.org \
--cc=jani.kokkonen@huawei.com \
--cc=pradeep.jagadeesh@huawei.com \
--cc=pradeepkiruvale@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).