* [PATCH v2] hw/display/edid: Add missing 'qdev-properties.h' header
@ 2020-05-18 17:45 Philippe Mathieu-Daudé
2020-05-19 15:28 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-18 17:45 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Richard Henderson, Michael Tokarev, Laurent Vivier,
Philippe Mathieu-Daudé, qemu-trivial, Gerd Hoffmann
When trying to consume the DEFINE_EDID_PROPERTIES() macro
by including "hw/display/edid.h", we get this build failure:
include/hw/display/edid.h:24:5: error: implicit declaration of
function ‘DEFINE_PROP_UINT32’ [-Werror=implicit-function-declaration]
24 | DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0), \
| ^~~~~~~~~~~~~~~~~~
Headers should be self-contained, and one shouldn't have to
dig to find the missing headers.
In this case "hw/qdev-properties.h" is missing. Add it.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Since v1: reworded description (rth)
Supersedes: <20200504082003.16298-1-f4bug@amsat.org>
---
include/hw/display/edid.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h
index ff99dc0a05..23371ee82c 100644
--- a/include/hw/display/edid.h
+++ b/include/hw/display/edid.h
@@ -2,6 +2,7 @@
#define EDID_H
#include "qom/object.h"
+#include "hw/qdev-properties.h"
typedef struct qemu_edid_info {
const char *vendor; /* http://www.uefi.org/pnp_id_list */
--
2.21.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] hw/display/edid: Add missing 'qdev-properties.h' header
2020-05-18 17:45 [PATCH v2] hw/display/edid: Add missing 'qdev-properties.h' header Philippe Mathieu-Daudé
@ 2020-05-19 15:28 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2020-05-19 15:28 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Thomas Huth, qemu-trivial, Michael Tokarev, Laurent Vivier,
Gerd Hoffmann
On 5/18/20 10:45 AM, Philippe Mathieu-Daudé wrote:
> When trying to consume the DEFINE_EDID_PROPERTIES() macro
> by including "hw/display/edid.h", we get this build failure:
>
> include/hw/display/edid.h:24:5: error: implicit declaration of
> function ‘DEFINE_PROP_UINT32’ [-Werror=implicit-function-declaration]
> 24 | DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0), \
> | ^~~~~~~~~~~~~~~~~~
>
> Headers should be self-contained, and one shouldn't have to
> dig to find the missing headers.
> In this case "hw/qdev-properties.h" is missing. Add it.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Since v1: reworded description (rth)
>
> Supersedes: <20200504082003.16298-1-f4bug@amsat.org>
> ---
> include/hw/display/edid.h | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-19 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-18 17:45 [PATCH v2] hw/display/edid: Add missing 'qdev-properties.h' header Philippe Mathieu-Daudé
2020-05-19 15:28 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).