From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: BALATON Zoltan <balaton@eik.bme.hu>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH v2 05/11] hw/char/sh_serial: Rename type sh_serial_state to SHSerialState
Date: Wed, 27 Oct 2021 17:41:16 +0200 [thread overview]
Message-ID: <ce659b4d-1be1-db0f-566d-ffa42d3357dd@amsat.org> (raw)
In-Reply-To: <029a0597b27a0f2ed989f5838451269c176b6310.1635342377.git.balaton@eik.bme.hu>
On 10/27/21 15:46, BALATON Zoltan wrote:
> Coding style says types should be camel case.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/char/sh_serial.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-10-27 16:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 13:46 [PATCH v2 00/11] More SH4 clean ups BALATON Zoltan
2021-10-27 13:46 ` [PATCH v2 04/11] hw/sh4/r2d: Use error_report instead of fprintf to stderr BALATON Zoltan
2021-10-27 15:54 ` Philippe Mathieu-Daudé
2021-10-27 13:46 ` [PATCH v2 05/11] hw/char/sh_serial: Rename type sh_serial_state to SHSerialState BALATON Zoltan
2021-10-27 15:41 ` Philippe Mathieu-Daudé [this message]
2021-10-27 13:46 ` [PATCH v2 10/11] hw/intc/sh_intc: Clean up iomem region BALATON Zoltan
2021-10-27 15:58 ` Philippe Mathieu-Daudé
2021-10-27 16:11 ` BALATON Zoltan
2021-10-27 13:46 ` [PATCH v2 08/11] hw/intc/sh_intc: Use existing macro instead of local one BALATON Zoltan
2021-10-27 15:46 ` Philippe Mathieu-Daudé
2021-10-27 16:21 ` BALATON Zoltan
2021-10-27 17:33 ` BALATON Zoltan
2021-10-27 13:46 ` [PATCH v2 02/11] hw//sh4: Use qemu_log instead of fprintf to stderr BALATON Zoltan
2021-10-27 15:54 ` Philippe Mathieu-Daudé
2021-10-27 16:13 ` BALATON Zoltan
2021-10-27 13:46 ` [PATCH v2 03/11] hw/sh4: Change debug printfs to traces BALATON Zoltan
2021-10-27 13:46 ` [PATCH v2 01/11] hw/sh4: Fix a typo in a comment BALATON Zoltan
2021-10-27 15:42 ` Philippe Mathieu-Daudé
2021-10-27 16:23 ` BALATON Zoltan
2021-10-27 13:46 ` [PATCH v2 06/11] hw/char/sh_serial: QOM-ify BALATON Zoltan
2021-10-27 13:46 ` [PATCH v2 11/11] hw/intc/sh_intc: Drop another useless macro BALATON Zoltan
2021-10-27 15:37 ` Philippe Mathieu-Daudé
2021-10-27 13:46 ` [PATCH v2 09/11] hw/intc/sh_intc: Turn some defines into an enum BALATON Zoltan
2021-10-27 15:50 ` Philippe Mathieu-Daudé
2021-10-27 16:18 ` BALATON Zoltan
2021-10-27 13:46 ` [PATCH v2 07/11] hw/char/sh_serial: Add device id to trace output BALATON Zoltan
2021-10-27 15:40 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce659b4d-1be1-db0f-566d-ffa42d3357dd@amsat.org \
--to=f4bug@amsat.org \
--cc=balaton@eik.bme.hu \
--cc=magnus.damm@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).