From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: jiaxun.yang@flygoat.com, crwulff@gmail.com, marex@denx.de,
ysato@users.sourceforge.jp, mark.cave-ayland@ilande.co.uk
Subject: Re: [PATCH 16/16] tcg: Remove TARGET_ALIGNED_ONLY
Date: Wed, 10 May 2023 16:11:53 +0100 [thread overview]
Message-ID: <ce70d9d9-71e5-d185-9841-b1283de72fe1@linaro.org> (raw)
In-Reply-To: <b0e9ba06-ad37-65ac-da6a-f041e5187660@linaro.org>
On 5/10/23 15:43, Philippe Mathieu-Daudé wrote:
> On 2/5/23 18:08, Richard Henderson wrote:
>> All uses have now been expunged.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> include/exec/memop.h | 13 ++-----------
>> include/exec/poison.h | 1 -
>> tcg/tcg.c | 5 -----
>> 3 files changed, 2 insertions(+), 17 deletions(-)
>
>
>> diff --git a/tcg/tcg.c b/tcg/tcg.c
>> index cfd3262a4a..2ce9dba25c 100644
>> --- a/tcg/tcg.c
>> +++ b/tcg/tcg.c
>> @@ -2071,13 +2071,8 @@ static const char * const ldst_name[] =
>> };
>> static const char * const alignment_name[(MO_AMASK >> MO_ASHIFT) + 1] = {
>> -#ifdef TARGET_ALIGNED_ONLY
>> - [MO_UNALN >> MO_ASHIFT] = "un+",
>
> Maybe we want to keep the "un+" prefix.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
>> - [MO_ALIGN >> MO_ASHIFT] = "",
>> -#else
>> [MO_UNALN >> MO_ASHIFT] = "",
>> [MO_ALIGN >> MO_ASHIFT] = "al+",
Done.
r~
next prev parent reply other threads:[~2023-05-10 15:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 16:08 [PATCH 00/16] tcg: Remove TARGET_ALIGNED_ONLY Richard Henderson
2023-05-02 16:08 ` [PATCH 01/16] target/alpha: Use MO_ALIGN for system UNALIGN() Richard Henderson
2023-05-02 16:08 ` [PATCH 02/16] target/alpha: Use MO_ALIGN where required Richard Henderson
2023-05-02 16:08 ` [PATCH 03/16] target/alpha: Remove TARGET_ALIGNED_ONLY Richard Henderson
2023-05-02 16:08 ` [PATCH 04/16] target/hppa: Use MO_ALIGN for system UNALIGN() Richard Henderson
2023-05-02 16:08 ` [PATCH 05/16] target/hppa: Remove TARGET_ALIGNED_ONLY Richard Henderson
2023-05-02 16:08 ` [PATCH 06/16] target/mips: Add MO_ALIGN to gen_llwp, gen_scwp Richard Henderson
2023-05-02 16:08 ` [PATCH 07/16] target/mips: Add missing default_tcg_memop_mask Richard Henderson
2023-05-02 16:08 ` [PATCH 08/16] target/mips: Use MO_ALIGN instead of 0 Richard Henderson
2023-05-10 13:37 ` Philippe Mathieu-Daudé
2023-05-02 16:08 ` [PATCH 09/16] target/mips: Remove TARGET_ALIGNED_ONLY Richard Henderson
2023-05-02 16:08 ` [PATCH 10/16] target/nios2: " Richard Henderson
2023-05-10 14:45 ` Philippe Mathieu-Daudé
2023-05-02 16:08 ` [PATCH 11/16] target/sh4: Use MO_ALIGN where required Richard Henderson
2023-05-10 13:41 ` Philippe Mathieu-Daudé
2023-05-02 16:08 ` [PATCH 12/16] target/sh4: Remove TARGET_ALIGNED_ONLY Richard Henderson
2023-05-10 14:44 ` Philippe Mathieu-Daudé
2023-05-02 16:08 ` [PATCH 13/16] target/sparc: Use MO_ALIGN where required Richard Henderson
2023-05-03 20:26 ` Mark Cave-Ayland
2023-05-02 16:08 ` [PATCH 14/16] target/sparc: Use cpu_ld*_code_mmu Richard Henderson
2023-05-03 20:27 ` Mark Cave-Ayland
2023-05-02 16:08 ` [PATCH 15/16] target/sparc: Remove TARGET_ALIGNED_ONLY Richard Henderson
2023-05-03 20:28 ` Mark Cave-Ayland
2023-05-02 16:08 ` [PATCH 16/16] tcg: " Richard Henderson
2023-05-10 14:43 ` Philippe Mathieu-Daudé
2023-05-10 15:11 ` Richard Henderson [this message]
2023-05-10 11:16 ` [PATCH 00/16] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce70d9d9-71e5-d185-9841-b1283de72fe1@linaro.org \
--to=richard.henderson@linaro.org \
--cc=crwulff@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).