Re: [Qemu-devel] [PATCH 4/5] pr-manager: add query-pr-managers QMP command

[Paolo Bonzini <pbonzini@redhat.com>]

On 28/06/2018 09:05, Michal Prívozník wrote:
>> qemu-pr-helper anyway does something only when a guests sends it a PR
>> command - and with libvirt's per-guest model, that would (hopefully)
>> mean that the only case that remains is when someone manually kills the
>> qemu-pr-helper process.  In that case there's a certain amount of PEBKAC
>> involved... :)
>
> Unless an assert() is triggered ;-)

Indeed, but that should still happen "when a guest sends it a PR
command".  The problematic case would only arise if qemu-pr-helper
crashes between the last time QEMU sent a command, and the time libvirt
sends query-pr-managers.

> But since you merged my suggested changes in 5/5 libvirt can catch the
> event pretty soon, so in my testing qemu was still left with 3-4
> connection retries which is plenty.

Good, thanks.

Paolo