From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <famz@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Kamil Rytarowski" <kamil@netbsd.org>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib
Date: Thu, 17 Aug 2017 14:25:33 +0200 [thread overview]
Message-ID: <ce95864f-1d06-6c58-be2f-141387348e30@redhat.com> (raw)
In-Reply-To: <20170817122148.GE5539@stefanha-x1.localdomain>
On 17/08/2017 14:21, Stefan Hajnoczi wrote:
>> + guest = QEMUMachine(binary=os.environ.get("QEMU", "qemu-system-x86_64"),
>> + args=args)
>> + guest._vga = "std"
> _vga is a protected field. We don't inherit from QEMUMachine so it
> shouldn't be accessed directly. One option is to add a vga argument to
> the QEMUMachine() constructor.
You can just use "-device VGA" here, since this code is x86-specific.
"-vga none -device VGA" works well, so patch 2 can be dropped.
Paolo
next prev parent reply other threads:[~2017-08-17 12:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 2:47 [Qemu-devel] [PATCH RFC v2 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux) Fam Zheng
2017-08-17 2:47 ` [Qemu-devel] [PATCH RFC v2 01/10] gitignore: Ignore vm test images Fam Zheng
2017-08-17 10:10 ` Stefan Hajnoczi
2017-08-17 2:47 ` [Qemu-devel] [PATCH RFC v2 02/10] qemu.py: Add variable vga type Fam Zheng
2017-08-17 10:10 ` Stefan Hajnoczi
2017-08-17 2:47 ` [Qemu-devel] [PATCH RFC v2 03/10] qemu.py: Add "wait()" method Fam Zheng
2017-08-17 10:12 ` Stefan Hajnoczi
2017-08-17 2:47 ` [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib Fam Zheng
2017-08-17 10:17 ` Fam Zheng
2017-08-17 12:21 ` Stefan Hajnoczi
2017-08-17 12:25 ` Paolo Bonzini [this message]
2017-08-17 2:47 ` [Qemu-devel] [PATCH RFC v2 05/10] tests: Add ubuntu.i386 image Fam Zheng
2017-08-17 2:47 ` [Qemu-devel] [PATCH RFC v2 06/10] tests: Add FreeBSD image Fam Zheng
2017-08-17 2:47 ` [Qemu-devel] [PATCH RFC v2 07/10] tests: Add NetBSD image Fam Zheng
2017-08-17 11:17 ` Kamil Rytarowski
2017-08-17 2:47 ` [Qemu-devel] [PATCH RFC v2 08/10] tests: Add OpenBSD image Fam Zheng
2017-08-17 2:47 ` [Qemu-devel] [PATCH RFC v2 09/10] Makefile: Add rules to run vm tests Fam Zheng
2017-08-17 2:47 ` [Qemu-devel] [PATCH RFC v2 10/10] MAINTAINERS: Add tests/vm entry Fam Zheng
2017-08-17 3:17 ` [Qemu-devel] [PATCH RFC v2 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux) no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce95864f-1d06-6c58-be2f-141387348e30@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=kamil@netbsd.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).