[PATCH] system/memory: Remove DEVICE_HOST_ENDIAN definition

[PATCH] system/memory: Remove DEVICE_HOST_ENDIAN definition

[Philippe Mathieu-Daudé]

Since the previous commit ("exec/memory.h: make devend_memop
"target defines" agnostic") there is a single use of the
DEVICE_HOST_ENDIAN definition in ram_device_mem_ops: inline
it and remove its definition altogether.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
Based-on: <20250422192819.302784-1-richard.henderson@linaro.org>
---
 include/exec/cpu-common.h | 6 ------
 system/memory-internal.h  | 3 ---
 system/memory.c           | 2 +-
 3 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
index 9b83fd7ac88..dab1e7e5809 100644
--- a/include/exec/cpu-common.h
+++ b/include/exec/cpu-common.h
@@ -44,12 +44,6 @@ enum device_endian {
     DEVICE_LITTLE_ENDIAN,
 };
 
-#if HOST_BIG_ENDIAN
-#define DEVICE_HOST_ENDIAN DEVICE_BIG_ENDIAN
-#else
-#define DEVICE_HOST_ENDIAN DEVICE_LITTLE_ENDIAN
-#endif
-
 /* address in the RAM (different from a physical address) */
 #if defined(CONFIG_XEN_BACKEND)
 typedef uint64_t ram_addr_t;
diff --git a/system/memory-internal.h b/system/memory-internal.h
index 085e81a9fe4..ed5d75de24b 100644
--- a/system/memory-internal.h
+++ b/system/memory-internal.h
@@ -41,9 +41,6 @@ void mtree_print_dispatch(struct AddressSpaceDispatch *d,
 /* returns true if end is big endian. */
 static inline bool devend_big_endian(enum device_endian end)
 {
-    QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN &&
-                      DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN);
-
     if (end == DEVICE_NATIVE_ENDIAN) {
         return target_words_bigendian();
     }
diff --git a/system/memory.c b/system/memory.c
index 7e2f16f4e95..b398f656c2f 100644
--- a/system/memory.c
+++ b/system/memory.c
@@ -1382,7 +1382,7 @@ static void memory_region_ram_device_write(void *opaque, hwaddr addr,
 static const MemoryRegionOps ram_device_mem_ops = {
     .read = memory_region_ram_device_read,
     .write = memory_region_ram_device_write,
-    .endianness = DEVICE_HOST_ENDIAN,
+    .endianness = HOST_BIG_ENDIAN ? DEVICE_BIG_ENDIAN : DEVICE_LITTLE_ENDIAN,
     .valid = {
         .min_access_size = 1,
         .max_access_size = 8,
-- 
2.47.1

Re: [PATCH] system/memory: Remove DEVICE_HOST_ENDIAN definition

[David Hildenbrand]

On 23.04.25 13:16, Philippe Mathieu-Daudé wrote:
> Since the previous commit ("exec/memory.h: make devend_memop
> "target defines" agnostic") there is a single use of the
> DEVICE_HOST_ENDIAN definition in ram_device_mem_ops: inline
> it and remove its definition altogether.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb

Re: [PATCH] system/memory: Remove DEVICE_HOST_ENDIAN definition

[Richard Henderson]

On 4/23/25 04:16, Philippe Mathieu-Daudé wrote:
> Since the previous commit ("exec/memory.h: make devend_memop
> "target defines" agnostic") there is a single use of the
> DEVICE_HOST_ENDIAN definition in ram_device_mem_ops: inline
> it and remove its definition altogether.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> Based-on:<20250422192819.302784-1-richard.henderson@linaro.org>
> ---
>   include/exec/cpu-common.h | 6 ------
>   system/memory-internal.h  | 3 ---
>   system/memory.c           | 2 +-
>   3 files changed, 1 insertion(+), 10 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH] system/memory: Remove DEVICE_HOST_ENDIAN definition

[Philippe Mathieu-Daudé]

On 23/4/25 13:16, Philippe Mathieu-Daudé wrote:
> Since the previous commit ("exec/memory.h: make devend_memop
> "target defines" agnostic") there is a single use of the
> DEVICE_HOST_ENDIAN definition in ram_device_mem_ops: inline
> it and remove its definition altogether.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Based-on: <20250422192819.302784-1-richard.henderson@linaro.org>
> ---
>   include/exec/cpu-common.h | 6 ------
>   system/memory-internal.h  | 3 ---
>   system/memory.c           | 2 +-
>   3 files changed, 1 insertion(+), 10 deletions(-)

Patch queued.