Re: [PATCH v4 00/16] hw/pci-host/raven clean ups

[Harsh Prateek Bora <harshpb@linux.ibm.com>]

+ Mark (since he reviewed v3)
+ Michael, Marcel (for changes in include/hw/pci/pci_host.h , although 
appear safe as only raven specific)

On 10/18/25 19:34, BALATON Zoltan wrote:
> Hello,
> 
> This series cleans up and simplifies the raven model which does some
> strange stuff that no other pci-host is doing and does it in a
> convoluted way and also has some legacy bits that can be removed.
> Apart from making the model much more readable this also fixes the
> non-contiguous IO control bit which was there but did not work as it
> was not connected but apparently it's not really used by any guest so
> that wasn't noticed.
> 
> Regards,
> BALATON Zoltan
> 
> Link to previous version:
> https://patchew.org/QEMU/cover.1758219840.git.balaton@eik.bme.hu/
> 
> V4:
> - added R-b tags from Mark and address some of his review comments
> (other comments not addressed were answered on the list explaining why
> I did not add them to this version)
> - added new patches to fix creation and reset of prep-systemio
> - rebased on master
> 
> V3:
> - rebase on master
> - Fix issue with device-crash-test reported by Akihiko Odaki: make
> sure device is correctly used by adding assert and making it not user
> creatable in patch 14.
> 
> v2:
> - rebase on master
> - add R-b tags from Philippe
> 
> BALATON Zoltan (16):
>    hw/pci-host/raven: Simplify PCI facing part
>    hw/pci-host/raven: Simplify host bridge type declaration
>    hw/pci-host/raven: Use DEFINE_TYPES macro
>    hw/pci-host/raven: Simplify PCI bus creation
>    hw/pci-host/raven: Simplify PCI interrupt routing
>    hw/pci-host/raven: Simplify direct config access address decoding
>    hw/pci-host/raven: Rename direct config access ops
>    hw/pci-host/raven: Use correct parameter in direct access ops
>    hw/pci-host/raven: Do not use parent object for mmcfg region
>    hw/pci-host/raven: Fix PCI config direct access region
>    hw/pci-host/raven: Simpify discontiguous IO access
>    hw/pci-host/raven: Move bus master address space creation to one place
>    hw/pci-host/raven: Do not map regions in init method
>    hw/ppc/prep: Always create prep-systemio
>    hw/ppc/prep: Fix non-contiguous IO control bit
>    hw/ppc/prep: Add reset method to prep-systemio
> 
>   hw/pci-host/raven.c       | 328 ++++++++++++--------------------------
>   hw/ppc/prep.c             |  35 ++--
>   hw/ppc/prep_systemio.c    |  26 ++-
>   include/hw/pci/pci_host.h |   1 -
>   4 files changed, 145 insertions(+), 245 deletions(-)
>