From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz7m5-0002Q0-LN for qemu-devel@nongnu.org; Tue, 25 Oct 2016 15:52:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz7m4-0005Pj-Hi for qemu-devel@nongnu.org; Tue, 25 Oct 2016 15:52:41 -0400 References: <1476725535-3350-1-git-send-email-ashijeetacharya@gmail.com> <1476725535-3350-6-git-send-email-ashijeetacharya@gmail.com> From: Eric Blake Message-ID: Date: Tue, 25 Oct 2016 14:52:33 -0500 MIME-Version: 1.0 In-Reply-To: <1476725535-3350-6-git-send-email-ashijeetacharya@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3673rsJfLoRdmthiAgDgxI3KConPrx1dx" Subject: Re: [Qemu-devel] [PATCH v3 5/5] qapi: allow blockdev-add for ssh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya , kwolf@redhat.com Cc: rjones@redhat.com, jcody@redhat.com, mreitz@redhat.com, berrange@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3673rsJfLoRdmthiAgDgxI3KConPrx1dx From: Eric Blake To: Ashijeet Acharya , kwolf@redhat.com Cc: rjones@redhat.com, jcody@redhat.com, mreitz@redhat.com, berrange@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Message-ID: Subject: Re: [PATCH v3 5/5] qapi: allow blockdev-add for ssh References: <1476725535-3350-1-git-send-email-ashijeetacharya@gmail.com> <1476725535-3350-6-git-send-email-ashijeetacharya@gmail.com> In-Reply-To: <1476725535-3350-6-git-send-email-ashijeetacharya@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/17/2016 12:32 PM, Ashijeet Acharya wrote: > Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to > support blockdev-add for SSH network protocol driver. Use only 'struct > InetSocketAddress' since SSH only supports connection over TCP. >=20 > Signed-off-by: Ashijeet Acharya > --- > qapi/block-core.json | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) >=20 > +++ b/qapi/block-core.json > @@ -1716,7 +1716,8 @@ > 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', > 'host_device', 'http', 'https', 'luks', 'null-aio', 'null-= co', > 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', > - 'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] } > + 'replication', 'ssh', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc'= , > + 'vvfat' ] } Please update the comment just before the enum that mentions 'ssh' as an addition in 2.8. > +## > +# @BlockdevOptionsSsh > +# > +# @server: host address > +# > +# @path: path to the image on the host > +# > +# @user: #optional user as which to connect, defaults t= o current > +# local user name > +# > +# @host_key_check #optional defines how and what to check the ho= st > +# key against, defaults to "yes" Please s/host_key_check/host-key-check/ - new interfaces should favor dash, not underscore. (The C code will be the same, though.) > +# > +# Since 2.8 > +## > +{ 'struct': 'BlockdevOptionsSsh', > + 'data': { 'server': 'InetSocketAddress', > + 'path': 'str', > + '*user': 'str', > + '*host_key_check': 'str' } } Is host-key-check truly a free-form string, or is it only a finite set of valid possibilities, where 'yes' is the default string? Would it be better to express it as an enum instead of a raw string? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3673rsJfLoRdmthiAgDgxI3KConPrx1dx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYD7gBAAoJEKeha0olJ0NqN8sIAJQbT5v2WTeeweSs66xwu/nf BIVPMKRk6G6+nkcLT7GoREq34pOcwPIxmoNZbLJqwDCreW4+Krltr+iH3M9vZ0eA 43AbeQ1P/sblAg6AXSKgp4o1bB/WiY1VyqUNqMv4UwwRddUrozzaEOBRE6HtcC58 acyRRCYYcDDEXMktgNw4T4A6bv4v0KFJstfzApRFE1ldWijaaJGVzwC0Oca18zVa 8mYGMnAJIrcl0szw4egwwmykSA2WSXfGYgvQVwSM1I/kbih9x3KxUAlPKHqk4dpB 4eDE2rqbDsgdIxK8u0yB7ZxNwX66GbyZ0sBZpSP0d7SNY0bC6tV+65xGZ5TWSHM= =/5Tp -----END PGP SIGNATURE----- --3673rsJfLoRdmthiAgDgxI3KConPrx1dx--