From: Laurent Vivier <laurent@vivier.eu>
To: Arnd Bergmann <arnd@arndb.de>, Filip Bozuta <Filip.Bozuta@rt-rk.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Max Filippov" <jcmvbkbc@gmail.com>,
amarkovic@wavecomp.com, philmd@redhat.com
Subject: Re: [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl
Date: Wed, 15 Jan 2020 17:32:17 +0100 [thread overview]
Message-ID: <ceaf44c0-fd6c-c280-7f95-7bc133553089@vivier.eu> (raw)
In-Reply-To: <CAK8P3a187rPhma7Q6o+hCF3h0=5MLZwh49+JqKt6BvVsAB1efQ@mail.gmail.com>
Le 15/01/2020 à 17:18, Arnd Bergmann a écrit :
> On Wed, Jan 15, 2020 at 4:53 PM Filip Bozuta <Filip.Bozuta@rt-rk.com> wrote:
>>
>> This patch implements functionality of following ioctl:
>>
>> SNDRV_TIMER_IOCTL_TREAD - Setting enhanced time read
>>
>> Sets enhanced time read which is used for reading time with timestamps
>> and events. The third ioctl's argument is a pointer to an 'int'. Enhanced
>> reading is set if the third argument is different than 0, otherwise normal
>> time reading is set.
>>
>> Implementation notes:
>>
>> Because the implemented ioctl has 'int' as its third argument, the
>> implementation was straightforward.
>>
>> Signed-off-by: Filip Bozuta <Filip.Bozuta@rt-rk.com>
>
> I think this one is wrong when you go between 32-bit and 64-bit
kernel uses an "int" and "int" is always 32bit.
The problem is most likely with timespec I think.
> targets, and it gets worse with the kernel patches that just got
> merged for linux-5.5, which extends the behavior to deal with
> 64-bit time_t on 32-bit architectures.
>
> Please have a look at
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?h=80fe7430c70859
>
> Arnd
>
Yes, we already had the same kind of problem with SIOCGSTAMP and
SIOCGSTAMPNS.
Do the kernel patches add new ioctl numbers to differentiate 32bit and
64bit time_t?
Thanks,
Laurent
next prev parent reply other threads:[~2020-01-15 16:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 15:53 [PATCH 00/12] linux-user: Add support for real time clock and Filip Bozuta
2020-01-15 15:53 ` [PATCH 01/12] linux-user: Add support for enabling/disabling RTC features using ioctls Filip Bozuta
2020-01-15 15:53 ` [PATCH 02/12] linux-user: Add support for getting/setting RTC time and alarm " Filip Bozuta
2020-01-15 15:53 ` [PATCH 03/12] linux-user: Add support for getting/setting RTC periodic interrupt and epoch " Filip Bozuta
2020-01-15 16:46 ` Laurent Vivier
2020-01-15 15:53 ` [PATCH 04/12] linux-user: Add support for getting/setting RTC wakeup alarm " Filip Bozuta
2020-01-15 15:53 ` [PATCH 05/12] linux-user: Add support for getting/setting RTC PLL correction " Filip Bozuta
2020-01-15 15:53 ` [PATCH 06/12] linux-user: Add support for read/clear RTC voltage low detector " Filip Bozuta
2020-01-15 15:53 ` [PATCH 07/12] linux-user: Add support for getting alsa timer version and id Filip Bozuta
2020-01-15 15:53 ` [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl Filip Bozuta
2020-01-15 16:18 ` Arnd Bergmann
2020-01-15 16:32 ` Laurent Vivier [this message]
2020-01-15 16:37 ` Arnd Bergmann
2020-01-15 19:17 ` Filip Bozuta
2020-01-15 19:51 ` Arnd Bergmann
2020-01-15 21:30 ` Laurent Vivier
2020-01-15 21:52 ` Laurent Vivier
2020-01-16 2:49 ` Aleksandar Markovic
2020-01-16 11:27 ` Aleksandar Markovic
2020-01-16 12:00 ` Arnd Bergmann
2020-01-17 20:50 ` Aleksandar Markovic
2020-01-17 21:45 ` Arnd Bergmann
2020-01-17 21:54 ` Alexandre Belloni
2020-01-15 15:53 ` [PATCH 09/12] linux-user: Add support for getting/setting specified alsa timer parameters using ioctls Filip Bozuta
2020-01-15 15:53 ` [PATCH 10/12] linux-user: Add support for selecting alsa timer using ioctl Filip Bozuta
2020-01-15 15:53 ` [PATCH 11/12] linux-user: Add support for getting/setting selected alsa timer parameters using ioctls Filip Bozuta
2020-01-15 15:53 ` [PATCH 12/12] linux-user: Add support for selected alsa timer instructions " Filip Bozuta
2020-01-15 16:35 ` [PATCH 00/12] linux-user: Add support for real time clock and Laurent Vivier
-- strict thread matches above, loose matches on Subject: below --
2020-01-09 12:59 Filip Bozuta
2020-01-09 12:59 ` [PATCH 08/12] linux-user: Add support for setting alsa timer enhanced read using ioctl Filip Bozuta
2020-01-14 12:44 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceaf44c0-fd6c-c280-7f95-7bc133553089@vivier.eu \
--to=laurent@vivier.eu \
--cc=Filip.Bozuta@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=arnd@arndb.de \
--cc=berrange@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).