From: Eric Blake <eblake@redhat.com>
To: Leonid Bloch <lbloch@janustech.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/6 for-3.0] Update .gitignore
Date: Mon, 30 Jul 2018 10:40:41 -0500 [thread overview]
Message-ID: <ceb7a6e9-1dc2-b5f5-c81e-ba08841c8ba9@redhat.com> (raw)
In-Reply-To: <20180729212744.23709-2-lbloch@janustech.com>
On 07/29/2018 04:27 PM, Leonid Bloch wrote:
> Adds /roms/vgabios to .gitignore - this directory appears after the
> build, and was not ignored by Git so far.
>
Actually, that's the directories for one of the submodules. It seems
fishy to have a directory listed in both .gitignore and .gitmodules at
the same time, so I'm inclined to NACK this patch, and instead figure
out what in the build is dirtying the directory when the submodule is
not checked out.
> Signed-off-by: Leonid Bloch <lbloch@janustech.com>
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index 5668d02782..2b3b30ae9f 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -212,3 +212,4 @@ trace-dtrace-root.dtrace
> trace-ust-all.h
> trace-ust-all.c
> /target/arm/decode-sve.inc.c
> +/roms/vgabios
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-07-30 15:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 21:27 [Qemu-devel] [PATCH 0/6] qcow2: Make the L2 cache cover the whole image by default Leonid Bloch
2018-07-29 21:27 ` [Qemu-devel] [PATCH 1/6 for-3.0] Update .gitignore Leonid Bloch
2018-07-30 15:40 ` Eric Blake [this message]
2018-07-30 15:43 ` Eric Blake
2018-07-29 21:27 ` [Qemu-devel] [PATCH 2/6 for-3.0] qcow2: A grammar fix in conflicting cache sizing error message Leonid Bloch
2018-07-29 21:27 ` [Qemu-devel] [PATCH 3/6 for-3.0] qcow2: Options' documentation fixes Leonid Bloch
2018-08-03 11:27 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2018-08-04 11:52 ` Leonid Bloch
2018-07-29 21:27 ` [Qemu-devel] [PATCH 4/6] qcow2: Update total_sectors when resizing the image Leonid Bloch
2018-07-30 9:43 ` Kevin Wolf
2018-07-30 11:41 ` Leonid Bloch
2018-07-30 12:28 ` Kevin Wolf
2018-08-03 11:56 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2018-07-29 21:27 ` [Qemu-devel] [PATCH 5/6] qcow2: Make the default L2 cache sufficient to cover the entire image Leonid Bloch
2018-07-29 21:27 ` [Qemu-devel] [PATCH 6/6] qcow2: Resize the cache upon image resizing Leonid Bloch
2018-08-03 12:42 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2018-08-04 11:53 ` Leonid Bloch
2018-07-30 10:55 ` [Qemu-devel] [PATCH 0/6] qcow2: Make the L2 cache cover the whole image by default Kevin Wolf
2018-07-30 12:13 ` Leonid Bloch
2018-07-30 12:44 ` Kevin Wolf
2018-08-03 13:37 ` Alberto Garcia
2018-08-03 14:55 ` Kevin Wolf
2018-08-06 7:47 ` Alberto Garcia
2018-08-06 10:45 ` Kevin Wolf
2018-08-06 11:07 ` Alberto Garcia
2018-08-06 11:30 ` Kevin Wolf
2018-08-06 11:41 ` Alberto Garcia
2018-08-03 7:38 ` Kevin Wolf
2018-08-04 11:48 ` Leonid Bloch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceb7a6e9-1dc2-b5f5-c81e-ba08841c8ba9@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=lbloch@janustech.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).