From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C1FAC4338F for ; Mon, 23 Aug 2021 19:03:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C493F613CF for ; Mon, 23 Aug 2021 19:03:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C493F613CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIFDv-0005Gl-15 for qemu-devel@archiver.kernel.org; Mon, 23 Aug 2021 15:03:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIFCG-0002u6-EU for qemu-devel@nongnu.org; Mon, 23 Aug 2021 15:01:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIFCE-0008Oa-Rb for qemu-devel@nongnu.org; Mon, 23 Aug 2021 15:01:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629745282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Ro61zTs4YGXyXe+HqlOBXAB/k4drERQr7JHaZIZZsA=; b=LMPtW6q+7wnHfBNETz2TzvFHZn6YJWhOXwKiDQukhNAYAlZe4BqWUXZVXKLCCU8uvqQU76 fBbw+NjwBaWfg9NHwmwbxpM5XULp6ukyr2aHpBE7gnUeBiHPnj6RA2uYv0yj9/LZ69P91I ydXhXrjYBMw8ZsQfbxlWuPuHSYHDuR4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-ulGaKmxzM1mbCxnN5DLnAQ-1; Mon, 23 Aug 2021 15:01:14 -0400 X-MC-Unique: ulGaKmxzM1mbCxnN5DLnAQ-1 Received: by mail-wm1-f71.google.com with SMTP id r4-20020a1c4404000000b002e728beb9fbso65550wma.9 for ; Mon, 23 Aug 2021 12:01:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=4Ro61zTs4YGXyXe+HqlOBXAB/k4drERQr7JHaZIZZsA=; b=Po7aJdnu+r2eSZQQ6kVpByunnzkGo64WxMciUjX46AT8NYqf85Bi7A/t2SKSO5DUqN Jby72v1p1HO/YhP4fQ2kDaNVyFyAIC3LLTXmc6QnHYYpJc0R5yJw28HfhQPM/N1Skmr9 sOpzxzK/XO84BISLV/tv4kmPUv0JJVIpWzW4QV1ZT2hRnjKI2PAAMNHuvizAwlFanY03 7OLmJ0RD6pZIzSOEX33Yu0sLB9d2gJpLk4F/CFU8rZQJBIzHV1iWF7f2RtfcG6Fl4f+q kDyxOuz8VsxZgDJqVfYqH5qwwG6UpZeF0uvbjT1oku+lkY1gPNJ5a7HlcioifmJBnosP 2fhA== X-Gm-Message-State: AOAM5300PlVZQt1YTHRu7cHBDqHWDQ+5cgNTDzCL+PFbobDc9fEQP9iq aOvfCWreE/LV1w4sSZlR8NgkDx32Sa5jIfwQlZvwnfJEhUElXYb6UHHf1H/lqUnRrovZYJtqq0U MbnyOj9GOv0I0fEw= X-Received: by 2002:adf:f9cb:: with SMTP id w11mr7339762wrr.382.1629745273156; Mon, 23 Aug 2021 12:01:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBWHb1SgMczOmoZxsfE3gMD2mUq/gfn4nfMPUo9JlVEDVRrkpkq3nZGZScFn9yFyKi6Z1OTQ== X-Received: by 2002:adf:f9cb:: with SMTP id w11mr7339735wrr.382.1629745273016; Mon, 23 Aug 2021 12:01:13 -0700 (PDT) Received: from [192.168.3.132] (p5b0c60c6.dip0.t-ipconnect.de. [91.12.96.198]) by smtp.gmail.com with ESMTPSA id k17sm534858wmj.0.2021.08.23.12.01.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Aug 2021 12:01:12 -0700 (PDT) Subject: Re: [RFC PATCH v2 2/5] hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210823164157.751807-1-philmd@redhat.com> <20210823164157.751807-3-philmd@redhat.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Mon, 23 Aug 2021 21:01:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210823164157.751807-3-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -55 X-Spam_score: -5.6 X-Spam_bar: ----- X-Spam_report: (-5.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.743, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.023, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jason Wang , Li Qiang , Qiuhao Li , Peter Xu , Alexander Bulekov , qemu-arm@nongnu.org, Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini , "Edgar E . Iglesias" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 23.08.21 18:41, Philippe Mathieu-Daudé wrote: > We are going to introduce more MemTxResult bits, so it is > safer to check for !MEMTX_OK rather than MEMTX_ERROR. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb