From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DB1C433DB for ; Tue, 2 Mar 2021 09:45:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9FC560C41 for ; Tue, 2 Mar 2021 09:45:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9FC560C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH1aU-0002Mh-MB for qemu-devel@archiver.kernel.org; Tue, 02 Mar 2021 04:45:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH1Zb-0001fB-6f for qemu-devel@nongnu.org; Tue, 02 Mar 2021 04:44:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lH1ZX-0006y5-E1 for qemu-devel@nongnu.org; Tue, 02 Mar 2021 04:44:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614678245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5J4TUPfuppElJI3IQaByRHJaXBhkc7sXODOqUnDwDOM=; b=hUYYmgu2AeDCRa6NVP/51//OEQQm9Ifk1lpBBODD9fxJhbI714aHKYoW5Kz3ajG+X5RwYe oCCXyS2FziNc3wNC48tXWa9yyhHBTg0cfD4oiQp6z195bJRXeRWH9TI1tZ0kqkeH5jkb6+ kM5pKWterMVx/SVEVk64QWBrAMLxUJk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-P7NpXCIaMIqapczGD6W_8A-1; Tue, 02 Mar 2021 04:44:03 -0500 X-MC-Unique: P7NpXCIaMIqapczGD6W_8A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 27391835E20; Tue, 2 Mar 2021 09:44:02 +0000 (UTC) Received: from [10.36.114.189] (ovpn-114-189.ams2.redhat.com [10.36.114.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80DDA1724C; Tue, 2 Mar 2021 09:43:56 +0000 (UTC) To: Igor Mammedov References: <20210301104833.45580-1-david@redhat.com> <20210302100614.42acfe68@MiWiFi-RA69-srv> From: David Hildenbrand Organization: Red Hat GmbH Subject: Re: [PATCH v1] acpi: increase maximum size for "etc/table-loader" blob Message-ID: Date: Tue, 2 Mar 2021 10:43:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210302100614.42acfe68@MiWiFi-RA69-srv> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Richard Henderson , qemu-devel@nongnu.org, Alistair Francis , Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 02.03.21 10:06, Igor Mammedov wrote: > On Mon, 1 Mar 2021 11:48:33 +0100 > David Hildenbrand wrote: > >> The resizeable memory region that is created for the cmd blob has a maximum >> size of ACPI_BUILD_ALIGN_SIZE - 4k. This used to be sufficient, however, >> as we try fitting in additional data (e.g., vmgenid, nvdimm, intel-iommu), >> we require more than 4k and can crash QEMU when trying to resize the >> resizeable memory region beyond its maximum size: >> $ build/qemu-system-x86_64 --enable-kvm \ >> -machine q35,nvdimm=on \ >> -smp 1 \ >> -cpu host \ >> -m size=2G,slots=8,maxmem=4G \ >> -object memory-backend-file,id=mem0,mem-path=/tmp/nvdimm,size=256M \ >> -device nvdimm,label-size=131072,memdev=mem0,id=nvdimm0,slot=1 \ >> -nodefaults \ >> -device vmgenid \ >> -device intel-iommu > > I don't see what's here that would make cmd_blob go above 4k. > can you try identify what actually fills it up (perhaps we have a hidden bug elsewhere)? VM initialization: bios_linker_loader_alloc: allocating memory for 'etc/acpi/tables' -> new table size: 128 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 64 - 9659 -> new table size: 256 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 384 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 512 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 640 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 9659 - 9903 -> new table size: 768 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 9903 - 10023 -> new table size: 896 bios_linker_loader_alloc: allocating memory for 'etc/vmgenid_guid' -> new table size: 1024 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/vmgenid_guid' -> new table size: 1280 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10023 - 10225 -> new table size: 1408 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10225 - 10281 -> new table size: 1536 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10281 - 10505 -> new table size: 1664 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10505 - 10577 -> new table size: 1792 bios_linker_loader_alloc: allocating memory for 'etc/acpi/nvdimm-mem' -> new table size: 1920 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/nvdimm-mem' -> new table size: 2048 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10577 - 11471 -> new table size: 2176 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 11471 - 11695 -> new table size: 2304 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 11695 - 11735 -> new table size: 2432 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 2560 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 2688 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 2816 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 2944 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3072 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3200 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3328 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3456 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3584 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 11735 - 11807 -> new table size: 3712 bios_linker_loader_alloc: allocating memory for 'etc/acpi/rsdp' -> new table size: 3840 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/rsdp' to 'etc/acpi/tables' -> new table size: 3968 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/rsdp' for range 0 - 20 -> new table size: 4096 When the bios/guest boots up: bios_linker_loader_alloc: allocating memory for 'etc/acpi/tables' -> new table size: 128 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 64 - 9769 -> new table size: 256 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 384 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 512 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 640 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 9769 - 10013 -> new table size: 768 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10013 - 10133 -> new table size: 896 bios_linker_loader_alloc: allocating memory for 'etc/vmgenid_guid' -> new table size: 1024 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/vmgenid_guid' -> new table size: 1280 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10133 - 10335 -> new table size: 1408 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10335 - 10391 -> new table size: 1536 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10391 - 10615 -> new table size: 1664 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10615 - 10675 -> new table size: 1792 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10675 - 10747 -> new table size: 1920 bios_linker_loader_alloc: allocating memory for 'etc/acpi/nvdimm-mem' -> new table size: 2048 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/nvdimm-mem' -> new table size: 2176 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 10747 - 11641 -> new table size: 2304 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 11641 - 11865 -> new table size: 2432 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 11865 - 11905 -> new table size: 2560 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 2688 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 2816 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 2944 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3072 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3200 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3328 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3456 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3584 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3712 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/tables' to 'etc/acpi/tables' -> new table size: 3840 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/tables' for range 11905 - 11981 -> new table size: 3968 bios_linker_loader_alloc: allocating memory for 'etc/acpi/rsdp' -> new table size: 4096 bios_linker_loader_add_pointer: adding pointer in 'etc/acpi/rsdp' to 'etc/acpi/tables' -> new table size: 4224 bios_linker_loader_add_checksum: Adding checksum for 'etc/acpi/rsdp' for range 0 - 20 -> new table size: 4352 -- Thanks, David / dhildenb