From: Laurent Vivier <laurent@vivier.eu>
To: Helge Deller <deller@gmx.de>, qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha
Date: Sat, 13 Feb 2021 17:18:34 +0100 [thread overview]
Message-ID: <cedb0ccc-ff19-56ce-eddc-dba2017a614b@vivier.eu> (raw)
In-Reply-To: <20210201155922.GA18291@ls3530.fritz.box>
Le 01/02/2021 à 16:59, Helge Deller a écrit :
> The hppa and alpha targets miss the #define of the TARGET___O_TMPFILE
> and as such fail to run a trivial symlink command like
>
> ln -s /bin/bash /tmp
>
> which results in an -EINVAL return code.
>
> Adding the define fixes the problem.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> ---
>
> diff --git a/linux-user/alpha/target_fcntl.h b/linux-user/alpha/target_fcntl.h
> index 2617e73472..0a74807a8b 100644
> --- a/linux-user/alpha/target_fcntl.h
> +++ b/linux-user/alpha/target_fcntl.h
> @@ -23,6 +23,7 @@
> #define TARGET_O_CLOEXEC 010000000
> #define TARGET___O_SYNC 020000000
> #define TARGET_O_PATH 040000000
> +#define TARGET___O_TMPFILE 0100000000
>
> #define TARGET_F_GETLK 7
> #define TARGET_F_SETLK 8
> diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h
> index bd966a59b8..08e3a4fcb0 100644
> --- a/linux-user/hppa/target_fcntl.h
> +++ b/linux-user/hppa/target_fcntl.h
> @@ -21,6 +21,7 @@
> #define TARGET_O_CLOEXEC 010000000
> #define TARGET___O_SYNC 000100000
> #define TARGET_O_PATH 020000000
> +#define TARGET___O_TMPFILE 040000000
>
> #define TARGET_F_RDLCK 1
> #define TARGET_F_WRLCK 2
>
Applied to my linux-user-for-6.0 branch.
Thanks,
Laurent
next prev parent reply other threads:[~2021-02-13 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 15:59 [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha Helge Deller
2021-02-13 16:13 ` Laurent Vivier
2021-02-13 16:18 ` Laurent Vivier [this message]
2021-02-22 0:59 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cedb0ccc-ff19-56ce-eddc-dba2017a614b@vivier.eu \
--to=laurent@vivier.eu \
--cc=deller@gmx.de \
--cc=f4bug@amsat.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).