From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED3BC2B9F4 for ; Mon, 28 Jun 2021 13:13:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDFC461C69 for ; Mon, 28 Jun 2021 13:13:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDFC461C69 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgraf.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxr4v-0003CI-TE for qemu-devel@archiver.kernel.org; Mon, 28 Jun 2021 09:13:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxr4A-0001ra-To; Mon, 28 Jun 2021 09:12:46 -0400 Received: from mail.csgraf.de ([85.25.223.15]:33292 helo=zulu616.server4you.de) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxr46-0000pm-LZ; Mon, 28 Jun 2021 09:12:46 -0400 Received: from MacBook-Air.alex.local (dynamic-095-118-187-192.95.118.pool.telefonica.de [95.118.187.192]) by csgraf.de (Postfix) with ESMTPSA id BCB0860800C4; Mon, 28 Jun 2021 15:12:34 +0200 (CEST) Subject: Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration To: "Dr. David Alan Gilbert" , philmd@redhat.com References: <20210601054030.1153249-1-leobras.c@gmail.com> <7cdf3e49-c68b-f5e5-ae1f-8274203a0f11@csgraf.de> From: Alexander Graf Message-ID: Date: Mon, 28 Jun 2021 15:12:33 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=85.25.223.15; envelope-from=agraf@csgraf.de; helo=zulu616.server4you.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , lukasstraub2@web.de, berrange@redhat.com, Leonardo Bras , Juan Quintela , qemu-stable@nongnu.org, peterx@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 28.06.21 13:28, Dr. David Alan Gilbert wrote: > * Alexander Graf (agraf@csgraf.de) wrote: >> On 14.06.21 13:57, Dr. David Alan Gilbert wrote: >>> cc'ing in qemu-stable - I think we'd probably want this on 6.0 >>> (It's currently merged as 7de2e8565335c13fb3516cddbe2e40e366cce273 ). >>> Although you'll probably also want the missing dependency fix >>> Philippe is working (See: >>> Mathieu- ( 42) [RFC PATCH] migration: Add missing dependency on GNUTLS ) >> >> Current master does not compile for me anymore (on macOS) due to this >> change. Can we please either disable yank support and revert this patch, >> pick the GNUTLS dependency patch you refer to quickly and work on a real >> fix afterwards or get the proposed fix in the "missing dependency on >> GNUTLS" discussion done quickly? >> >> Having a broken tree is going to make bisection super painful later. > There was Phil's dependency fix; > https://lore.kernel.org/qemu-devel/YMcTpO2SlVSc%2FHCR@redhat.com/t/ > > but there still seemed to be some argument if this was the right way to > do it. Perfect is the enemy of good :). Can we please fix the tree first, then do "the right way"? I agree that not relying on the GNUTLS header in that file is sensible, but it's been almost 2 weeks since that simple one-liner, working fix was posted without anyone following up with a more complete solution. Alex