From: David Hildenbrand <david@redhat.com>
To: Ani Sinha <anisinha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>
Cc: philmd@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems
Date: Mon, 18 Sep 2023 17:29:40 +0200 [thread overview]
Message-ID: <ceea0d9d-19d6-29e7-cb84-81f85936b8c2@redhat.com> (raw)
In-Reply-To: <CAK3XEhOMqdfyPBm0ZgkirrcaBhOwQt_eOZ7=bbdW8OJpz3hWHg@mail.gmail.com>
On 18.09.23 17:22, Ani Sinha wrote:
> On Mon, Sep 18, 2023 at 7:25 PM Ani Sinha <anisinha@redhat.com> wrote:
>>
>> 32-bit systems do not have a reserved memory for hole64 but they may have a
>> reserved memory space for memory hotplug. Since, hole64 starts after the
>> reserved hotplug memory, the unaligned hole64 start address gives us the
>> end address for this memory hotplug region that the processor may use.
>> Fix this. This ensures that the physical address space bound checking works
>> correctly for 32-bit systems as well.
>
> This patch breaks some unit tests. I am not sure why it did not catch
> it when I tested it before sending.
> Will have to resend after fixing the tests.
Probably because they supply more memory than the system can actually
handle? (e.g., -m 4g on 32bit)?
Agreed with MST that we should glue this to compat machines.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-09-18 15:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 13:54 [PATCH] hw/i386/pc: fix max_used_gpa for 32-bit systems Ani Sinha
2023-09-18 14:01 ` Michael S. Tsirkin
2023-09-18 14:10 ` Ani Sinha
2023-09-18 17:26 ` Michael S. Tsirkin
2023-09-18 15:22 ` Ani Sinha
2023-09-18 15:29 ` David Hildenbrand [this message]
2023-09-18 15:56 ` Ani Sinha
2023-09-18 15:58 ` David Hildenbrand
2023-09-19 3:50 ` Ani Sinha
2023-09-19 4:23 ` Ani Sinha
2023-09-19 6:18 ` Ani Sinha
2023-09-19 7:42 ` David Hildenbrand
2023-09-19 9:13 ` Ani Sinha
2023-09-19 8:08 ` Gerd Hoffmann
2023-09-19 8:15 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceea0d9d-19d6-29e7-cb84-81f85936b8c2@redhat.com \
--to=david@redhat.com \
--cc=anisinha@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).