From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: Roman Bolshakov <rbolshakov@ddn.com>,
Richard Henderson <richard.henderson@linaro.org>,
Phil Dennis-Jordan <phil@philjordan.eu>,
Cameron Esfahani <dirty@apple.com>, Mads Ynddal <mads@ynddal.dk>,
Nguyen Dinh Phi <phind.uet@gmail.com>
Subject: Re: [PATCH-for-10.2 v2] accel/hvf: Fix i386 HVF compilation failures
Date: Fri, 28 Nov 2025 19:28:02 +0100 [thread overview]
Message-ID: <cef1fec7-d50b-44b0-95e9-fb087987e50c@linaro.org> (raw)
In-Reply-To: <20251126134434.14355-1-philmd@linaro.org>
On 26/11/25 14:44, Philippe Mathieu-Daudé wrote:
> From: Nguyen Dinh Phi <phind.uet@gmail.com>
>
> Recent changes introduced build errors in the i386 HVF backend:
>
> - ../accel/hvf/hvf-accel-ops.c:163:17: error: no member named 'guest_debug_enabled' in 'struct AccelCPUState'
> 163 | cpu->accel->guest_debug_enabled = false;
>
> - ../accel/hvf/hvf-accel-ops.c:151:51
> error: no member named 'unblock_ipi_mask' in 'struct AccelCPUState'
>
> - ../target/i386/hvf/hvf.c:736:5
> error: use of undeclared identifier 'rip'
>
> - ../target/i386/hvf/hvf.c:737:5
> error: use of undeclared identifier 'env'
>
> This patch corrects the field usage and move identifier to correct
> function ensuring successful compilation of the i386 HVF backend.
>
> These issues were caused by:
>
> Fixes: 2ad756383e1b (“accel/hvf: Restrict ARM-specific fields of AccelCPUState”)
> Fixes: 2a21c9244740 (“target/i386/hvf: Factor hvf_handle_vmexit() out”)
>
> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> [PMD: Keep setting vcpu_dirty on AArch64]
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Per
https://lore.kernel.org/qemu-devel/c4f85e7d-6311-4b27-b29c-58ad102bda41@gmail.com/:
Tested-by: Nguyen Dinh Phi <phind.uet@gmail.com>
> ---
> Superseeded: <20251126094601.56403-1-phind.uet@gmail.com>
>
> Untested. Once tested, worth to apply as buildfix before tagging?
> ---
> accel/hvf/hvf-accel-ops.c | 5 ++---
> target/i386/hvf/hvf.c | 6 ++----
> 2 files changed, 4 insertions(+), 7 deletions(-)
prev parent reply other threads:[~2025-11-28 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 13:44 [PATCH-for-10.2 v2] accel/hvf: Fix i386 HVF compilation failures Philippe Mathieu-Daudé
2025-11-28 18:28 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cef1fec7-d50b-44b0-95e9-fb087987e50c@linaro.org \
--to=philmd@linaro.org \
--cc=dirty@apple.com \
--cc=mads@ynddal.dk \
--cc=phil@philjordan.eu \
--cc=phind.uet@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).