From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JsHtU-0004rQ-Mf
	for qemu-devel@nongnu.org; Sat, 03 May 2008 09:35:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JsHtT-0004r2-0R
	for qemu-devel@nongnu.org; Sat, 03 May 2008 09:35:16 -0400
Received: from [199.232.76.173] (port=55414 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JsHtS-0004qz-QY
	for qemu-devel@nongnu.org; Sat, 03 May 2008 09:35:14 -0400
Received: from rv-out-0708.google.com ([209.85.198.240])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <bentaylor.solx86@gmail.com>) id 1JsHtS-0007Vk-2T
	for qemu-devel@nongnu.org; Sat, 03 May 2008 09:35:14 -0400
Received: by rv-out-0708.google.com with SMTP id f25so340610rvb.22
	for <qemu-devel@nongnu.org>; Sat, 03 May 2008 06:35:13 -0700 (PDT)
Message-ID: <cef699d70805030635x23a6c33ek7bf2a31789d9fc3d@mail.gmail.com>
Date: Sat, 3 May 2008 09:35:13 -0400
From: "Ben Taylor" <bentaylor.solx86@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] configure: silence test for brlapi
In-Reply-To: <20080503114822.GC8032@implementation>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <20080503083951.GA32346@tapir>
	<20080503093441.GA8032@implementation>
	<cef699d70805030442w3e655af9xab8a4245e3dfc0b2@mail.gmail.com>
	<20080503114822.GC8032@implementation>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sat, May 3, 2008 at 7:48 AM, Samuel Thibault
<samuel.thibault@eu.citrix.com> wrote:
> Ben Taylor, le Sat 03 May 2008 07:42:54 -0400, a =E9crit :
>
> > On Solaris, I found that the configure code tested the 32-bit bit versi=
on
>  > while on 64-bit, and then it failed linking qemu-img, because Sun didn=
't
>  > deliver a 64-bit version of libbrlapi.
>  >
>  > Adding ${ARCH_CFLAGS} to the test caused it to do the right thing.
>
>  Oh, you mean the patch below?
>
>  Samuel
>
>  Index: configure
>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>  --- configure   (r=E9vision 4294)
>  +++ configure   (copie de travail)
>  @@ -733,7 +733,7 @@
>   #include <brlapi.h>
>   int main( void ) { return brlapi__openConnection (NULL, NULL, NULL); }
>   EOF
>  -    if $cc -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> /tmp/qemu-$$-brlapi.=
log ; then
>  +    if $cc ${ARCH_CFLAGS} -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> /tmp/=
qemu-$$-brlapi.log ; then
>             brlapi=3Dyes
>      fi # brlapi compile test
>   fi # -z $brlapi

looks exactly like what I did.  (I know this sort of works around a Solaris=
 bug,
but it should compile to the right architecture regardless)

Thanks,

Ben