[Qemu-devel] [PATCH] configure: silence test for brlapi

[Qemu-devel] [PATCH] configure: silence test for brlapi

[Carlo Marcelo Arenas Belon]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

The following patch, sends the output for the test of brlapi to /dev/null
instead of the currently defined log file as it is left unused otherwise
in /tmp of the build server.

Carlo
---

[-- Attachment #2: qemu-configure-brlapi.patch --]
[-- Type: text/plain, Size: 478 bytes --]

Index: configure
===================================================================
--- configure	(revision 4304)
+++ configure	(working copy)
@@ -733,7 +733,7 @@
 #include <brlapi.h>
 int main( void ) { return brlapi__openConnection (NULL, NULL, NULL); }
 EOF
-    if $cc -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> /tmp/qemu-$$-brlapi.log ; then
+    if $cc -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> /dev/null ; then
 	    brlapi=yes
     fi # brlapi compile test
 fi # -z $brlapi

Re: [Qemu-devel] [PATCH] configure: silence test for brlapi

[Samuel Thibault]

Carlo Marcelo Arenas Belon, le Sat 03 May 2008 03:39:51 -0500, a écrit :
> The following patch, sends the output for the test of brlapi to /dev/null
> instead of the currently defined log file as it is left unused otherwise
> in /tmp of the build server.

Oh right, I had just copied the SDL code, which must not fail, thus the
log file.

Samuel

Re: [Qemu-devel] [PATCH] configure: silence test for brlapi

[Ben Taylor]

On Sat, May 3, 2008 at 5:34 AM, Samuel Thibault
<samuel.thibault@eu.citrix.com> wrote:
> Carlo Marcelo Arenas Belon, le Sat 03 May 2008 03:39:51 -0500, a écrit :
>
> > The following patch, sends the output for the test of brlapi to /dev/null
>  > instead of the currently defined log file as it is left unused otherwise
>  > in /tmp of the build server.
>
>  Oh right, I had just copied the SDL code, which must not fail, thus the
>  log file.

On Solaris, I found that the configure code tested the 32-bit bit version
while on 64-bit, and then it failed linking qemu-img, because Sun didn't
deliver a 64-bit version of libbrlapi.

Adding ${ARCH_CFLAGS} to the test caused it to do the right thing.

Ben

Re: [Qemu-devel] [PATCH] configure: silence test for brlapi

[Samuel Thibault]

Ben Taylor, le Sat 03 May 2008 07:42:54 -0400, a écrit :
> On Solaris, I found that the configure code tested the 32-bit bit version
> while on 64-bit, and then it failed linking qemu-img, because Sun didn't
> deliver a 64-bit version of libbrlapi.
> 
> Adding ${ARCH_CFLAGS} to the test caused it to do the right thing.

Oh, you mean the patch below?

Samuel

Index: configure
===================================================================
--- configure	(révision 4294)
+++ configure	(copie de travail)
@@ -733,7 +733,7 @@
 #include <brlapi.h>
 int main( void ) { return brlapi__openConnection (NULL, NULL, NULL); }
 EOF
-    if $cc -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> /tmp/qemu-$$-brlapi.log ; then
+    if $cc ${ARCH_CFLAGS} -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> /tmp/qemu-$$-brlapi.log ; then
 	    brlapi=yes
     fi # brlapi compile test
 fi # -z $brlapi

Re: [Qemu-devel] [PATCH] configure: silence test for brlapi

[Ben Taylor]

On Sat, May 3, 2008 at 7:48 AM, Samuel Thibault
<samuel.thibault@eu.citrix.com> wrote:
> Ben Taylor, le Sat 03 May 2008 07:42:54 -0400, a écrit :
>
> > On Solaris, I found that the configure code tested the 32-bit bit version
>  > while on 64-bit, and then it failed linking qemu-img, because Sun didn't
>  > deliver a 64-bit version of libbrlapi.
>  >
>  > Adding ${ARCH_CFLAGS} to the test caused it to do the right thing.
>
>  Oh, you mean the patch below?
>
>  Samuel
>
>  Index: configure
>  ===================================================================
>  --- configure   (révision 4294)
>  +++ configure   (copie de travail)
>  @@ -733,7 +733,7 @@
>   #include <brlapi.h>
>   int main( void ) { return brlapi__openConnection (NULL, NULL, NULL); }
>   EOF
>  -    if $cc -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> /tmp/qemu-$$-brlapi.log ; then
>  +    if $cc ${ARCH_CFLAGS} -o $TMPE ${OS_CFLAGS} $TMPC -lbrlapi 2> /tmp/qemu-$$-brlapi.log ; then
>             brlapi=yes
>      fi # brlapi compile test
>   fi # -z $brlapi

looks exactly like what I did.  (I know this sort of works around a Solaris bug,
but it should compile to the right architecture regardless)

Thanks,

Ben