From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KcIn9-0004XQ-MJ for qemu-devel@nongnu.org; Sun, 07 Sep 2008 07:50:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KcIn7-0004T8-Ci for qemu-devel@nongnu.org; Sun, 07 Sep 2008 07:50:54 -0400 Received: from [199.232.76.173] (port=54577 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KcIn7-0004So-58 for qemu-devel@nongnu.org; Sun, 07 Sep 2008 07:50:53 -0400 Received: from wa-out-1112.google.com ([209.85.146.178]:41739) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KcIn6-0007NQ-KD for qemu-devel@nongnu.org; Sun, 07 Sep 2008 07:50:52 -0400 Received: by wa-out-1112.google.com with SMTP id j5so980373wah.18 for ; Sun, 07 Sep 2008 04:50:51 -0700 (PDT) Message-ID: Date: Sun, 7 Sep 2008 07:50:51 -0400 From: "Ben Taylor" Subject: Re: [Qemu-devel] [PATCH, RFC] ld flag --warn-common In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sun, Sep 7, 2008 at 4:24 AM, Blue Swirl wrote: > Hi, > > These trivial patches enable linker flag --warn-common and fix the > warnings caused by enabling the flag. > > I think on some platforms (Solaris?) the linker used by gcc is not GNU > ld. If this is true, the patch would break compilation on those hosts > and logic in configure would need to be more complex. Please confirm. yes, Solaris does not use gnu ld, it uses it's own linker. Ben