From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Na7JS-0004Zn-SR
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 07:48:02 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Na7JO-0004YC-EN
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 07:48:02 -0500
Received: from [199.232.76.173] (port=44164 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Na7JO-0004Y7-4z
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 07:47:58 -0500
Received: from mail-fx0-f222.google.com ([209.85.220.222]:64155)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <bentaylor.solx86@gmail.com>) id 1Na7JN-0000SL-Pd
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 07:47:57 -0500
Received: by fxm22 with SMTP id 22so10320897fxm.2
	for <qemu-devel@nongnu.org>; Wed, 27 Jan 2010 04:47:55 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1264594205-14940-1-git-send-email-lool@dooz.org>
References: <f43fc5581001261116y7ecf38a2he3d250da2214e0ee@mail.gmail.com>
	<1264594205-14940-1-git-send-email-lool@dooz.org>
Date: Wed, 27 Jan 2010 07:47:55 -0500
Message-ID: <cef699d71001270447p385a9604m7297f03c9fed4e4b@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it
From: Ben Taylor <bentaylor.solx86@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Lo=EFc_Minier?= <lool@dooz.org>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org

On Wed, Jan 27, 2010 at 7:10 AM, Lo=EFc Minier <lool@dooz.org> wrote:
> Check whether sdl-config is available before calling it, otherwise
> ./configure triggers a warning:
> =A0 =A0./configure: 957: sdl-config: not found
>
> If neither the .pc file not sdl-config are present, disable SDL support.
>
> Signed-off-by: Lo=EFc Minier <lool@dooz.org>
> ---
> =A0configure | =A0 =A07 ++++++-
> =A01 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 1f6de41..27ab724 100755
> --- a/configure
> +++ b/configure
> @@ -997,9 +997,14 @@ fi
> =A0if $pkgconfig sdl --modversion >/dev/null 2>&1; then
> =A0 sdlconfig=3D"$pkgconfig sdl"
> =A0 _sdlversion=3D`$sdlconfig --modversion 2>/dev/null | sed 's/[^0-9]//g=
'`
> -else
> +elif which sdl-config >/dev/null 2>&1; then
> =A0 sdlconfig=3D'sdl-config'
> =A0 _sdlversion=3D`$sdlconfig --version | sed 's/[^0-9]//g'`
> +else
> + =A0if test "$sdl" =3D "yes" ; then
> + =A0 =A0feature_not_found "sdl"
> + =A0fi
> + =A0sdl=3Dno
> =A0fi
>
> =A0sdl_too_old=3Dno


Glad to see someone working on Solaris.  Wondering why you're using
the which command, when you just created a "has" function in the other
patch segments, and just replaced all the other instances of which.