From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available
Date: Sat, 4 May 2019 08:41:03 +0200 [thread overview]
Message-ID: <cf07eade-4377-0016-ac80-f7fbb5f05515@redhat.com> (raw)
In-Reply-To: <b6e70863-4ec9-0209-46b0-b74eb1453fcf@redhat.com>
On 03/05/2019 19.04, Philippe Mathieu-Daudé wrote:
> On 5/3/19 6:41 PM, Thomas Huth wrote:
>> On 03/05/2019 02.41, Eduardo Habkost wrote:
>>> From: Daniel P. Berrangé <berrange@redhat.com>
>>>
>>> Unless overridden via an env var or configure arg, QEMU will only look
>>> for the 'python' binary in $PATH. This is unhelpful on distros which
>>> are only shipping Python 3.x (eg Fedora) in their default install as,
>>> if they comply with PEP 394, the bare 'python' binary won't exist.
>>>
>>> This changes configure so that by default it will search for all three
>>> common python binaries, preferring to find Python 3.x versions.
>>>
>>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>>> Message-Id: <20190327170701.23798-1-berrange@redhat.com>
>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>> ---
>>> configure | 18 +++++++++++++++---
>>> 1 file changed, 15 insertions(+), 3 deletions(-)
>>
>> I haven't bisected it, but I think this patch here broke the gitlab-ci tests:
>>
>> https://gitlab.com/huth/qemu/-/jobs/206806257
>
> What's the easier way to notice that automatically?
Maybe Peter could tweak one of his acceptance test environments to use a
non-UTF-8 locale?
Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available
Date: Sat, 4 May 2019 08:41:03 +0200 [thread overview]
Message-ID: <cf07eade-4377-0016-ac80-f7fbb5f05515@redhat.com> (raw)
Message-ID: <20190504064103.lQ4V07LHUExC2lRzKboD1f-0kUkovI5ALbZ8Sb5GNJc@z> (raw)
In-Reply-To: <b6e70863-4ec9-0209-46b0-b74eb1453fcf@redhat.com>
On 03/05/2019 19.04, Philippe Mathieu-Daudé wrote:
> On 5/3/19 6:41 PM, Thomas Huth wrote:
>> On 03/05/2019 02.41, Eduardo Habkost wrote:
>>> From: Daniel P. Berrangé <berrange@redhat.com>
>>>
>>> Unless overridden via an env var or configure arg, QEMU will only look
>>> for the 'python' binary in $PATH. This is unhelpful on distros which
>>> are only shipping Python 3.x (eg Fedora) in their default install as,
>>> if they comply with PEP 394, the bare 'python' binary won't exist.
>>>
>>> This changes configure so that by default it will search for all three
>>> common python binaries, preferring to find Python 3.x versions.
>>>
>>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>>> Message-Id: <20190327170701.23798-1-berrange@redhat.com>
>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>> ---
>>> configure | 18 +++++++++++++++---
>>> 1 file changed, 15 insertions(+), 3 deletions(-)
>>
>> I haven't bisected it, but I think this patch here broke the gitlab-ci tests:
>>
>> https://gitlab.com/huth/qemu/-/jobs/206806257
>
> What's the easier way to notice that automatically?
Maybe Peter could tweak one of his acceptance test environments to use a
non-UTF-8 locale?
Thomas
next prev parent reply other threads:[~2019-05-04 6:41 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 0:41 [Qemu-devel] [PULL 00/19] Python queue, 2019-05-02 Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 01/19] tests/acceptance: show avocado test execution by default Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 02/19] tests/acceptance: improve docstring on pick_default_qemu_bin() Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 03/19] tests/acceptance: fix doc reference to avocado_qemu directory Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 04/19] tests/acceptance: introduce arch parameter and attribute Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 05/19] tests/acceptance: use "arch:" tag to filter target specific tests Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 06/19] tests/acceptance: look for target architecture in test tags first Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 07/19] tests/boot_linux_console: rename the x86_64 after the arch and machine Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 08/19] tests/boot_linux_console: update the x86_64 kernel Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 09/19] tests/boot_linux_console: add common kernel command line options Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 10/19] tests/boot_linux_console: increase timeout Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-08 10:28 ` Gerd Hoffmann
2019-05-08 14:39 ` Cleber Rosa
2019-05-09 4:40 ` Gerd Hoffmann
2019-05-09 18:12 ` Cleber Rosa
2019-05-10 6:06 ` Gerd Hoffmann
2019-05-03 0:41 ` [Qemu-devel] [PULL 11/19] tests/boot_linux_console: refactor the console watcher into utility method Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 12/19] scripts/qemu.py: support adding a console with the default serial device Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 13/19] tests/boot_linux_console: add a test for mips + malta Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 14/19] tests/boot_linux_console: add a test for mips64el " Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 15/19] tests/boot_linux_console: add a test for aarch64 + virt Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 16/19] tests/boot_linux_console: add a test for arm " Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 17/19] tests/boot_linux_console: add a test for s390x + s390-ccw-virtio Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 18/19] tests/boot_linux_console: add a test for alpha + clipper Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available Eduardo Habkost
2019-05-03 0:41 ` Eduardo Habkost
2019-05-03 16:41 ` Thomas Huth
2019-05-03 16:41 ` Thomas Huth
2019-05-03 16:54 ` Daniel P. Berrangé
2019-05-03 16:54 ` Daniel P. Berrangé
2019-05-03 16:56 ` Daniel P. Berrangé
2019-05-03 16:56 ` Daniel P. Berrangé
2019-05-03 17:04 ` Philippe Mathieu-Daudé
2019-05-03 17:04 ` Philippe Mathieu-Daudé
2019-05-04 6:41 ` Thomas Huth [this message]
2019-05-04 6:41 ` Thomas Huth
2019-05-03 21:00 ` Eduardo Habkost
2019-05-03 21:00 ` Eduardo Habkost
2019-05-03 21:34 ` Eduardo Habkost
2019-05-03 21:34 ` Eduardo Habkost
2019-05-04 7:17 ` Thomas Huth
2019-05-04 7:17 ` Thomas Huth
2019-05-03 15:02 ` [Qemu-devel] [PULL 00/19] Python queue, 2019-05-02 Peter Maydell
2019-05-03 15:02 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf07eade-4377-0016-ac80-f7fbb5f05515@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).