From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] block: Error out on image creation with conflicting size options
Date: Tue, 26 Nov 2019 09:54:40 -0600 [thread overview]
Message-ID: <cf113754-c582-03ae-9e53-ab0213c0ccf9@redhat.com> (raw)
In-Reply-To: <20191126154835.27915-1-kwolf@redhat.com>
On 11/26/19 9:48 AM, Kevin Wolf wrote:
> If both the create options (qemu-img create -o ...) and the size
> parameter were given, the size parameter was silently ignored. Instead,
> make specifying two sizes an error.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 10 ++++++++--
> tests/qemu-iotests/049 | 5 +++++
> tests/qemu-iotests/049.out | 5 +++++
> 3 files changed, 18 insertions(+), 2 deletions(-)
Longtime bug, so not essential for 4.2-rc3. But small enough that you
could sneak it in if you have other patches to queue and don't want to
wait for 5.0.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-11-26 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 15:48 [PATCH] block: Error out on image creation with conflicting size options Kevin Wolf
2019-11-26 15:54 ` Eric Blake [this message]
2019-11-26 15:56 ` Eric Blake
2019-11-26 16:26 ` Kevin Wolf
2019-11-26 16:39 ` Eric Blake
2019-11-26 19:58 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf113754-c582-03ae-9e53-ab0213c0ccf9@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).