Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

On 08.03.2017 19:28, Eric Blake wrote:
> On 03/08/2017 12:25 PM, Eric Blake wrote:
>> On 03/08/2017 12:18 PM, Max Reitz wrote:
>>> In order to use error_setg() and similar functions, we need to include
>>> qapi/error.h.
>>>
>>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>>> ---
>>>  block/archipelago.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>
>> Does this mean our automated buildbots aren't building archipelago by
>> default?
>>
> 
> Oh, I meant to add:
> 
> Should probably mention that it was commit da34e65 that introduced the
> problem (if I'm right?).  Does that mean we have not been compiling
> archipelago.c since Mar 2016?

At least here on my machine it does indeed compile before that commit
and fails afterwards. So, yes, maybe we actually have not. :-)

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]