From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FC3CC5B559 for ; Fri, 6 Jun 2025 08:07:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNS68-0000VJ-Qu; Fri, 06 Jun 2025 04:06:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNS64-0000Tu-Pz for qemu-devel@nongnu.org; Fri, 06 Jun 2025 04:06:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNS63-0005rG-7q for qemu-devel@nongnu.org; Fri, 06 Jun 2025 04:06:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749197197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=W/k3GfmdiWOW6nGw3logUEsxs0tADPWnI5BWXYdRa68=; b=UJbIss4rxugaOhiJrM1iGXVBM3mxma8IPjA0FVA96K7Qj1/xvgn1XHO2asI2EwPb5wfqhT RExJMBMHEdyRcE6+SrgnXWF3XdorHkwRg6SQ0sBf+rlkJrUx9cotwypXPIWiwoxUu+trAu oDQFwNi9MUEfVKBCfvY3z3fbtonY/2U= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-UTtQ0471OKmBpqpHNGK9-g-1; Fri, 06 Jun 2025 04:06:35 -0400 X-MC-Unique: UTtQ0471OKmBpqpHNGK9-g-1 X-Mimecast-MFC-AGG-ID: UTtQ0471OKmBpqpHNGK9-g_1749197194 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-451d3f03b74so10976375e9.3 for ; Fri, 06 Jun 2025 01:06:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749197194; x=1749801994; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W/k3GfmdiWOW6nGw3logUEsxs0tADPWnI5BWXYdRa68=; b=BgjujV5E+WWZPQ1JLzut8UbIMtXAfqtQbaiGDcQ8IpwGR+zt60Mq9Tiqq3PSOkWBhe DFXSaRdFWoe+BYuVs+EF42noEjecTeKPdt9rfnfflmJOnomA8ej+d8yuMw/Bu0YBtKbl wZJSdZm7GGOsezRCdlIFXru27zfLcNiV5wiXso2a5D1037/6iAbKnRkjH+SRveNzNqRG w/vE1u4M2onOcroxzXCP5IGTnFNB6grWcT8WfH60StVO3TosvUihXjXqwTrsXL0C4yCi Ohdchym5UdNZSkkFI3+mof3/NcJM1aRxFajxMVpS733BOPQMbMcRUPxnk3t31FiNLJ5g /8PQ== X-Forwarded-Encrypted: i=1; AJvYcCXColEecDCZ7ecj/ZgHGylFrs1NWwSe6X3JTg6LkE7D3g8pMsCsatMNcQzGR/sIJYKw7c8yS/XzKkaq@nongnu.org X-Gm-Message-State: AOJu0YxDo9gBIa58h8BLcbUO+925y6VvAnwvVyoeFZV+ecP/tno05wxY W9GBp/hV992LracRwqiB9zRR309vui2V8dzFV108xPhkku8dh7bXhjQ0U4EJJjX3SUl/HvG85Ck lpKtZXPdrGadh2c/gcedf5H/XrsU1YitOtUE/34usDWfC+odVW6bsSdr1 X-Gm-Gg: ASbGncufxT63ab8aUN8WKDfojc5mEGN8i7L/Qr+ITjog0hUgsqAZNVhsZdK6YY88InB YJJDQZQCxdMSMnoy54gD5PA4oIfsxjnXGYXdblxOwwStOKeRBxPeuN1erwGpw9h/oewFB3ukJWf SYCNy5b0cF1NXFfpZninfT8LZ6LKPlWHBiJgkfKkTQK0oyU9nzuYso6iyXAe4qgUpGMftbMN/kx n1Zb2XfKHdBw7AQktYFyQgD+LhGferYjDvwh3wSE4IfA+cxPI7f0JL8flkCEsBdxgBF5z9g39hR vs/yamqRUHl7H3/1koNr9v28X4s4bfIsbrXNEQGw4T5fn7TsMuVoRq45gXUO X-Received: by 2002:a05:600c:3b10:b0:450:cd25:e69c with SMTP id 5b1f17b1804b1-452013d1f6bmr22918665e9.21.1749197194351; Fri, 06 Jun 2025 01:06:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHMhg8/IJM8bG0a0Jf1BqBv0fe3PxzzgclArsPmI9LAurpkXQwTSFnkudM5knDDulwkEWzSOQ== X-Received: by 2002:a05:600c:3b10:b0:450:cd25:e69c with SMTP id 5b1f17b1804b1-452013d1f6bmr22918365e9.21.1749197193962; Fri, 06 Jun 2025 01:06:33 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:576b:abc6:6396:ed4a? ([2a01:e0a:280:24f0:576b:abc6:6396:ed4a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452137290b9sm15529725e9.34.2025.06.06.01.06.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 01:06:32 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 10:06:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ramfb: Add property to control if load the romfile To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Shaoqin Huang Cc: qemu-arm@nongnu.org, Eric Auger , Peter Maydell , Gerd Hoffmann , Alex Williamson , qemu-devel@nongnu.org References: <20250606070234.2063451-1-shahuang@redhat.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.132, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/6/25 09:52, Daniel P. Berrangé wrote: > On Fri, Jun 06, 2025 at 03:02:34AM -0400, Shaoqin Huang wrote: >> Now the ramfb will load the vgabios-ramfb.bin unconditionally, but only >> the x86 need the vgabios-ramfb.bin, this can cause that when use the >> release package on arm64 it can't find the vgabios-ramfb.bin. >> >> Because only seabios will use the vgabios-ramfb.bin, load the rom logic >> is x86-specific. For other !x86 platforms, the edk2 ships an EFI driver >> for ramfb, so they don't need to load the romfile. >> >> So add a new property use_legacy_x86_rom in both ramfb and vfio_pci >> device, because the vfio display also use the ramfb_setup() to load >> the vgabios-ramfb.bin file. >> >> After have this property, the machine type can set the compatibility to >> not load the vgabios-ramfb.bin if the arch doesn't need it. > > Can you make this a series, with an additional patch that updates the > current in-dev machine types to use this new property, so we're clear > about the proposed usage. yes. And please change the vfio-pci property name to use underscores. C.