From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: "Alexander von Gluck IV" <kallisti5@unixzen.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
罗勇刚 <luoyonggang@gmail.com>, "David CARLIER" <devnexen@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 3/4] configure: Add a proper check for sys/ioccom.h and use it in tpm_ioctl.h
Date: Mon, 16 Nov 2020 12:51:14 +0100 [thread overview]
Message-ID: <cf354b64-cd22-e6a1-31e7-baf62fcbc0ed@amsat.org> (raw)
In-Reply-To: <20201115152317.42752-1-thuth@redhat.com>
On 11/15/20 4:23 PM, Thomas Huth wrote:
> On Solaris and Haiku, the _IO() macros are defined in <sys/ioccom.h>.
> Add a proper check for this header to our build system, and make sure
> to include the header in tpm_ioctl.h to fix a build failure on Solaris
> and Haiku.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: Check in meson.build instead of using the configure script
>
> backends/tpm/tpm_ioctl.h | 4 ++++
> meson.build | 2 ++
> nbd/nbd-internal.h | 2 +-
> 3 files changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-11-16 11:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 16:51 [PATCH for-5.2? 0/4] Fix build failures on Haiku Thomas Huth
2020-11-14 16:51 ` [PATCH 1/4] configure: Fix the _BSD_SOURCE define for the Haiku build Thomas Huth
2020-11-14 23:44 ` Stefan Berger
2020-11-14 16:51 ` [PATCH 2/4] configure: Do not build pc-bios/optionrom on Haiku Thomas Huth
2020-11-14 23:44 ` Stefan Berger
2020-11-16 11:51 ` Philippe Mathieu-Daudé
2020-11-14 16:51 ` [PATCH 3/4] configure: Add a proper check for sys/ioccom.h and use it in tpm_ioctl.h Thomas Huth
2020-11-14 16:56 ` 罗勇刚(Yonggang Luo)
2020-11-15 14:00 ` Thomas Huth
2020-11-15 14:34 ` Paolo Bonzini
2020-11-15 15:18 ` Thomas Huth
2020-11-14 23:43 ` Stefan Berger
2020-11-15 15:23 ` [PATCH v2 " Thomas Huth
2020-11-16 11:51 ` Philippe Mathieu-Daudé [this message]
2020-11-14 16:51 ` [PATCH 4/4] tests/vm: Add Haiku test based on their vagrant images Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf354b64-cd22-e6a1-31e7-baf62fcbc0ed@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=devnexen@gmail.com \
--cc=kallisti5@unixzen.com \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).