From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:47581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJf9Q-0005ni-BD for qemu-devel@nongnu.org; Thu, 25 Apr 2019 10:15:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJf9P-0005Og-C4 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 10:15:00 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:45961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJf9P-0005O3-4y for qemu-devel@nongnu.org; Thu, 25 Apr 2019 10:14:59 -0400 Received: by mail-wr1-f68.google.com with SMTP id s15so30523774wra.12 for ; Thu, 25 Apr 2019 07:14:59 -0700 (PDT) References: <20190418180057.3593-1-thuth@redhat.com> <20190418180057.3593-7-thuth@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Thu, 25 Apr 2019 16:14:54 +0200 MIME-Version: 1.0 In-Reply-To: <20190418180057.3593-7-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 06/29] hw/arm: Express dependencies of integratorcp with Kconfig List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , yang.zhong@intel.com, Peter Maydell , qemu-devel@nongnu.org, pbonzini@redhat.com Cc: "Michael S. Tsirkin" , Gerd Hoffmann , "Edgar E . Iglesias" , Jean-Christophe Dubois , Rob Herring , qemu-block@nongnu.org, Andrey Smirnov , Joel Stanley , Antony Pavlov , Alistair Francis , Beniamino Galvani , qemu-arm@nongnu.org, Peter Chubb , Cedric Le Goater , John Snow , Andrew Jeffery , Philippe Mathieu-Daude , Subbaraya Sundeep , Igor Mitsyanko , Jan Kiszka Hi Thomas, On 4/18/19 8:00 PM, Thomas Huth wrote: > This patch is slightly based on earlier work by Ákos Kovács (i.e. > his "hw/arm/Kconfig: Add ARM Kconfig" patch). > > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 8 +------- > hw/arm/Kconfig | 8 ++++++++ > hw/display/Kconfig | 1 + > 3 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak > index 50a4be3cad..6195b75f48 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -9,6 +9,7 @@ CONFIG_PCI_TESTDEV=y > > CONFIG_EXYNOS4=y > CONFIG_HIGHBANK=y > +CONFIG_INTEGRATOR=y > > CONFIG_VGA=y > CONFIG_NAND=y > @@ -33,7 +34,6 @@ CONFIG_ADS7846=y > CONFIG_MAX111X=y > CONFIG_SSI_SD=y > CONFIG_SSI_M25P80=y > -CONFIG_SMC91C111=y > CONFIG_ALLWINNER_EMAC=y > CONFIG_IMX_FEC=y > CONFIG_FTGMAC100=y > @@ -50,10 +50,7 @@ CONFIG_ARM11MPCORE=y > CONFIG_NETDUINO2=y > > CONFIG_PL041=y > -CONFIG_PL050=y You remove this device but it is used by the realview/versatile/vexpress (you add it to these machines later in patch 11). > CONFIG_PL080=y > -CONFIG_PL110=y Ditto, > -CONFIG_PL181=y Ditto. > CONFIG_PL190=y > CONFIG_PL330=y > CONFIG_CADENCE=y > @@ -113,9 +110,6 @@ CONFIG_VERSATILE_I2C=y > CONFIG_PCI_EXPRESS=y > CONFIG_PCI_EXPRESS_GENERIC_BRIDGE=y > > -CONFIG_INTEGRATOR=y > -CONFIG_INTEGRATOR_DEBUG=y > - > CONFIG_ALLWINNER_A10_PIT=y > CONFIG_ALLWINNER_A10_PIC=y > CONFIG_ALLWINNER_A10=y > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index 0ba377ac18..ad3b1f9b40 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -32,6 +32,14 @@ config HIGHBANK > > config INTEGRATOR > bool > + select ARM_TIMER > + select INTEGRATOR_DEBUG > + select PL011 # UART > + select PL031 # RTC > + select PL050 # keyboard/mouse > + select PL110 # pl111 LCD controller > + select PL181 # display > + select SMC91C111 > > config MAINSTONE > bool > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > index 72be57a403..a11815c9af 100644 > --- a/hw/display/Kconfig > +++ b/hw/display/Kconfig > @@ -21,6 +21,7 @@ config JAZZ_LED > > config PL110 > bool > + select FRAMEBUFFER > > config SII9022 > bool > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D57B3C43219 for ; Thu, 25 Apr 2019 14:15:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB6A4206BF for ; Thu, 25 Apr 2019 14:15:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB6A4206BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:58337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJfAM-0006J6-Sf for qemu-devel@archiver.kernel.org; Thu, 25 Apr 2019 10:15:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJf9Q-0005ni-BD for qemu-devel@nongnu.org; Thu, 25 Apr 2019 10:15:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJf9P-0005Og-C4 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 10:15:00 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:45961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJf9P-0005O3-4y for qemu-devel@nongnu.org; Thu, 25 Apr 2019 10:14:59 -0400 Received: by mail-wr1-f68.google.com with SMTP id s15so30523774wra.12 for ; Thu, 25 Apr 2019 07:14:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rUKdnC/3cE2qM1D8mJmUw2ECG6CWGutrarsfOlrkBuw=; b=bCh0Mnoy37ccKI0S9wthreCYfNdSOztvP/8nyPePhPjdLA1aGVAfZ60wh4N7ejpRBy FfQ6CMqjPP3+Mdu79CeIU1LYAuiDREvBYYuV4VAjVPs2T7R85fUF8rrYlzZh5La0vdA+ Jou1TlfhT4eira6owtKqxoefmxMs4viTTx+otKnOk8x9cBIMfHqwHVIgb/87Sa7cZ3PH 4wihBUveh2Y84f/gqb77SfoQsDMz4cpaqzLdVOp0zIisGBYGG/l6NaB6UowQXykIXFfK tIru7KcpZ7oZwzU/dTX27UV1qgltW2/0nzDZvP+xvNXGjXj5reVx/5Vd1BYC+DXMunTm w3BQ== X-Gm-Message-State: APjAAAWI8lEE9bYK8YVbMEFqD3VOpcbfVRahTRmAOR3NYelMei6TsvRJ BYwR+mb3zl590YEAfaof6kg1yw== X-Google-Smtp-Source: APXvYqyiNTcJ6iIqcb4vY6m3YF3beA/pkRm35hibwC8tz48dK4HmpZT23NoZ4j8YB64nyCC7pYkJsQ== X-Received: by 2002:adf:b64e:: with SMTP id i14mr3434590wre.72.1556201698230; Thu, 25 Apr 2019 07:14:58 -0700 (PDT) Received: from [192.168.1.25] (abayonne-654-1-209-122.w109-222.abo.wanadoo.fr. [109.222.216.122]) by smtp.gmail.com with ESMTPSA id t9sm26534187wra.71.2019.04.25.07.14.54 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2019 07:14:57 -0700 (PDT) To: Thomas Huth , yang.zhong@intel.com, Peter Maydell , qemu-devel@nongnu.org, pbonzini@redhat.com References: <20190418180057.3593-1-thuth@redhat.com> <20190418180057.3593-7-thuth@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Thu, 25 Apr 2019 16:14:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418180057.3593-7-thuth@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.68 Subject: Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 06/29] hw/arm: Express dependencies of integratorcp with Kconfig X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Jan Kiszka , Igor Mitsyanko , qemu-block@nongnu.org, "Michael S. Tsirkin" , Andrey Smirnov , Alistair Francis , Philippe Mathieu-Daude , Jean-Christophe Dubois , Beniamino Galvani , Andrew Jeffery , Cedric Le Goater , qemu-arm@nongnu.org, Peter Chubb , Gerd Hoffmann , Antony Pavlov , "Edgar E . Iglesias" , Subbaraya Sundeep , John Snow , Joel Stanley Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190425141454.qAjZyiDMmJey1m3DqeJLsvvR1qsBEhJIkWYgsYQxnDY@z> Hi Thomas, On 4/18/19 8:00 PM, Thomas Huth wrote: > This patch is slightly based on earlier work by Ákos Kovács (i.e. > his "hw/arm/Kconfig: Add ARM Kconfig" patch). > > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 8 +------- > hw/arm/Kconfig | 8 ++++++++ > hw/display/Kconfig | 1 + > 3 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak > index 50a4be3cad..6195b75f48 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -9,6 +9,7 @@ CONFIG_PCI_TESTDEV=y > > CONFIG_EXYNOS4=y > CONFIG_HIGHBANK=y > +CONFIG_INTEGRATOR=y > > CONFIG_VGA=y > CONFIG_NAND=y > @@ -33,7 +34,6 @@ CONFIG_ADS7846=y > CONFIG_MAX111X=y > CONFIG_SSI_SD=y > CONFIG_SSI_M25P80=y > -CONFIG_SMC91C111=y > CONFIG_ALLWINNER_EMAC=y > CONFIG_IMX_FEC=y > CONFIG_FTGMAC100=y > @@ -50,10 +50,7 @@ CONFIG_ARM11MPCORE=y > CONFIG_NETDUINO2=y > > CONFIG_PL041=y > -CONFIG_PL050=y You remove this device but it is used by the realview/versatile/vexpress (you add it to these machines later in patch 11). > CONFIG_PL080=y > -CONFIG_PL110=y Ditto, > -CONFIG_PL181=y Ditto. > CONFIG_PL190=y > CONFIG_PL330=y > CONFIG_CADENCE=y > @@ -113,9 +110,6 @@ CONFIG_VERSATILE_I2C=y > CONFIG_PCI_EXPRESS=y > CONFIG_PCI_EXPRESS_GENERIC_BRIDGE=y > > -CONFIG_INTEGRATOR=y > -CONFIG_INTEGRATOR_DEBUG=y > - > CONFIG_ALLWINNER_A10_PIT=y > CONFIG_ALLWINNER_A10_PIC=y > CONFIG_ALLWINNER_A10=y > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index 0ba377ac18..ad3b1f9b40 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -32,6 +32,14 @@ config HIGHBANK > > config INTEGRATOR > bool > + select ARM_TIMER > + select INTEGRATOR_DEBUG > + select PL011 # UART > + select PL031 # RTC > + select PL050 # keyboard/mouse > + select PL110 # pl111 LCD controller > + select PL181 # display > + select SMC91C111 > > config MAINSTONE > bool > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > index 72be57a403..a11815c9af 100644 > --- a/hw/display/Kconfig > +++ b/hw/display/Kconfig > @@ -21,6 +21,7 @@ config JAZZ_LED > > config PL110 > bool > + select FRAMEBUFFER > > config SII9022 > bool >