From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A790C636D4 for ; Fri, 17 Feb 2023 08:27:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSw4y-0007Eh-Qi; Fri, 17 Feb 2023 03:26:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSw4x-0007EB-4n for qemu-devel@nongnu.org; Fri, 17 Feb 2023 03:26:51 -0500 Received: from smtpout3.mo529.mail-out.ovh.net ([46.105.54.81]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSw4v-0005lD-3L for qemu-devel@nongnu.org; Fri, 17 Feb 2023 03:26:50 -0500 Received: from mxplan5.mail.ovh.net (unknown [10.109.143.123]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 9CD3A207B3; Fri, 17 Feb 2023 08:26:46 +0000 (UTC) Received: from kaod.org (37.59.142.103) by DAG4EX2.mxp5.local (172.16.2.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 17 Feb 2023 09:26:45 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-103G0055da8626f-0d22-44fc-9463-3169362b8339, D8AD3BA2C27EEBE7B4560DA8411A9B1E3CFED360) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: Date: Fri, 17 Feb 2023 09:26:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 0/8] aspeed: I2C fixes, -drive removal (first step) Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , , , Markus Armbruster CC: , Joel Stanley , Andrew Jeffery , Peter Maydell References: <20230214171830.681594-1-clg@kaod.org> <01ff80e9-c564-5566-5405-b2ca26dfbf09@linaro.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <01ff80e9-c564-5566-5405-b2ca26dfbf09@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.103] X-ClientProxiedBy: DAG1EX1.mxp5.local (172.16.2.1) To DAG4EX2.mxp5.local (172.16.2.32) X-Ovh-Tracer-GUID: 4217542f-066d-4169-a46f-66d92e029410 X-Ovh-Tracer-Id: 4199043706563431276 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrudeikedguddukecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitgcunfgvucfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepffdufeeliedujeeffffhjeffiefghffhhfdvkeeijeehledvueffhfejtdehgeegnecukfhppeduvdejrddtrddtrddupdefjedrheelrddugedvrddutdefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeotghlgheskhgrohgurdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehphhhilhhmugeslhhinhgrrhhordhorhhgpdhqvghmuhdqrghrmhesnhhonhhgnhhurdhorhhgpdhqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhgpdgrrhhmsghruhesrhgvughhrghtrdgtohhmpdhqvghmuhdqsghlohgtkhesnhhonhhgnhhurdhorhhgpdhjohgvlhesjhhmshdrihgurdgruhdprghnughrvgifsegrjhdrihgurdgruhdpphgvthgvrhdrmhgrhiguvghllheslhhinhgrrhhordhorhhgpdfovfetjfhoshhtpehmohehvdelpdhmohguvgepshhmthhpoh huth Received-SPF: pass client-ip=46.105.54.81; envelope-from=clg@kaod.org; helo=smtpout3.mo529.mail-out.ovh.net X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.351, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/15/23 11:45, Philippe Mathieu-Daudé wrote: > On 14/2/23 18:18, Cédric Le Goater wrote: >> Hello, >> >> This series starts with a first set of patches fixing I2C slave mode >> in the Aspeed I2C controller, a test device and its associated test in >> avocado. >> >> Follow some cleanups which allow the use of block devices instead of >> drives. So that, instead of specifying : >> >>    -drive file=./flash-ast2600-evb,format=raw,if=mtd >>    -drive file=./ast2600-evb.pnor,format=raw,if=mtd >>    ... >> >> and guessing from the order which bus the device is attached to, we >> can use : >> >>    -blockdev node-name=fmc0,driver=file,filename=./bmc.img >>    -device mx66u51235f,bus=ssi.0,drive=fmc0 >>    -blockdev node-name=fmc1,driver=file,filename=./bmc-alt.img >>    -device mx66u51235f,bus=ssi.0,drive=fmc1 >>    -blockdev node-name=pnor,driver=file,filename=./pnor >>    -device mx66l1g45g,bus=ssi.1,drive=pnor >>    ... >> >> It is not perfect, the CS index still depends on the order > > Quick thoughts here: > > TYPE_SSI_PERIPHERAL devices have one input SSI_GPIO_CS. > > TYPE_SSI_BUS could have a "cs-num" property (how many > CS line associated with this bus) and create an array of > #cs-num output SSI_GPIO_CS. > > TYPE_SSI_PERIPHERAL could have a "cs" (index) property; > if set, upon ssi_peripheral_realize() when the device is > plugged on the bus, the GPIO line is wired. yes. I would like to check first the impact on migration compatibility. Thanks, C. > So we could set the 'cs=' property from CLI: > >   -blockdev node-name=fmc0,driver=file,filename=./bmc.img >   -device mx66u51235f,bus=ssi.0,cs=1,drive=fmc0 >   -blockdev node-name=fmc1,driver=file,filename=./bmc-alt.img >   -device mx66u51235f,bus=ssi.0,cs=0,drive=fmc1 > >> but it is >> now possible to run a machine without -drive ...,if=mtd. >> >> This lacks the final patch enabling the '-nodefaults' option by not >> creating the default devices if specified on the command line. It >> needs some more evaluation of the possible undesired effects. >> Thanks, >> >> C. >