From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EAD8C43603 for ; Wed, 18 Dec 2019 03:46:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D7902072B for ; Wed, 18 Dec 2019 03:46:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X4GIK6Ix" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D7902072B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihQIV-0001vY-3K for qemu-devel@archiver.kernel.org; Tue, 17 Dec 2019 22:46:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45294) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihQGw-00013E-4X for qemu-devel@nongnu.org; Tue, 17 Dec 2019 22:45:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihQGu-00036B-Nq for qemu-devel@nongnu.org; Tue, 17 Dec 2019 22:45:13 -0500 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]:40059) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihQGu-00033J-Gs for qemu-devel@nongnu.org; Tue, 17 Dec 2019 22:45:12 -0500 Received: by mail-pj1-x1041.google.com with SMTP id n67so216341pjb.5 for ; Tue, 17 Dec 2019 19:45:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4BY76WHYZYu3SM+DW6jPxH+7o+ToqfkQOtBe0hdVU54=; b=X4GIK6Ix6/YqvozJQM1qury/NT4LgeZZZrQoyQ7HdEj3FH2oCw45TZemnPqBBjA5o6 8tkO1gAtzx8POal3ZgQo9UI+2MaiZW2ildCnCuvoQKrWrjE0e8hceE04qKI4wkn177Ij rfHX9SaAWzkc4EdOOeu0UAEme/EuPVKlZuD2G0aSQBgcsvKxhf8DSogA/nDykRtlCU4p f9LR5u6ygc0jAnqad4CdOgIc8APfM5UTUW591iLBHYJ5JiMSg+Sy1jiCroZDIB+c1Umh I8sUsMX91ZD88jInLWr0mJUrzeYr923m+BNRpvwS7okeg2I+lqC1J/GCyWYKK63hVCoe BhhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4BY76WHYZYu3SM+DW6jPxH+7o+ToqfkQOtBe0hdVU54=; b=lw0N9nMb8wTZThrSmA1YSJGg1GElbzwB8Koi5MZZfL7BLdBjlwzhhjXcamDlIdO0BX yiJH9rU/FbsgAFsQ6Jn9y2e32ADFpUqC/S3jdTsxsJSHvr4c1mItqHUZ4GSb1ZI2DDDF y6QH3mVqgEpMprkHPSGklwv6/S7XAJFScCD4qJKGZrXvg7DiZQReOhDgYw4aqy64tpb0 83Viq0TS0enUwJ5/LwLkXKRZaUeXgcf3ugyQHBXIXv0LcBzbpdW1xomXxX3Uqv3xplY8 GE0AS6Qpv3jUdVwNWdWeUcd20Oo8BWp8tbDSh526XFqeP5E9Xpic/nqRBFkZn6eF47Sg sN7w== X-Gm-Message-State: APjAAAVJD+w5/YnHmenU85fjgatGiMRBYYqPJ8l3sxFjYXgKGyE67trc IiKOATnUUv5gbxAh8Z1/amnJFw== X-Google-Smtp-Source: APXvYqwXTH0BuwOkiBVFuU95mpMLmFML2h5VkQ+J5XWk0mi0oD+fAqbrj9d9N+6Fu50RTgcYn5JKFg== X-Received: by 2002:a17:90a:e98a:: with SMTP id v10mr112682pjy.67.1576640711224; Tue, 17 Dec 2019 19:45:11 -0800 (PST) Received: from ?IPv6:2605:e000:c74f:dc00:6838:d2b2:17e2:8445? ([2605:e000:c74f:dc00:6838:d2b2:17e2:8445]) by smtp.gmail.com with ESMTPSA id h3sm648871pfr.15.2019.12.17.19.45.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2019 19:45:10 -0800 (PST) Subject: Re: [PATCH 1/6] audio/audio: Add missing fall through comment To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20191217173425.5082-1-philmd@redhat.com> <20191217173425.5082-2-philmd@redhat.com> From: Richard Henderson Message-ID: Date: Tue, 17 Dec 2019 17:45:07 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191217173425.5082-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::1041 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Gerd Hoffmann , =?UTF-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/17/19 7:34 AM, Philippe Mathieu-Daudé wrote: > GCC9 is confused by this comment when building with > CFLAG -Wimplicit-fallthrough=2: > > audio/audio.c: In function ‘audio_pcm_init_info’: > audio/audio.c:306:14: error: this statement may fall through [-Werror=implicit-fallthrough=] > 306 | sign = 1; > | ~~~~~^~~ > audio/audio.c:307:5: note: here > 307 | case AUDIO_FORMAT_U8: > | ^~~~ > cc1: all warnings being treated as errors > > Add the missing fall through comment, similarly to e46349414. ... > diff --git a/audio/audio.c b/audio/audio.c > index 56fae55047..57daf3f620 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -304,6 +304,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info, struct audsettings *as) > switch (as->fmt) { > case AUDIO_FORMAT_S8: > sign = 1; > + /* fall through */ > case AUDIO_FORMAT_U8: > mul = 1; > break; Reviewed-by: Richard Henderson r~