qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/5] iotests: reduce PBKDF iterations when testing LUKS
Date: Tue, 3 Jan 2017 13:07:43 -0600	[thread overview]
Message-ID: <cf532f94-88b9-5b07-f0bc-9452be411e39@redhat.com> (raw)
In-Reply-To: <20170103170459.27662-4-berrange@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

On 01/03/2017 11:04 AM, Daniel P. Berrange wrote:
> By default the PBKDF algorithm used with LUKS is tuned
> based on the number of iterations to produce 1 second
> of running time. This makes running the I/O test with
> the LUKS format orders of magnitude slower than with
> qcow2/raw formats.
> 
> When creating LUKS images, set the iteration time to
> a 10ms to reduce the time overhead for LUKS, since
> security does not matter in I/O tests.
> 
> Previsouly a full 'check -luks' would take
> 
>   $ time ./check -luks
>   Passed all 22 tests
> 
>   real  23m9.988s
>   user  21m46.223s
>   sys   0m22.841s
> 
> Now it takes
> 
>   $ time ./check -luks
>   Passed all 22 tests
> 
>   real  4m39.235s
>   user  3m29.590s
>   sys   0m24.234s
> 
> Still slow compared to qcow2/raw, but much improved
> none the less.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2017-01-03 19:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03 17:04 [Qemu-devel] [PATCH v2 0/5] Improve I/O tests coverage of LUKS Daniel P. Berrange
2017-01-03 17:04 ` [Qemu-devel] [PATCH v2 1/5] iotests: skip 159 & 170 with luks format Daniel P. Berrange
2017-01-03 17:10   ` Eric Blake
2017-01-03 17:04 ` [Qemu-devel] [PATCH v2 2/5] iotests: fix remainining tests to work with LUKS Daniel P. Berrange
2017-01-03 19:06   ` Eric Blake
2017-01-03 17:04 ` [Qemu-devel] [PATCH v2 3/5] iotests: reduce PBKDF iterations when testing LUKS Daniel P. Berrange
2017-01-03 19:07   ` Eric Blake [this message]
2017-01-03 19:08   ` Eric Blake
2017-01-03 17:04 ` [Qemu-devel] [PATCH v2 4/5] iotests: add more LUKS hash combination tests Daniel P. Berrange
2017-01-03 19:08   ` Eric Blake
2017-01-03 17:04 ` [Qemu-devel] [PATCH v2 5/5] iotests: chown LUKS device before qemu-io launches Daniel P. Berrange
2017-01-03 19:20   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf532f94-88b9-5b07-f0bc-9452be411e39@redhat.com \
    --to=eblake@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).