From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: "Titus Rwantare" <titusr@google.com>,
"Corey Minyard" <minyard@acm.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: wuhaotsh@google.com, venture@google.com, qemu-arm@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [PATCH v4 3/9] hw/i2c: pmbus: add PEC unsupported warning
Date: Mon, 7 Mar 2022 21:19:15 +0100 [thread overview]
Message-ID: <cf546a48-6dd4-bbfc-0293-94f84def9c45@gmail.com> (raw)
In-Reply-To: <20220307200605.4001451-4-titusr@google.com>
On 7/3/22 21:05, Titus Rwantare wrote:
> Signed-off-by: Titus Rwantare <titusr@google.com>
> ---
> hw/i2c/pmbus_device.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
> index c7ec8e5499..ff644c1d4a 100644
> --- a/hw/i2c/pmbus_device.c
> +++ b/hw/i2c/pmbus_device.c
> @@ -307,6 +307,11 @@ static uint8_t pmbus_receive_byte(SMBusDevice *smd)
>
> case PMBUS_CAPABILITY:
> pmbus_send8(pmdev, pmdev->capability);
> + if (pmdev->capability & BIT(7)) {
> + qemu_log_mask(LOG_UNIMP,
> + "%s: PEC is enabled but not yet supported.\n",
> + __func__);
> + }
> break;
>
> case PMBUS_VOUT_MODE: /* R/W byte */
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2022-03-07 20:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 20:05 [PATCH v4 0/9] Fixups for PMBus and new sensors Titus Rwantare
2022-03-07 20:05 ` [PATCH v4 1/9] hw/i2c: pmbus: add registers Titus Rwantare
2022-03-07 20:05 ` [PATCH v4 2/9] hw/i2c: pmbus: fix error returns and guard against out of range accesses Titus Rwantare
2022-03-07 20:05 ` [PATCH v4 3/9] hw/i2c: pmbus: add PEC unsupported warning Titus Rwantare
2022-03-07 20:19 ` Philippe Mathieu-Daudé [this message]
2022-03-07 20:06 ` [PATCH v4 4/9] hw/i2c: pmbus: refactor uint handling Titus Rwantare
2022-03-07 20:06 ` [PATCH v4 5/9] hw/i2c: pmbus: update MAINTAINERS Titus Rwantare
2022-03-07 20:06 ` [PATCH v4 6/9] hw/i2c: Added linear mode translation for pmbus devices Titus Rwantare
2022-03-07 20:06 ` [PATCH v4 7/9] hw/sensor: add Intersil ISL69260 device model Titus Rwantare
2022-03-07 20:06 ` [PATCH v4 8/9] hw/sensor: add Renesas raa229004 PMBus device Titus Rwantare
2022-03-07 20:06 ` [PATCH v4 9/9] hw/sensor: add Renesas raa228000 device Titus Rwantare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf546a48-6dd4-bbfc-0293-94f84def9c45@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=f4bug@amsat.org \
--cc=minyard@acm.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=titusr@google.com \
--cc=venture@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).