From: Eric Blake <eblake@redhat.com>
To: Sahid Orentino Ferdjaoui <sferdjao@redhat.com>,
weiqi <weiqi4@huawei.com>
Cc: arei.gonglei@huawei.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] vhost: simple clean up
Date: Fri, 7 Apr 2017 08:51:10 -0500 [thread overview]
Message-ID: <cf5ca19e-7de9-c13f-fa7f-b2f3e0d24fbc@redhat.com> (raw)
In-Reply-To: <20170407083849.GA26482@redhat>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On 04/07/2017 03:38 AM, Sahid Orentino Ferdjaoui wrote:
> On Fri, Apr 07, 2017 at 02:58:46PM +0800, weiqi wrote:
>> From: Wei Qi <weiqi4@huawei.com>
>>
>> It is unnecessary to assign 'hdev->nvqs' to 'i', because 'hdev->nvqs' unused after assignment, so remove it.
>
> nit: The line should not be longer than 76 characters [0].
>
> [0] http://wiki.qemu-project.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message
Also, make sure you have proper threading. Although you sent a 0/3
cover letter (with Message-ID:
<1491548305-75464-1-git-send-email-weiqi4@huawei.com>), this 1/3 message
is lacking both References: and In-Reply-To: headers, and therefore
appears as its own top level thread.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-04-07 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 6:58 [Qemu-devel] [PATCH 1/3] vhost: simple clean up weiqi
2017-04-07 8:38 ` Sahid Orentino Ferdjaoui
2017-04-07 13:51 ` Eric Blake [this message]
2017-04-07 14:47 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf5ca19e-7de9-c13f-fa7f-b2f3e0d24fbc@redhat.com \
--to=eblake@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sferdjao@redhat.com \
--cc=weiqi4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).