[Qemu-devel] [PATCH 1/3] vhost: simple clean up

[Qemu-devel] [PATCH 1/3] vhost: simple clean up

[weiqi]

From: Wei Qi <weiqi4@huawei.com>

It is unnecessary to assign 'hdev->nvqs' to 'i', because 'hdev->nvqs' unused after assignment, so remove it.

Signed-off-by: Wei Qi <weiqi4@huawei.com>
---
 hw/virtio/vhost.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 613494d..5c57983 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -1557,7 +1557,6 @@ fail_vq:
                              hdev->vqs + i,
                              hdev->vq_index + i);
     }
-    i = hdev->nvqs;
 
 fail_mem:
 fail_features:
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH 1/3] vhost: simple clean up

[Sahid Orentino Ferdjaoui]

On Fri, Apr 07, 2017 at 02:58:46PM +0800, weiqi wrote:
> From: Wei Qi <weiqi4@huawei.com>
> 
> It is unnecessary to assign 'hdev->nvqs' to 'i', because 'hdev->nvqs' unused after assignment, so remove it.

nit: The line should not be longer than 76 characters [0].

[0] http://wiki.qemu-project.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message

> 
> Signed-off-by: Wei Qi <weiqi4@huawei.com>
> ---
>  hw/virtio/vhost.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-By: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>

> 
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 613494d..5c57983 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -1557,7 +1557,6 @@ fail_vq:
>                               hdev->vqs + i,
>                               hdev->vq_index + i);
>      }
> -    i = hdev->nvqs;
>  
>  fail_mem:
>  fail_features:
> -- 
> 1.8.3.1
> 
> 

Re: [Qemu-devel] [PATCH 1/3] vhost: simple clean up

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

On 04/07/2017 03:38 AM, Sahid Orentino Ferdjaoui wrote:
> On Fri, Apr 07, 2017 at 02:58:46PM +0800, weiqi wrote:
>> From: Wei Qi <weiqi4@huawei.com>
>>
>> It is unnecessary to assign 'hdev->nvqs' to 'i', because 'hdev->nvqs' unused after assignment, so remove it.
> 
> nit: The line should not be longer than 76 characters [0].
> 
> [0] http://wiki.qemu-project.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message

Also, make sure you have proper threading.  Although you sent a 0/3
cover letter (with Message-ID:
<1491548305-75464-1-git-send-email-weiqi4@huawei.com>), this 1/3 message
is lacking both References: and In-Reply-To: headers, and therefore
appears as its own top level thread.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH 1/3] vhost: simple clean up

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

On Fri, Apr 07, 2017 at 02:58:46PM +0800, weiqi wrote:
> From: Wei Qi <weiqi4@huawei.com>
> 
> It is unnecessary to assign 'hdev->nvqs' to 'i', because 'hdev->nvqs' unused after assignment, so remove it.
> 
> Signed-off-by: Wei Qi <weiqi4@huawei.com>
> ---
>  hw/virtio/vhost.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]