Re: [Qemu-devel] [PATCH v2 2/2] Add new PCI ID for i82559a

[Jason Wang <jasowang@redhat.com>]

On 2017年11月15日 21:09, Michael Nawrocki wrote:
> On 11/14/2017 04:41 PM, Stefan Weil wrote:
>> Am 06.11.2017 um 21:35 schrieb Mike Nawrocki:
>>> Adds a new PCI ID for the i82559a (0x8086 0x1030) interface. Enables
>>> this ID with a new property "use-alt-device-id" to preserve
>>> compatibility.
>>>
>>> Signed-off-by: Mike Nawrocki <michael.nawrocki@gtri.gatech.edu>
>>> ---
>>>   hw/net/eepro100.c    | 12 ++++++++++++
>>>   include/hw/pci/pci.h |  1 +
>>>   qemu-options.hx      |  2 +-
>>>   3 files changed, 14 insertions(+), 1 deletion(-)
>>
>>
>> Sorry that I missed this patch.
>> I think I should have an entry for eepro100 in MAINTAINERS.
>>
>> Mike, which hardware uses i82559a with PCI device id 0x1030?
>>
>> https://www.intel.com/content/www/us/en/support/articles/000005612/network-and-i-o/ethernet-products.html 
>>
>> only lists devices with
>> 0x1229.
>>
>> Thanks,
>> Stefan
>>
>
> Hi Stefan,
>
> I've got a VxWorks driver binary that explicitly looks for device ID 
> 0x1030 (which is admittedly not ideal). It seems like the "82559 
> InBusiness 10/100" hardware uses this, though I've had trouble finding 
> an official source. The following documents reference that ID:
>
> https://pci-ids.ucw.cz/read/PC/8086/1030
> http://ks.pams.ncsu.edu/pub/ncsuscyld/i386/misc/src/trees/hdstg2/modules/pcitable 
>
> https://cateee.net/lkddb/web-lkddb/E100.html
>
> And I found a similar post on a different mailing list that might shed 
> some light:
> http://www.beowulf.org/pipermail/eepro100/2000-January/000760.html
>
> It looks like the 8255x series of devices have a number of potential 
> IDs; maybe a property to set a specific PCI device ID would work?

Maybe we should use the same method as used in e1000 which can have 
different ids depends on types.

Thanks

>
> Thanks,
> Mike