From: Paolo Bonzini <pbonzini@redhat.com>
To: Reinoud Zandijk <reinoud@NetBSD.org>
Cc: Kamil Rytarowski <kamil@NetBSD.org>,
Ryo ONODERA <ryoon@netbsd.org>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH v6 1/4] Add NVMM accelerator: configure and build logic
Date: Thu, 1 Apr 2021 14:44:35 +0200 [thread overview]
Message-ID: <cf8800fa-d854-c475-aae7-bd9a96a31f74@redhat.com> (raw)
In-Reply-To: <YGW50ugBOV+GIe+3@diablo.13thmonkey.org>
On 01/04/21 14:17, Reinoud Zandijk wrote:
> Hi Paolo,
>
> thanks for the review!
>
> On Thu, Apr 01, 2021 at 10:28:19AM +0200, Paolo Bonzini wrote:
>> On 31/03/21 22:07, Reinoud Zandijk wrote:
>>> Signed-off-by: Reinoud Zandijk <reinoud@NetBSD.org>
>>> Signed-off-by: Kamil Rytarowski <kamil@NetBSD.org>
>>
>> Incorrect order for the S-o-b headers, you should be last.
>
> Oops? there is a prescribed order in those? Will change the order!
The second got the patch from the first, the third from the second etc.
> Will try to fix it and go for version 7 soon.
>
> Is there a way for `qemu format-patch' to preserve the comments made in the
> previous run? It would be handy if it would paste in the old patchset's
> comments in the new patchset :)
Hmm, not sure what you mean. There is "git notes".
Paolo
next prev parent reply other threads:[~2021-04-01 12:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 20:07 [PATCH v6 0/4] Implements the NetBSD Virtual Machine Monitor accelerator Reinoud Zandijk
2021-03-31 20:07 ` [PATCH v6 1/4] Add NVMM accelerator: configure and build logic Reinoud Zandijk
2021-04-01 8:28 ` Paolo Bonzini
2021-04-01 12:17 ` Reinoud Zandijk
2021-04-01 12:44 ` Paolo Bonzini [this message]
2021-03-31 20:07 ` [PATCH v6 2/4] Add NVMM accelerator: x86 CPU support Reinoud Zandijk
2021-04-01 8:35 ` Paolo Bonzini
2021-04-01 12:32 ` Reinoud Zandijk
2021-04-01 12:48 ` Paolo Bonzini
2021-03-31 20:07 ` [PATCH v6 3/4] Add NVMM accelerator: acceleration enlightenments Reinoud Zandijk
2021-03-31 20:08 ` [PATCH v6 4/4] Add NVMM Accelerator: add maintainers for NetBSD/NVMM Reinoud Zandijk
2021-04-01 8:36 ` [PATCH v6 0/4] Implements the NetBSD Virtual Machine Monitor accelerator Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf8800fa-d854-c475-aae7-bd9a96a31f74@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kamil@NetBSD.org \
--cc=qemu-devel@nongnu.org \
--cc=reinoud@NetBSD.org \
--cc=richard.henderson@linaro.org \
--cc=ryoon@netbsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).