* [PATCH 1/6] MAINTAINERS: update docs file extensions (.txt -> .rst)
2025-06-16 15:46 [PATCH 0/6] Fix paths for relocated files Sean Wei
@ 2025-06-16 15:47 ` Sean Wei
2025-07-01 17:18 ` Thomas Huth
2025-06-16 15:48 ` [PATCH 2/6] MAINTAINERS: fix paths for relocated files Sean Wei
` (4 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: Sean Wei @ 2025-06-16 15:47 UTC (permalink / raw)
To: qemu-devel
Cc: Sean Wei, Dmitry Fleytman, Philippe Mathieu-Daudé,
Gerd Hoffmann
The documentation tree has been converted to reStructuredText, but
two entries in MAINTAINERS still point to the removed *.txt files.
This prevents scripts/get_maintainer.pl from matching the documents.
Update those entries to *.rst so the maintainer script works again.
Related commits:
8472cc5dbe6 (Sep 2023): docs/specs/vmw_pvscsi-spec: Convert to rST
8e72ceee5cd (Jun 2022): Rename docs/specs/fw_cfg.txt to .rst
Signed-off-by: Sean Wei <me@sean.taipei>
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 28b3dd2684..fed8619874 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2531,7 +2531,7 @@ F: hw/net/net_tx_pkt*
Vmware
M: Dmitry Fleytman <dmitry.fleytman@gmail.com>
S: Maintained
-F: docs/specs/vmw_pvscsi-spec.txt
+F: docs/specs/vmw_pvscsi-spec.rst
F: hw/display/vmware_vga.c
F: hw/net/vmxnet*
F: hw/scsi/vmw_pvscsi*
@@ -2736,7 +2736,7 @@ Firmware configuration (fw_cfg)
M: Philippe Mathieu-Daudé <philmd@linaro.org>
R: Gerd Hoffmann <kraxel@redhat.com>
S: Supported
-F: docs/specs/fw_cfg.txt
+F: docs/specs/fw_cfg.rst
F: hw/nvram/fw_cfg*.c
F: stubs/fw_cfg.c
F: include/hw/nvram/fw_cfg.h
--
2.49.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 1/6] MAINTAINERS: update docs file extensions (.txt -> .rst)
2025-06-16 15:47 ` [PATCH 1/6] MAINTAINERS: update docs file extensions (.txt -> .rst) Sean Wei
@ 2025-07-01 17:18 ` Thomas Huth
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2025-07-01 17:18 UTC (permalink / raw)
To: Sean Wei, qemu-devel
Cc: Dmitry Fleytman, Philippe Mathieu-Daudé, Gerd Hoffmann,
Peter Maydell
On 16/06/2025 17.47, Sean Wei wrote:
> The documentation tree has been converted to reStructuredText, but
> two entries in MAINTAINERS still point to the removed *.txt files.
>
> This prevents scripts/get_maintainer.pl from matching the documents.
>
> Update those entries to *.rst so the maintainer script works again.
>
> Related commits:
> 8472cc5dbe6 (Sep 2023): docs/specs/vmw_pvscsi-spec: Convert to rST
> 8e72ceee5cd (Jun 2022): Rename docs/specs/fw_cfg.txt to .rst
>
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
> MAINTAINERS | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 28b3dd2684..fed8619874 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2531,7 +2531,7 @@ F: hw/net/net_tx_pkt*
> Vmware
> M: Dmitry Fleytman <dmitry.fleytman@gmail.com>
> S: Maintained
> -F: docs/specs/vmw_pvscsi-spec.txt
> +F: docs/specs/vmw_pvscsi-spec.rst
> F: hw/display/vmware_vga.c
> F: hw/net/vmxnet*
> F: hw/scsi/vmw_pvscsi*
> @@ -2736,7 +2736,7 @@ Firmware configuration (fw_cfg)
> M: Philippe Mathieu-Daudé <philmd@linaro.org>
> R: Gerd Hoffmann <kraxel@redhat.com>
> S: Supported
> -F: docs/specs/fw_cfg.txt
> +F: docs/specs/fw_cfg.rst
> F: hw/nvram/fw_cfg*.c
> F: stubs/fw_cfg.c
> F: include/hw/nvram/fw_cfg.h
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/6] MAINTAINERS: fix paths for relocated files
2025-06-16 15:46 [PATCH 0/6] Fix paths for relocated files Sean Wei
2025-06-16 15:47 ` [PATCH 1/6] MAINTAINERS: update docs file extensions (.txt -> .rst) Sean Wei
@ 2025-06-16 15:48 ` Sean Wei
2025-07-01 17:24 ` Thomas Huth
2025-06-16 15:49 ` [PATCH 3/6] MAINTAINERS: fix vendor capitalization (Vmware -> VMware) Sean Wei
` (3 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: Sean Wei @ 2025-06-16 15:48 UTC (permalink / raw)
To: qemu-devel
Cc: Sean Wei, Peter Maydell, qemu-arm, Jason Wang, David Hildenbrand,
Igor Mammedov, Xiao Guangrong, Paolo Bonzini,
Dr . David Alan Gilbert
Several files were renamed in previous commits, causing their entries
in MAINTAINERS to reference outdated paths.
This prevents scripts/get_maintainer.pl from correctly matching
these files to their maintainers.
Update the filenames to reflect their current locations so that
maintainer lookup works properly.
Related commits
---------------
c45460decbd (Oct 2023)
hw/input/stellaris_input: Rename to stellaris_gamepad
Rename include/hw/input/{gamepad.h => stellaris_gamepad.h}
4faf359accb (Nov 2020)
docs: Move virtio-net-failover.rst into the system manual
Rename docs/{ => system}/virtio-net-failover.rst
89857312f32 (Apr 2024)
hw/usb: move stubs out of stubs/
Rename stubs/usb-dev-stub.c => hw/usb/bus-stub.c
f2604d8508a (Apr 2024)
hw/virtio: move stubs out of stubs/
Rename stubs/virtio-md-pci.c => hw/virtio/virtio-md-stubs.c
2c888febdfa (Apr 2024)
memory-device: move stubs out of stubs/
Rename stubs/memory_device.c => hw/mem/memory-device-stubs.c
d481cec7565 (Oct 2024)
migration: Move cpu-throttle.c from system to migration
Rename {system => migration}/cpu-throttle.c
864a3fa4392 (Jan 2023)
monitor: Rename misc.c to hmp-target.c
Rename monitor/{misc.c => hmp-target.c}
Signed-off-by: Sean Wei <me@sean.taipei>
---
MAINTAINERS | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index fed8619874..0477e124d1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1002,7 +1002,7 @@ L: qemu-arm@nongnu.org
S: Odd Fixes
F: hw/*/stellaris*
F: hw/display/ssd03*
-F: include/hw/input/gamepad.h
+F: include/hw/input/stellaris_gamepad.h
F: include/hw/timer/stellaris-gptm.h
F: docs/system/arm/stellaris.rst
F: tests/functional/test_arm_stellaris.py
@@ -2163,7 +2163,7 @@ F: hw/net/
F: include/hw/net/
F: tests/qtest/virtio-net-test.c
F: tests/functional/test_info_usernet.py
-F: docs/virtio-net-failover.rst
+F: docs/system/virtio-net-failover.rst
T: git https://github.com/jasowang/qemu.git net
Parallel NOR Flash devices
@@ -2214,7 +2214,7 @@ F: tests/qtest/sdhci-test.c
USB
S: Orphan
F: hw/usb/*
-F: stubs/usb-dev-stub.c
+F: hw/usb/bus-stub.c
F: tests/qtest/usb-*-test.c
F: docs/system/devices/usb.rst
F: include/hw/usb.h
@@ -2469,7 +2469,7 @@ F: hw/s390x/virtio-ccw-md.h
F: hw/s390x/virtio-ccw-md-stubs.c
F: hw/virtio/virtio-md-pci.c
F: include/hw/virtio/virtio-md-pci.h
-F: stubs/virtio-md-pci.c
+F: hw/virtio/virtio-md-stubs.c
virtio-mem
M: David Hildenbrand <david@redhat.com>
@@ -3187,7 +3187,7 @@ F: hw/mem/pc-dimm.c
F: include/hw/mem/memory-device.h
F: include/hw/mem/nvdimm.h
F: include/hw/mem/pc-dimm.h
-F: stubs/memory_device.c
+F: hw/mem/memory-device-stubs.c
F: docs/nvdimm.txt
SPICE
@@ -3228,9 +3228,9 @@ F: util/qemu-timer*.c
F: system/vl.c
F: system/main.c
F: system/cpus.c
-F: system/cpu-throttle.c
F: system/cpu-timers.c
F: system/runstate*
+F: migration/cpu-throttle.c
F: qapi/run-state.json
Read, Copy, Update (RCU)
@@ -3249,7 +3249,7 @@ Human Monitor (HMP)
M: Dr. David Alan Gilbert <dave@treblig.org>
S: Maintained
F: monitor/monitor-internal.h
-F: monitor/misc.c
+F: monitor/hmp-target.c
F: monitor/monitor.c
F: monitor/hmp*
F: hmp.h
--
2.49.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 2/6] MAINTAINERS: fix paths for relocated files
2025-06-16 15:48 ` [PATCH 2/6] MAINTAINERS: fix paths for relocated files Sean Wei
@ 2025-07-01 17:24 ` Thomas Huth
2025-07-01 18:06 ` Sean Wei
0 siblings, 1 reply; 15+ messages in thread
From: Thomas Huth @ 2025-07-01 17:24 UTC (permalink / raw)
To: Sean Wei, qemu-devel
Cc: Peter Maydell, qemu-arm, Jason Wang, David Hildenbrand,
Igor Mammedov, Xiao Guangrong, Paolo Bonzini,
Dr . David Alan Gilbert
On 16/06/2025 17.48, Sean Wei wrote:
> Several files were renamed in previous commits, causing their entries
> in MAINTAINERS to reference outdated paths.
> This prevents scripts/get_maintainer.pl from correctly matching
> these files to their maintainers.
>
> Update the filenames to reflect their current locations so that
> maintainer lookup works properly.
>
> Related commits
> ---------------
>
> c45460decbd (Oct 2023)
> hw/input/stellaris_input: Rename to stellaris_gamepad
> Rename include/hw/input/{gamepad.h => stellaris_gamepad.h}
>
> 4faf359accb (Nov 2020)
> docs: Move virtio-net-failover.rst into the system manual
> Rename docs/{ => system}/virtio-net-failover.rst
>
> 89857312f32 (Apr 2024)
> hw/usb: move stubs out of stubs/
> Rename stubs/usb-dev-stub.c => hw/usb/bus-stub.c
>
> f2604d8508a (Apr 2024)
> hw/virtio: move stubs out of stubs/
> Rename stubs/virtio-md-pci.c => hw/virtio/virtio-md-stubs.c
>
> 2c888febdfa (Apr 2024)
> memory-device: move stubs out of stubs/
> Rename stubs/memory_device.c => hw/mem/memory-device-stubs.c
>
> d481cec7565 (Oct 2024)
> migration: Move cpu-throttle.c from system to migration
> Rename {system => migration}/cpu-throttle.c
>
> 864a3fa4392 (Jan 2023)
> monitor: Rename misc.c to hmp-target.c
> Rename monitor/{misc.c => hmp-target.c}
>
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
> MAINTAINERS | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fed8619874..0477e124d1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1002,7 +1002,7 @@ L: qemu-arm@nongnu.org
> S: Odd Fixes
> F: hw/*/stellaris*
> F: hw/display/ssd03*
> -F: include/hw/input/gamepad.h
> +F: include/hw/input/stellaris_gamepad.h
> F: include/hw/timer/stellaris-gptm.h
> F: docs/system/arm/stellaris.rst
> F: tests/functional/test_arm_stellaris.py
> @@ -2163,7 +2163,7 @@ F: hw/net/
> F: include/hw/net/
> F: tests/qtest/virtio-net-test.c
> F: tests/functional/test_info_usernet.py
> -F: docs/virtio-net-failover.rst
> +F: docs/system/virtio-net-failover.rst
> T: git https://github.com/jasowang/qemu.git net
>
> Parallel NOR Flash devices
> @@ -2214,7 +2214,7 @@ F: tests/qtest/sdhci-test.c
> USB
> S: Orphan
> F: hw/usb/*
> -F: stubs/usb-dev-stub.c
> +F: hw/usb/bus-stub.c
I think we could simply drop this line now completely since it is already
covered by the previous hw/usb/* wildcard line.
> F: tests/qtest/usb-*-test.c
> F: docs/system/devices/usb.rst
> F: include/hw/usb.h
> @@ -2469,7 +2469,7 @@ F: hw/s390x/virtio-ccw-md.h
> F: hw/s390x/virtio-ccw-md-stubs.c
> F: hw/virtio/virtio-md-pci.c
> F: include/hw/virtio/virtio-md-pci.h
> -F: stubs/virtio-md-pci.c
> +F: hw/virtio/virtio-md-stubs.c
Could be merged with the hw/virtio/virtio-md-pci.c line by turning it into:
F: hw/virtio/virtio-md-*.c
> virtio-mem
> M: David Hildenbrand <david@redhat.com>
> @@ -3187,7 +3187,7 @@ F: hw/mem/pc-dimm.c
> F: include/hw/mem/memory-device.h
> F: include/hw/mem/nvdimm.h
> F: include/hw/mem/pc-dimm.h
> -F: stubs/memory_device.c
> +F: hw/mem/memory-device-stubs.c
This could be merged with the preceeding "hw/mem/memory-device.c" line, too,
by turning it into:
F: hw/mem/memory-device*.c
Thomas
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 2/6] MAINTAINERS: fix paths for relocated files
2025-07-01 17:24 ` Thomas Huth
@ 2025-07-01 18:06 ` Sean Wei
2025-07-01 18:54 ` Thomas Huth
0 siblings, 1 reply; 15+ messages in thread
From: Sean Wei @ 2025-07-01 18:06 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Sean Wei, Peter Maydell, qemu-arm, Jason Wang,
David Hildenbrand, Igor Mammedov, Xiao Guangrong, Paolo Bonzini,
Dr . David Alan Gilbert
On 2025/7/1 1:24 PM, Thomas Huth wrote:
> On 16/06/2025 17.48, Sean Wei wrote:
>> Several files were renamed in previous commits, causing their entries
>> in MAINTAINERS to reference outdated paths.
>> This prevents scripts/get_maintainer.pl from correctly matching
>> these files to their maintainers.
>>
>> Update the filenames to reflect their current locations so that
>> maintainer lookup works properly.
>>
>> Related commits
>> ---------------
>>
>> c45460decbd (Oct 2023)
>> hw/input/stellaris_input: Rename to stellaris_gamepad
>> Rename include/hw/input/{gamepad.h => stellaris_gamepad.h}
>>
>> 4faf359accb (Nov 2020)
>> docs: Move virtio-net-failover.rst into the system manual
>> Rename docs/{ => system}/virtio-net-failover.rst
>>
>> 89857312f32 (Apr 2024)
>> hw/usb: move stubs out of stubs/
>> Rename stubs/usb-dev-stub.c => hw/usb/bus-stub.c
>>
>> f2604d8508a (Apr 2024)
>> hw/virtio: move stubs out of stubs/
>> Rename stubs/virtio-md-pci.c => hw/virtio/virtio-md-stubs.c
>>
>> 2c888febdfa (Apr 2024)
>> memory-device: move stubs out of stubs/
>> Rename stubs/memory_device.c => hw/mem/memory-device-stubs.c
>>
>> d481cec7565 (Oct 2024)
>> migration: Move cpu-throttle.c from system to migration
>> Rename {system => migration}/cpu-throttle.c
>>
>> 864a3fa4392 (Jan 2023)
>> monitor: Rename misc.c to hmp-target.c
>> Rename monitor/{misc.c => hmp-target.c}
>>
>> Signed-off-by: Sean Wei <me@sean.taipei>
>> ---
>> MAINTAINERS | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index fed8619874..0477e124d1 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1002,7 +1002,7 @@ L: qemu-arm@nongnu.org
>> S: Odd Fixes
>> F: hw/*/stellaris*
>> F: hw/display/ssd03*
>> -F: include/hw/input/gamepad.h
>> +F: include/hw/input/stellaris_gamepad.h
>> F: include/hw/timer/stellaris-gptm.h
>> F: docs/system/arm/stellaris.rst
>> F: tests/functional/test_arm_stellaris.py
>> @@ -2163,7 +2163,7 @@ F: hw/net/
>> F: include/hw/net/
>> F: tests/qtest/virtio-net-test.c
>> F: tests/functional/test_info_usernet.py
>> -F: docs/virtio-net-failover.rst
>> +F: docs/system/virtio-net-failover.rst
>> T: git https://github.com/jasowang/qemu.git net
>> Parallel NOR Flash devices
>> @@ -2214,7 +2214,7 @@ F: tests/qtest/sdhci-test.c
>> USB
>> S: Orphan
>> F: hw/usb/*
>> -F: stubs/usb-dev-stub.c
>> +F: hw/usb/bus-stub.c
>
> I think we could simply drop this line now completely since it is
> already covered by the previous hw/usb/* wildcard line.
>
>> F: tests/qtest/usb-*-test.c
>> F: docs/system/devices/usb.rst
>> F: include/hw/usb.h
>> @@ -2469,7 +2469,7 @@ F: hw/s390x/virtio-ccw-md.h
>> F: hw/s390x/virtio-ccw-md-stubs.c
>> F: hw/virtio/virtio-md-pci.c
>> F: include/hw/virtio/virtio-md-pci.h
>> -F: stubs/virtio-md-pci.c
>> +F: hw/virtio/virtio-md-stubs.c
>
> Could be merged with the hw/virtio/virtio-md-pci.c line by turning it into:
>
> F: hw/virtio/virtio-md-*.c
>
>> virtio-mem
>> M: David Hildenbrand <david@redhat.com>
>> @@ -3187,7 +3187,7 @@ F: hw/mem/pc-dimm.c
>> F: include/hw/mem/memory-device.h
>> F: include/hw/mem/nvdimm.h
>> F: include/hw/mem/pc-dimm.h
>> -F: stubs/memory_device.c
>> +F: hw/mem/memory-device-stubs.c
>
> This could be merged with the preceeding "hw/mem/memory-device.c" line,
> too, by turning it into:
>
> F: hw/mem/memory-device*.c
>
> Thomas
>
Hi Thomas,
Oh yeah, those suggestions makes sense to me, and make this patch much
better!
Should I send a PATCH v2 to the mailing list, or just attach the fix-up
like this is enough?
I've also reviewed other files and no other improvement found.
Best wishes,
Sean Wei
---
Several files were renamed in previous commits, causing their entries
in MAINTAINERS to reference outdated paths.
This prevents scripts/get_maintainer.pl from correctly matching
these files to their maintainers.
Update the filenames to reflect their current locations so that
maintainer lookup works properly.
Related commits
---------------
c45460decbd (Oct 2023)
hw/input/stellaris_input: Rename to stellaris_gamepad
Rename include/hw/input/{gamepad.h => stellaris_gamepad.h}
4faf359accb (Nov 2020)
docs: Move virtio-net-failover.rst into the system manual
Rename docs/{ => system}/virtio-net-failover.rst
89857312f32 (Apr 2024)
hw/usb: move stubs out of stubs/
Rename stubs/usb-dev-stub.c => hw/usb/bus-stub.c
f2604d8508a (Apr 2024)
hw/virtio: move stubs out of stubs/
Rename stubs/virtio-md-pci.c => hw/virtio/virtio-md-stubs.c
2c888febdfa (Apr 2024)
memory-device: move stubs out of stubs/
Rename stubs/memory_device.c => hw/mem/memory-device-stubs.c
d481cec7565 (Oct 2024)
migration: Move cpu-throttle.c from system to migration
Rename {system => migration}/cpu-throttle.c
864a3fa4392 (Jan 2023)
monitor: Rename misc.c to hmp-target.c
Rename monitor/{misc.c => hmp-target.c}
Signed-off-by: Sean Wei <me@sean.taipei>
---
MAINTAINERS | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b7f321597f..d855cb1491 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1005,7 +1005,7 @@ L: qemu-arm@nongnu.org
S: Odd Fixes
F: hw/*/stellaris*
F: hw/display/ssd03*
-F: include/hw/input/gamepad.h
+F: include/hw/input/stellaris_gamepad.h
F: include/hw/timer/stellaris-gptm.h
F: docs/system/arm/stellaris.rst
F: tests/functional/test_arm_stellaris.py
@@ -2171,7 +2171,7 @@ F: hw/net/
F: include/hw/net/
F: tests/qtest/virtio-net-test.c
F: tests/functional/test_info_usernet.py
-F: docs/virtio-net-failover.rst
+F: docs/system/virtio-net-failover.rst
T: git https://github.com/jasowang/qemu.git net
Parallel NOR Flash devices
@@ -2222,7 +2222,6 @@ F: tests/qtest/sdhci-test.c
USB
S: Orphan
F: hw/usb/*
-F: stubs/usb-dev-stub.c
F: tests/qtest/usb-*-test.c
F: docs/system/devices/usb.rst
F: include/hw/usb.h
@@ -2475,9 +2474,8 @@ S: Supported
F: hw/s390x/virtio-ccw-md.c
F: hw/s390x/virtio-ccw-md.h
F: hw/s390x/virtio-ccw-md-stubs.c
-F: hw/virtio/virtio-md-pci.c
+F: hw/virtio/virtio-md-*.c
F: include/hw/virtio/virtio-md-pci.h
-F: stubs/virtio-md-pci.c
virtio-mem
M: David Hildenbrand <david@redhat.com>
@@ -3195,13 +3193,12 @@ M: David Hildenbrand <david@redhat.com>
M: Igor Mammedov <imammedo@redhat.com>
R: Xiao Guangrong <xiaoguangrong.eric@gmail.com>
S: Supported
-F: hw/mem/memory-device.c
+F: hw/mem/memory-device*.c
F: hw/mem/nvdimm.c
F: hw/mem/pc-dimm.c
F: include/hw/mem/memory-device.h
F: include/hw/mem/nvdimm.h
F: include/hw/mem/pc-dimm.h
-F: stubs/memory_device.c
F: docs/nvdimm.txt
SPICE
@@ -3242,9 +3239,9 @@ F: util/qemu-timer*.c
F: system/vl.c
F: system/main.c
F: system/cpus.c
-F: system/cpu-throttle.c
F: system/cpu-timers.c
F: system/runstate*
+F: migration/cpu-throttle.c
F: qapi/run-state.json
Read, Copy, Update (RCU)
@@ -3263,7 +3260,7 @@ Human Monitor (HMP)
M: Dr. David Alan Gilbert <dave@treblig.org>
S: Maintained
F: monitor/monitor-internal.h
-F: monitor/misc.c
+F: monitor/hmp-target.c
F: monitor/monitor.c
F: monitor/hmp*
F: hmp.h
--
2.50.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 2/6] MAINTAINERS: fix paths for relocated files
2025-07-01 18:06 ` Sean Wei
@ 2025-07-01 18:54 ` Thomas Huth
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2025-07-01 18:54 UTC (permalink / raw)
To: Sean Wei
Cc: qemu-devel, Peter Maydell, qemu-arm, Jason Wang,
David Hildenbrand, Igor Mammedov, Xiao Guangrong, Paolo Bonzini,
Dr . David Alan Gilbert
On 01/07/2025 20.06, Sean Wei wrote:
> On 2025/7/1 1:24 PM, Thomas Huth wrote:
>> On 16/06/2025 17.48, Sean Wei wrote:
>>> Several files were renamed in previous commits, causing their entries
>>> in MAINTAINERS to reference outdated paths.
>>> This prevents scripts/get_maintainer.pl from correctly matching
>>> these files to their maintainers.
>>>
>>> Update the filenames to reflect their current locations so that
>>> maintainer lookup works properly.
>>>
>>> Related commits
>>> ---------------
>>>
>>> c45460decbd (Oct 2023)
>>> hw/input/stellaris_input: Rename to stellaris_gamepad
>>> Rename include/hw/input/{gamepad.h => stellaris_gamepad.h}
>>>
>>> 4faf359accb (Nov 2020)
>>> docs: Move virtio-net-failover.rst into the system manual
>>> Rename docs/{ => system}/virtio-net-failover.rst
>>>
>>> 89857312f32 (Apr 2024)
>>> hw/usb: move stubs out of stubs/
>>> Rename stubs/usb-dev-stub.c => hw/usb/bus-stub.c
>>>
>>> f2604d8508a (Apr 2024)
>>> hw/virtio: move stubs out of stubs/
>>> Rename stubs/virtio-md-pci.c => hw/virtio/virtio-md-stubs.c
>>>
>>> 2c888febdfa (Apr 2024)
>>> memory-device: move stubs out of stubs/
>>> Rename stubs/memory_device.c => hw/mem/memory-device-stubs.c
>>>
>>> d481cec7565 (Oct 2024)
>>> migration: Move cpu-throttle.c from system to migration
>>> Rename {system => migration}/cpu-throttle.c
>>>
>>> 864a3fa4392 (Jan 2023)
>>> monitor: Rename misc.c to hmp-target.c
>>> Rename monitor/{misc.c => hmp-target.c}
>>>
>>> Signed-off-by: Sean Wei <me@sean.taipei>
>>> ---
>>> MAINTAINERS | 14 +++++++-------
>>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index fed8619874..0477e124d1 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1002,7 +1002,7 @@ L: qemu-arm@nongnu.org
>>> S: Odd Fixes
>>> F: hw/*/stellaris*
>>> F: hw/display/ssd03*
>>> -F: include/hw/input/gamepad.h
>>> +F: include/hw/input/stellaris_gamepad.h
>>> F: include/hw/timer/stellaris-gptm.h
>>> F: docs/system/arm/stellaris.rst
>>> F: tests/functional/test_arm_stellaris.py
>>> @@ -2163,7 +2163,7 @@ F: hw/net/
>>> F: include/hw/net/
>>> F: tests/qtest/virtio-net-test.c
>>> F: tests/functional/test_info_usernet.py
>>> -F: docs/virtio-net-failover.rst
>>> +F: docs/system/virtio-net-failover.rst
>>> T: git https://github.com/jasowang/qemu.git net
>>> Parallel NOR Flash devices
>>> @@ -2214,7 +2214,7 @@ F: tests/qtest/sdhci-test.c
>>> USB
>>> S: Orphan
>>> F: hw/usb/*
>>> -F: stubs/usb-dev-stub.c
>>> +F: hw/usb/bus-stub.c
>>
>> I think we could simply drop this line now completely since it is already
>> covered by the previous hw/usb/* wildcard line.
>>
>>> F: tests/qtest/usb-*-test.c
>>> F: docs/system/devices/usb.rst
>>> F: include/hw/usb.h
>>> @@ -2469,7 +2469,7 @@ F: hw/s390x/virtio-ccw-md.h
>>> F: hw/s390x/virtio-ccw-md-stubs.c
>>> F: hw/virtio/virtio-md-pci.c
>>> F: include/hw/virtio/virtio-md-pci.h
>>> -F: stubs/virtio-md-pci.c
>>> +F: hw/virtio/virtio-md-stubs.c
>>
>> Could be merged with the hw/virtio/virtio-md-pci.c line by turning it into:
>>
>> F: hw/virtio/virtio-md-*.c
>>
>>> virtio-mem
>>> M: David Hildenbrand <david@redhat.com>
>>> @@ -3187,7 +3187,7 @@ F: hw/mem/pc-dimm.c
>>> F: include/hw/mem/memory-device.h
>>> F: include/hw/mem/nvdimm.h
>>> F: include/hw/mem/pc-dimm.h
>>> -F: stubs/memory_device.c
>>> +F: hw/mem/memory-device-stubs.c
>>
>> This could be merged with the preceeding "hw/mem/memory-device.c" line,
>> too, by turning it into:
>>
>> F: hw/mem/memory-device*.c
>>
>> Thomas
>>
>
>
> Hi Thomas,
>
> Oh yeah, those suggestions makes sense to me, and make this patch much better!
>
> Should I send a PATCH v2 to the mailing list, or just attach the fix-up like
> this is enough?
Normally I'd recommend a proper v2, but this time I was also able to apply
your inlined updated patch, so no need to resend.
Thanks, I'll queue your patches for my next pull request.
Thomas
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 3/6] MAINTAINERS: fix vendor capitalization (Vmware -> VMware)
2025-06-16 15:46 [PATCH 0/6] Fix paths for relocated files Sean Wei
2025-06-16 15:47 ` [PATCH 1/6] MAINTAINERS: update docs file extensions (.txt -> .rst) Sean Wei
2025-06-16 15:48 ` [PATCH 2/6] MAINTAINERS: fix paths for relocated files Sean Wei
@ 2025-06-16 15:49 ` Sean Wei
2025-06-16 15:50 ` [PATCH 4/6] MAINTAINERS: fix VMware filename typo (vwm -> vmw) Sean Wei
` (2 subsequent siblings)
5 siblings, 0 replies; 15+ messages in thread
From: Sean Wei @ 2025-06-16 15:49 UTC (permalink / raw)
To: qemu-devel; +Cc: Sean Wei, Dmitry Fleytman
"VMware" is the vendor's official spelling.
Adjust the spelling in MAINTAINERS for consistency.
Signed-off-by: Sean Wei <me@sean.taipei>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0477e124d1..7428217361 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2528,7 +2528,7 @@ F: net/eth.c
F: hw/net/net_rx_pkt*
F: hw/net/net_tx_pkt*
-Vmware
+VMware
M: Dmitry Fleytman <dmitry.fleytman@gmail.com>
S: Maintained
F: docs/specs/vmw_pvscsi-spec.rst
--
2.49.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 4/6] MAINTAINERS: fix VMware filename typo (vwm -> vmw)
2025-06-16 15:46 [PATCH 0/6] Fix paths for relocated files Sean Wei
` (2 preceding siblings ...)
2025-06-16 15:49 ` [PATCH 3/6] MAINTAINERS: fix vendor capitalization (Vmware -> VMware) Sean Wei
@ 2025-06-16 15:50 ` Sean Wei
2025-07-01 17:25 ` Thomas Huth
2025-06-16 15:50 ` [PATCH 5/6] treewide: update docs file extensions (.txt -> .rst) in comments Sean Wei
2025-06-16 15:51 ` [PATCH 6/6] treewide: fix paths for relocated files " Sean Wei
5 siblings, 1 reply; 15+ messages in thread
From: Sean Wei @ 2025-06-16 15:50 UTC (permalink / raw)
To: qemu-devel; +Cc: Sean Wei, Dmitry Fleytman
The entry for the VMware PVSCSI spec uses "vwm" instead of "vmw",
which does not match any file in the tree.
Correct the path so scripts/get_maintainer.pl can match the file.
Signed-off-by: Sean Wei <me@sean.taipei>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7428217361..ad82fa4d9a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2539,7 +2539,7 @@ F: pc-bios/efi-vmxnet3.rom
F: pc-bios/vgabios-vmware.bin
F: roms/config.vga-vmware
F: tests/qtest/vmxnet3-test.c
-F: docs/specs/vwm_pvscsi-spec.rst
+F: docs/specs/vmw_pvscsi-spec.rst
Rocker
M: Jiri Pirko <jiri@resnulli.us>
--
2.49.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 4/6] MAINTAINERS: fix VMware filename typo (vwm -> vmw)
2025-06-16 15:50 ` [PATCH 4/6] MAINTAINERS: fix VMware filename typo (vwm -> vmw) Sean Wei
@ 2025-07-01 17:25 ` Thomas Huth
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2025-07-01 17:25 UTC (permalink / raw)
To: Sean Wei, qemu-devel; +Cc: Dmitry Fleytman
On 16/06/2025 17.50, Sean Wei wrote:
> The entry for the VMware PVSCSI spec uses "vwm" instead of "vmw",
> which does not match any file in the tree.
>
> Correct the path so scripts/get_maintainer.pl can match the file.
>
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7428217361..ad82fa4d9a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2539,7 +2539,7 @@ F: pc-bios/efi-vmxnet3.rom
> F: pc-bios/vgabios-vmware.bin
> F: roms/config.vga-vmware
> F: tests/qtest/vmxnet3-test.c
> -F: docs/specs/vwm_pvscsi-spec.rst
> +F: docs/specs/vmw_pvscsi-spec.rst
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 5/6] treewide: update docs file extensions (.txt -> .rst) in comments
2025-06-16 15:46 [PATCH 0/6] Fix paths for relocated files Sean Wei
` (3 preceding siblings ...)
2025-06-16 15:50 ` [PATCH 4/6] MAINTAINERS: fix VMware filename typo (vwm -> vmw) Sean Wei
@ 2025-06-16 15:50 ` Sean Wei
2025-07-01 17:28 ` Thomas Huth
2025-07-02 5:50 ` Harsh Prateek Bora
2025-06-16 15:51 ` [PATCH 6/6] treewide: fix paths for relocated files " Sean Wei
5 siblings, 2 replies; 15+ messages in thread
From: Sean Wei @ 2025-06-16 15:50 UTC (permalink / raw)
To: qemu-devel
Cc: Sean Wei, Michael S. Tsirkin, Igor Mammedov, Ani Sinha,
Gustavo Romero, Nicholas Piggin, Daniel Henrique Barboza,
Harsh Prateek Bora, Fabiano Rosas, Laurent Vivier, Paolo Bonzini,
open list:sPAPR (pseries)
Several source comments still refer to docs with the old .txt
extension that were previously converted to reStructuredText.
Update these references to use the correct .rst extensions to
maintain accurate in-tree documentation pointers.
No functional changes.
Related commits:
50f8174c5c1 (Jul 2021): docs/specs/acpi_nvdimm: Convert to rST
f054eb1c920 (Jul 2021): docs/specs/acpi_pci_hotplug: Convert to rST
912fb3678b8 (Sep 2023): docs/specs/vmgenid: Convert to rST
bb1cff6ee04 (Sep 2023): docs/specs/ivshmem-spec: Convert to rST
55ff468f781 (Jan 2022): docs: Rename ppc-spapr-hotplug.txt to .rst
Signed-off-by: Sean Wei <me@sean.taipei>
---
hw/acpi/nvdimm.c | 2 +-
hw/acpi/pcihp.c | 2 +-
hw/acpi/vmgenid.c | 6 +++---
hw/misc/ivshmem-flat.c | 2 +-
hw/ppc/spapr.c | 2 +-
include/hw/acpi/pcihp.h | 2 +-
include/hw/misc/ivshmem-flat.h | 2 +-
tests/qtest/vmgenid-test.c | 2 +-
8 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 9ba90806f2..732d613ac0 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -535,7 +535,7 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr dsm_mem_addr)
#define NVDIMM_QEMU_RSVD_HANDLE_ROOT 0x10000
-/* Read FIT data, defined in docs/specs/acpi_nvdimm.txt. */
+/* Read FIT data, defined in docs/specs/acpi_nvdimm.rst. */
static void nvdimm_dsm_func_read_fit(NVDIMMState *state, NvdimmDsmIn *in,
hwaddr dsm_mem_addr)
{
diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index aac90013d4..497281ae20 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -3,7 +3,7 @@
*
* QEMU supports PCI hotplug via ACPI. This module
* implements the interface between QEMU and the ACPI BIOS.
- * Interface specification - see docs/specs/acpi_pci_hotplug.txt
+ * Interface specification - see docs/specs/acpi_pci_hotplug.rst
*
* Copyright (c) 2013, Red Hat Inc, Michael S. Tsirkin (mst@redhat.com)
* Copyright (c) 2006 Fabrice Bellard
diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
index fac3d6d97e..33c35c85dd 100644
--- a/hw/acpi/vmgenid.c
+++ b/hw/acpi/vmgenid.c
@@ -38,7 +38,7 @@ void vmgenid_build_acpi(VmGenIdState *vms, GArray *table_data, GArray *guid,
guid_le = qemu_uuid_bswap(vms->guid);
/* The GUID is written at a fixed offset into the fw_cfg file
* in order to implement the "OVMF SDT Header probe suppressor"
- * see docs/specs/vmgenid.txt for more details
+ * see docs/specs/vmgenid.rst for more details
*/
g_array_insert_vals(guid, VMGENID_GUID_OFFSET, guid_le.data,
ARRAY_SIZE(guid_le.data));
@@ -101,7 +101,7 @@ void vmgenid_build_acpi(VmGenIdState *vms, GArray *table_data, GArray *guid,
* < 4GB, but write 64 bits anyway.
* The address that is patched in is offset in order to implement
* the "OVMF SDT Header probe suppressor"
- * see docs/specs/vmgenid.txt for more details.
+ * see docs/specs/vmgenid.rst for more details.
*/
bios_linker_loader_write_pointer(linker,
VMGENID_ADDR_FW_CFG_FILE, 0, sizeof(uint64_t),
@@ -153,7 +153,7 @@ static void vmgenid_update_guest(VmGenIdState *vms)
guid_le = qemu_uuid_bswap(vms->guid);
/* The GUID is written at a fixed offset into the fw_cfg file
* in order to implement the "OVMF SDT Header probe suppressor"
- * see docs/specs/vmgenid.txt for more details.
+ * see docs/specs/vmgenid.rst for more details.
*/
cpu_physical_memory_write(vmgenid_addr, guid_le.data,
sizeof(guid_le.data));
diff --git a/hw/misc/ivshmem-flat.c b/hw/misc/ivshmem-flat.c
index be28c24d73..fe4be6be17 100644
--- a/hw/misc/ivshmem-flat.c
+++ b/hw/misc/ivshmem-flat.c
@@ -362,7 +362,7 @@ static bool ivshmem_flat_connect_server(DeviceState *dev, Error **errp)
*
* ivshmem_flat_recv_msg() calls return 'msg' and 'fd'.
*
- * See ./docs/specs/ivshmem-spec.txt for details on the protocol.
+ * See docs/specs/ivshmem-spec.rst for details on the protocol.
*/
/* Step 0 */
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 702f774cda..08615f6c90 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -577,7 +577,7 @@ static int spapr_dt_dynamic_memory(SpaprMachineState *spapr, void *fdt,
/*
* Adds ibm,dynamic-reconfiguration-memory node.
- * Refer to docs/specs/ppc-spapr-hotplug.txt for the documentation
+ * Refer to docs/specs/ppc-spapr-hotplug.rst for the documentation
* of this device tree node.
*/
static int spapr_dt_dynamic_reconfiguration_memory(SpaprMachineState *spapr,
diff --git a/include/hw/acpi/pcihp.h b/include/hw/acpi/pcihp.h
index a97904bada..cdc0cb8e43 100644
--- a/include/hw/acpi/pcihp.h
+++ b/include/hw/acpi/pcihp.h
@@ -3,7 +3,7 @@
*
* QEMU supports PCI hotplug via ACPI. This module
* implements the interface between QEMU and the ACPI BIOS.
- * Interface specification - see docs/specs/acpi_pci_hotplug.txt
+ * Interface specification - see docs/specs/acpi_pci_hotplug.rst
*
* Copyright (c) 2013, Red Hat Inc, Michael S. Tsirkin (mst@redhat.com)
* Copyright (c) 2006 Fabrice Bellard
diff --git a/include/hw/misc/ivshmem-flat.h b/include/hw/misc/ivshmem-flat.h
index 09bc3abcad..3eca99004e 100644
--- a/include/hw/misc/ivshmem-flat.h
+++ b/include/hw/misc/ivshmem-flat.h
@@ -36,7 +36,7 @@ typedef struct IvshmemFTState IvshmemFTState;
DECLARE_INSTANCE_CHECKER(IvshmemFTState, IVSHMEM_FLAT, TYPE_IVSHMEM_FLAT)
-/* Ivshmem registers. See ./docs/specs/ivshmem-spec.txt for details. */
+/* Ivshmem registers. See docs/specs/ivshmem-spec.rst for details. */
enum ivshmem_registers {
INTMASK = 0,
INTSTATUS = 4,
diff --git a/tests/qtest/vmgenid-test.c b/tests/qtest/vmgenid-test.c
index e613374665..33e96b7c55 100644
--- a/tests/qtest/vmgenid-test.c
+++ b/tests/qtest/vmgenid-test.c
@@ -61,7 +61,7 @@ static uint32_t acpi_find_vgia(QTestState *qts)
/* The GUID is written at a fixed offset into the fw_cfg file
* in order to implement the "OVMF SDT Header probe suppressor"
- * see docs/specs/vmgenid.txt for more details
+ * see docs/specs/vmgenid.rst for more details
*/
guid_offset = le32_to_cpu(vgia_val) + VMGENID_GUID_OFFSET;
g_free(table_aml);
--
2.49.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 5/6] treewide: update docs file extensions (.txt -> .rst) in comments
2025-06-16 15:50 ` [PATCH 5/6] treewide: update docs file extensions (.txt -> .rst) in comments Sean Wei
@ 2025-07-01 17:28 ` Thomas Huth
2025-07-02 5:50 ` Harsh Prateek Bora
1 sibling, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2025-07-01 17:28 UTC (permalink / raw)
To: Sean Wei, qemu-devel
Cc: Michael S. Tsirkin, Igor Mammedov, Ani Sinha, Gustavo Romero,
Nicholas Piggin, Daniel Henrique Barboza, Harsh Prateek Bora,
Fabiano Rosas, Laurent Vivier, Paolo Bonzini,
open list:sPAPR (pseries)
On 16/06/2025 17.50, Sean Wei wrote:
> Several source comments still refer to docs with the old .txt
> extension that were previously converted to reStructuredText.
>
> Update these references to use the correct .rst extensions to
> maintain accurate in-tree documentation pointers.
>
> No functional changes.
>
> Related commits:
> 50f8174c5c1 (Jul 2021): docs/specs/acpi_nvdimm: Convert to rST
> f054eb1c920 (Jul 2021): docs/specs/acpi_pci_hotplug: Convert to rST
> 912fb3678b8 (Sep 2023): docs/specs/vmgenid: Convert to rST
> bb1cff6ee04 (Sep 2023): docs/specs/ivshmem-spec: Convert to rST
> 55ff468f781 (Jan 2022): docs: Rename ppc-spapr-hotplug.txt to .rst
>
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
> hw/acpi/nvdimm.c | 2 +-
> hw/acpi/pcihp.c | 2 +-
> hw/acpi/vmgenid.c | 6 +++---
> hw/misc/ivshmem-flat.c | 2 +-
> hw/ppc/spapr.c | 2 +-
> include/hw/acpi/pcihp.h | 2 +-
> include/hw/misc/ivshmem-flat.h | 2 +-
> tests/qtest/vmgenid-test.c | 2 +-
> 8 files changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5/6] treewide: update docs file extensions (.txt -> .rst) in comments
2025-06-16 15:50 ` [PATCH 5/6] treewide: update docs file extensions (.txt -> .rst) in comments Sean Wei
2025-07-01 17:28 ` Thomas Huth
@ 2025-07-02 5:50 ` Harsh Prateek Bora
1 sibling, 0 replies; 15+ messages in thread
From: Harsh Prateek Bora @ 2025-07-02 5:50 UTC (permalink / raw)
To: Sean Wei, qemu-devel
Cc: Michael S. Tsirkin, Igor Mammedov, Ani Sinha, Gustavo Romero,
Nicholas Piggin, Daniel Henrique Barboza, Fabiano Rosas,
Laurent Vivier, Paolo Bonzini, open list:sPAPR (pseries)
On 6/16/25 21:20, Sean Wei wrote:
> Several source comments still refer to docs with the old .txt
> extension that were previously converted to reStructuredText.
>
> Update these references to use the correct .rst extensions to
> maintain accurate in-tree documentation pointers.
>
> No functional changes.
>
> Related commits:
> 50f8174c5c1 (Jul 2021): docs/specs/acpi_nvdimm: Convert to rST
> f054eb1c920 (Jul 2021): docs/specs/acpi_pci_hotplug: Convert to rST
> 912fb3678b8 (Sep 2023): docs/specs/vmgenid: Convert to rST
> bb1cff6ee04 (Sep 2023): docs/specs/ivshmem-spec: Convert to rST
> 55ff468f781 (Jan 2022): docs: Rename ppc-spapr-hotplug.txt to .rst
>
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
> hw/acpi/nvdimm.c | 2 +-
> hw/acpi/pcihp.c | 2 +-
> hw/acpi/vmgenid.c | 6 +++---
> hw/misc/ivshmem-flat.c | 2 +-
> hw/ppc/spapr.c | 2 +-
> include/hw/acpi/pcihp.h | 2 +-
> include/hw/misc/ivshmem-flat.h | 2 +-
> tests/qtest/vmgenid-test.c | 2 +-
> 8 files changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
>
> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> index 9ba90806f2..732d613ac0 100644
> --- a/hw/acpi/nvdimm.c
> +++ b/hw/acpi/nvdimm.c
> @@ -535,7 +535,7 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr dsm_mem_addr)
>
> #define NVDIMM_QEMU_RSVD_HANDLE_ROOT 0x10000
>
> -/* Read FIT data, defined in docs/specs/acpi_nvdimm.txt. */
> +/* Read FIT data, defined in docs/specs/acpi_nvdimm.rst. */
> static void nvdimm_dsm_func_read_fit(NVDIMMState *state, NvdimmDsmIn *in,
> hwaddr dsm_mem_addr)
> {
> diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
> index aac90013d4..497281ae20 100644
> --- a/hw/acpi/pcihp.c
> +++ b/hw/acpi/pcihp.c
> @@ -3,7 +3,7 @@
> *
> * QEMU supports PCI hotplug via ACPI. This module
> * implements the interface between QEMU and the ACPI BIOS.
> - * Interface specification - see docs/specs/acpi_pci_hotplug.txt
> + * Interface specification - see docs/specs/acpi_pci_hotplug.rst
> *
> * Copyright (c) 2013, Red Hat Inc, Michael S. Tsirkin (mst@redhat.com)
> * Copyright (c) 2006 Fabrice Bellard
> diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
> index fac3d6d97e..33c35c85dd 100644
> --- a/hw/acpi/vmgenid.c
> +++ b/hw/acpi/vmgenid.c
> @@ -38,7 +38,7 @@ void vmgenid_build_acpi(VmGenIdState *vms, GArray *table_data, GArray *guid,
> guid_le = qemu_uuid_bswap(vms->guid);
> /* The GUID is written at a fixed offset into the fw_cfg file
> * in order to implement the "OVMF SDT Header probe suppressor"
> - * see docs/specs/vmgenid.txt for more details
> + * see docs/specs/vmgenid.rst for more details
> */
> g_array_insert_vals(guid, VMGENID_GUID_OFFSET, guid_le.data,
> ARRAY_SIZE(guid_le.data));
> @@ -101,7 +101,7 @@ void vmgenid_build_acpi(VmGenIdState *vms, GArray *table_data, GArray *guid,
> * < 4GB, but write 64 bits anyway.
> * The address that is patched in is offset in order to implement
> * the "OVMF SDT Header probe suppressor"
> - * see docs/specs/vmgenid.txt for more details.
> + * see docs/specs/vmgenid.rst for more details.
> */
> bios_linker_loader_write_pointer(linker,
> VMGENID_ADDR_FW_CFG_FILE, 0, sizeof(uint64_t),
> @@ -153,7 +153,7 @@ static void vmgenid_update_guest(VmGenIdState *vms)
> guid_le = qemu_uuid_bswap(vms->guid);
> /* The GUID is written at a fixed offset into the fw_cfg file
> * in order to implement the "OVMF SDT Header probe suppressor"
> - * see docs/specs/vmgenid.txt for more details.
> + * see docs/specs/vmgenid.rst for more details.
> */
> cpu_physical_memory_write(vmgenid_addr, guid_le.data,
> sizeof(guid_le.data));
> diff --git a/hw/misc/ivshmem-flat.c b/hw/misc/ivshmem-flat.c
> index be28c24d73..fe4be6be17 100644
> --- a/hw/misc/ivshmem-flat.c
> +++ b/hw/misc/ivshmem-flat.c
> @@ -362,7 +362,7 @@ static bool ivshmem_flat_connect_server(DeviceState *dev, Error **errp)
> *
> * ivshmem_flat_recv_msg() calls return 'msg' and 'fd'.
> *
> - * See ./docs/specs/ivshmem-spec.txt for details on the protocol.
> + * See docs/specs/ivshmem-spec.rst for details on the protocol.
> */
>
> /* Step 0 */
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 702f774cda..08615f6c90 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -577,7 +577,7 @@ static int spapr_dt_dynamic_memory(SpaprMachineState *spapr, void *fdt,
>
> /*
> * Adds ibm,dynamic-reconfiguration-memory node.
> - * Refer to docs/specs/ppc-spapr-hotplug.txt for the documentation
> + * Refer to docs/specs/ppc-spapr-hotplug.rst for the documentation
> * of this device tree node.
> */
> static int spapr_dt_dynamic_reconfiguration_memory(SpaprMachineState *spapr,
> diff --git a/include/hw/acpi/pcihp.h b/include/hw/acpi/pcihp.h
> index a97904bada..cdc0cb8e43 100644
> --- a/include/hw/acpi/pcihp.h
> +++ b/include/hw/acpi/pcihp.h
> @@ -3,7 +3,7 @@
> *
> * QEMU supports PCI hotplug via ACPI. This module
> * implements the interface between QEMU and the ACPI BIOS.
> - * Interface specification - see docs/specs/acpi_pci_hotplug.txt
> + * Interface specification - see docs/specs/acpi_pci_hotplug.rst
> *
> * Copyright (c) 2013, Red Hat Inc, Michael S. Tsirkin (mst@redhat.com)
> * Copyright (c) 2006 Fabrice Bellard
> diff --git a/include/hw/misc/ivshmem-flat.h b/include/hw/misc/ivshmem-flat.h
> index 09bc3abcad..3eca99004e 100644
> --- a/include/hw/misc/ivshmem-flat.h
> +++ b/include/hw/misc/ivshmem-flat.h
> @@ -36,7 +36,7 @@ typedef struct IvshmemFTState IvshmemFTState;
>
> DECLARE_INSTANCE_CHECKER(IvshmemFTState, IVSHMEM_FLAT, TYPE_IVSHMEM_FLAT)
>
> -/* Ivshmem registers. See ./docs/specs/ivshmem-spec.txt for details. */
> +/* Ivshmem registers. See docs/specs/ivshmem-spec.rst for details. */
> enum ivshmem_registers {
> INTMASK = 0,
> INTSTATUS = 4,
> diff --git a/tests/qtest/vmgenid-test.c b/tests/qtest/vmgenid-test.c
> index e613374665..33e96b7c55 100644
> --- a/tests/qtest/vmgenid-test.c
> +++ b/tests/qtest/vmgenid-test.c
> @@ -61,7 +61,7 @@ static uint32_t acpi_find_vgia(QTestState *qts)
>
> /* The GUID is written at a fixed offset into the fw_cfg file
> * in order to implement the "OVMF SDT Header probe suppressor"
> - * see docs/specs/vmgenid.txt for more details
> + * see docs/specs/vmgenid.rst for more details
> */
> guid_offset = le32_to_cpu(vgia_val) + VMGENID_GUID_OFFSET;
> g_free(table_aml);
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 6/6] treewide: fix paths for relocated files in comments
2025-06-16 15:46 [PATCH 0/6] Fix paths for relocated files Sean Wei
` (4 preceding siblings ...)
2025-06-16 15:50 ` [PATCH 5/6] treewide: update docs file extensions (.txt -> .rst) in comments Sean Wei
@ 2025-06-16 15:51 ` Sean Wei
2025-07-01 17:32 ` Thomas Huth
5 siblings, 1 reply; 15+ messages in thread
From: Sean Wei @ 2025-06-16 15:51 UTC (permalink / raw)
To: qemu-devel
Cc: Sean Wei, Keith Busch, Klaus Jensen, Jesper Devantier,
Peter Maydell, Song Gao, open list:nvme, open list:ARM TCG CPUs
After the docs directory restructuring, several comments
refer to paths that no longer exist.
Replace these references to the current file locations
so readers can find the correct files.
Related commits
---------------
189c099f75f (Jul 2021)
docs: collect the disparate device emulation docs into one section
Rename docs/system/{ => devices}/nvme.rst
5f4c96b779f (Feb 2023)
docs/system/loongarch: update loongson3.rst and rename it to virt.rst
Rename docs/system/loongarch/{loongson3.rst => virt.rst}
fe0007f3c1d (Sep 2023)
exec: Rename cpu.c -> cpu-target.c
Rename cpus-common.c => cpu-common.c
42fa9665e59 (Apr 2025)
exec: Restrict 'cpu_ldst.h' to accel/tcg/
Rename include/{exec/cpu_ldst.h => accel/tcg/cpu-ldst.h}
Signed-off-by: Sean Wei <me@sean.taipei>
---
docs/spin/tcg-exclusive.promela | 4 ++--
hw/nvme/ctrl.c | 2 +-
target/arm/cpu.c | 2 +-
target/loongarch/README | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/spin/tcg-exclusive.promela b/docs/spin/tcg-exclusive.promela
index c91cfca9f7..1d03af850b 100644
--- a/docs/spin/tcg-exclusive.promela
+++ b/docs/spin/tcg-exclusive.promela
@@ -1,6 +1,6 @@
/*
* This model describes the implementation of exclusive sections in
- * cpus-common.c (start_exclusive, end_exclusive, cpu_exec_start,
+ * cpu-common.c (start_exclusive, end_exclusive, cpu_exec_start,
* cpu_exec_end).
*
* Author: Paolo Bonzini <pbonzini@redhat.com>
@@ -65,7 +65,7 @@
}
#define COND_BROADCAST(c) c++
-// this is the logic from cpus-common.c
+// this is the logic from cpu-common.c
mutex_t mutex;
cond_t exclusive_cond;
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index fd935507bc..5810bfbe7a 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -22,7 +22,7 @@
*
* Usage
* -----
- * See docs/system/nvme.rst for extensive documentation.
+ * See docs/system/devices/nvme.rst for extensive documentation.
*
* Add options:
* -drive file=<file>,if=none,id=<drive_id>
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index e025e241ed..90cf924938 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -2672,7 +2672,7 @@ static const char *arm_gdb_get_core_xml_file(CPUState *cs)
* linux syscall TIF_TAGGED_ADDR setting, not TBI in general.
*
* There should be a better place to put this, but we need this in
- * include/exec/cpu_ldst.h, and not some place linux-user specific.
+ * include/accel/tcg/cpu-ldst.h, and not some place linux-user specific.
*
* Note that arm-*-user will never set tagged_addr_enable.
*/
diff --git a/target/loongarch/README b/target/loongarch/README
index 0b9dc0d40a..1ffd3422d2 100644
--- a/target/loongarch/README
+++ b/target/loongarch/README
@@ -11,7 +11,7 @@
- System emulation
- You can reference docs/system/loongarch/loongson3.rst to get the information about system emulation of LoongArch.
+ You can reference docs/system/loongarch/virt.rst to get the information about system emulation of LoongArch.
- Linux-user emulation
--
2.49.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 6/6] treewide: fix paths for relocated files in comments
2025-06-16 15:51 ` [PATCH 6/6] treewide: fix paths for relocated files " Sean Wei
@ 2025-07-01 17:32 ` Thomas Huth
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2025-07-01 17:32 UTC (permalink / raw)
To: Sean Wei, qemu-devel
Cc: Keith Busch, Klaus Jensen, Jesper Devantier, Peter Maydell,
Song Gao, open list:nvme, open list:ARM TCG CPUs
On 16/06/2025 17.51, Sean Wei wrote:
> After the docs directory restructuring, several comments
> refer to paths that no longer exist.
>
> Replace these references to the current file locations
> so readers can find the correct files.
>
> Related commits
> ---------------
>
> 189c099f75f (Jul 2021)
> docs: collect the disparate device emulation docs into one section
> Rename docs/system/{ => devices}/nvme.rst
>
> 5f4c96b779f (Feb 2023)
> docs/system/loongarch: update loongson3.rst and rename it to virt.rst
> Rename docs/system/loongarch/{loongson3.rst => virt.rst}
>
> fe0007f3c1d (Sep 2023)
> exec: Rename cpu.c -> cpu-target.c
> Rename cpus-common.c => cpu-common.c
>
> 42fa9665e59 (Apr 2025)
> exec: Restrict 'cpu_ldst.h' to accel/tcg/
> Rename include/{exec/cpu_ldst.h => accel/tcg/cpu-ldst.h}
>
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
> docs/spin/tcg-exclusive.promela | 4 ++--
> hw/nvme/ctrl.c | 2 +-
> target/arm/cpu.c | 2 +-
> target/loongarch/README | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 15+ messages in thread