From: BALATON Zoltan <balaton@eik.bme.hu>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
qemu-ppc@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH 6/6] hw/loader: Pass ELFDATA endian order argument to load_elf()
Date: Mon, 27 Jan 2025 14:23:19 +0100 (CET) [thread overview]
Message-ID: <cf92f7c0-9fc5-0b55-d14e-b4d9fd64d553@eik.bme.hu> (raw)
In-Reply-To: <20250127113824.50177-7-philmd@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]
On Mon, 27 Jan 2025, Philippe Mathieu-Daudé wrote:
> Rather than passing a boolean 'is_big_endian' argument,
> directly pass the ELFDATA, which can be unspecified using
> the ELFDATANONE value.
>
> Update the call sites:
> 0 -> ELFDATA2LSB
> 1 -> ELFDATA2MSB
> TARGET_BIG_ENDIAN -> TARGET_BIG_ENDIAN ? ELFDATA2MSB : ELFDATA2LSB
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> Sorry, couldn't find good ways to split this patch...
> ---
> include/hw/loader.h | 2 +-
> hw/core/loader.c | 5 ++---
> hw/alpha/dp264.c | 4 ++--
> hw/hppa/machine.c | 4 ++--
> hw/i386/multiboot.c | 4 ++--
> hw/i386/x86-common.c | 4 ++--
> hw/loongarch/boot.c | 2 +-
> hw/m68k/an5206.c | 2 +-
> hw/m68k/mcf5208.c | 2 +-
> hw/m68k/q800.c | 2 +-
> hw/m68k/virt.c | 2 +-
> hw/microblaze/boot.c | 6 ++++--
> hw/mips/boston.c | 2 +-
> hw/mips/fuloong2e.c | 2 +-
> hw/mips/loongson3_virt.c | 2 +-
> hw/mips/malta.c | 5 +++--
> hw/mips/mipssim.c | 3 ++-
> hw/openrisc/boot.c | 2 +-
> hw/pci-host/raven.c | 4 ++--
> hw/ppc/e500.c | 2 +-
> hw/ppc/mac_newworld.c | 5 +++--
> hw/ppc/mac_oldworld.c | 4 ++--
> hw/ppc/pegasos2.c | 8 ++++----
> hw/ppc/ppc405_boards.c | 2 +-
> hw/ppc/ppc440_bamboo.c | 3 ++-
> hw/ppc/sam460ex.c | 2 +-
> hw/ppc/spapr.c | 8 ++++----
> hw/ppc/virtex_ml507.c | 4 ++--
> hw/s390x/ipl.c | 6 +++---
> hw/sparc/leon3.c | 2 +-
> hw/sparc/sun4m.c | 5 +++--
> hw/sparc64/sun4u.c | 6 +++---
> hw/tricore/triboard.c | 2 +-
> hw/tricore/tricore_testboard.c | 2 +-
> hw/xtensa/sim.c | 3 ++-
> hw/xtensa/xtfpga.c | 3 ++-
> 36 files changed, 67 insertions(+), 59 deletions(-)
next prev parent reply other threads:[~2025-01-27 13:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 11:38 [PATCH 0/6] hw/loader: Pass ELFDATA endian order argument to load_elf() Philippe Mathieu-Daudé
2025-01-27 11:38 ` [PATCH 1/6] hw/avr/boot: Replace load_elf_ram_sym() -> load_elf_as() Philippe Mathieu-Daudé
2025-01-27 21:11 ` Richard Henderson
2025-01-27 11:38 ` [PATCH 2/6] hw/loader: Remove unused load_elf_ram() Philippe Mathieu-Daudé
2025-01-27 21:12 ` Richard Henderson
2025-01-28 2:14 ` Alistair Francis
2025-01-27 11:38 ` [PATCH 3/6] hw/loader: Clarify local variable name in load_elf_ram_sym() Philippe Mathieu-Daudé
2025-01-27 13:00 ` BALATON Zoltan
2025-01-27 21:13 ` Richard Henderson
2025-01-27 21:16 ` Richard Henderson
2025-01-27 11:38 ` [PATCH 4/6] hw/loader: Pass ELFDATA endian order argument to load_elf_ram_sym() Philippe Mathieu-Daudé
2025-01-27 21:22 ` Richard Henderson
2025-01-27 11:38 ` [PATCH 5/6] hw/loader: Pass ELFDATA endian order argument to load_elf_as() Philippe Mathieu-Daudé
2025-01-27 21:26 ` Richard Henderson
2025-01-27 11:38 ` [PATCH 6/6] hw/loader: Pass ELFDATA endian order argument to load_elf() Philippe Mathieu-Daudé
2025-01-27 13:23 ` BALATON Zoltan [this message]
2025-01-27 21:34 ` Richard Henderson
2025-01-30 21:40 ` [PATCH 0/6] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf92f7c0-9fc5-0b55-d14e-b4d9fd64d553@eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).