Re: [PATCH v4] target/i386: Add notes for versioned CPU models

[Tao Xu <tao3.xu@intel.com>]

Hi Eduardo

Could you review this patch?

Tao Xu

On 3/24/2020 1:10 PM, Xu, Tao3 wrote:
> Add which features are added or removed in this version.
> 
> Signed-off-by: Tao Xu <tao3.xu@intel.com>
> ---
> 
> The output is as follows:
> qemu-system-x86_64 -cpu help | grep "\["
> x86 Cascadelake-Server-v2  Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES]
> x86 Cascadelake-Server-v3  Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES, no TSX]
> x86 Denverton-v2          Intel Atom Processor (Denverton) [no MPX, no MONITOR]
> x86 Icelake-Client-v2     Intel Core Processor (Icelake) [no TSX]
> x86 Icelake-Server-v2     Intel Xeon Processor (Icelake) [no TSX]
> 
> Changes in v3:
>      - Keep the existing custom model-id (Eduardo)
> 
> Changes in v2:
>      - correct the note of Cascadelake v3 (Xiaoyao)
> ---
>   target/i386/cpu.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 34b511f078..1c7690baa0 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -3192,6 +3192,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
>           .versions = (X86CPUVersionDefinition[]) {
>               { .version = 1 },
>               { .version = 2,
> +              .note = "ARCH_CAPABILITIES",
>                 .props = (PropValue[]) {
>                     { "arch-capabilities", "on" },
>                     { "rdctl-no", "on" },
> @@ -3203,6 +3204,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
>               },
>               { .version = 3,
>                 .alias = "Cascadelake-Server-noTSX",
> +              .note = "ARCH_CAPABILITIES, no TSX",
>                 .props = (PropValue[]) {
>                     { "hle", "off" },
>                     { "rtm", "off" },
> @@ -3424,6 +3426,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
>               { .version = 1 },
>               {
>                   .version = 2,
> +                .note = "no TSX",
>                   .alias = "Icelake-Client-noTSX",
>                   .props = (PropValue[]) {
>                       { "hle", "off" },
> @@ -3541,6 +3544,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
>               { .version = 1 },
>               {
>                   .version = 2,
> +                .note = "no TSX",
>                   .alias = "Icelake-Server-noTSX",
>                   .props = (PropValue[]) {
>                       { "hle", "off" },
> @@ -3648,6 +3652,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
>               { .version = 1 },
>               {
>                   .version = 2,
> +                .note = "no MPX, no MONITOR",
>                   .props = (PropValue[]) {
>                       { "monitor", "off" },
>                       { "mpx", "off" },
>