* Expose support for HyperV features via QMP @ 2023-01-31 14:47 manish.mishra 2023-02-01 10:42 ` manish.mishra 2023-02-09 10:50 ` manish.mishra 0 siblings, 2 replies; 6+ messages in thread From: manish.mishra @ 2023-01-31 14:47 UTC (permalink / raw) To: qemu-devel Cc: John Levon, Florian Schmidt, carl.waldspurger, Prerna Saxena, Aravind Retnakaran, rohit.kumar3, Daniel P . Berrange [-- Attachment #1: Type: text/plain, Size: 779 bytes --] Hi Everyone, I hope everyone is doing great. We wanted to check why we do not expose support for HyperV features in Qemu similar to what we do for normal CPU features via query-cpu-defs or cpu-model-expansion QMP commands. This support is required for live migration with HyperV features as hyperv passthrough is not an option. If users had knowledge of what features are supported by source and destination, VM can be started with an intersection of features supported by both source and destination. If there is no specific reason for not doing this, does it make sense to add a new QMP which expose support (internally also validating with KVM or KVM_GET_SUPPORTED_HV_CPUID ioctl) for HyperV features. Apologies in advance if i misunderstood something. Thanks Manish Mishra [-- Attachment #2: Type: text/html, Size: 1127 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Expose support for HyperV features via QMP 2023-01-31 14:47 Expose support for HyperV features via QMP manish.mishra @ 2023-02-01 10:42 ` manish.mishra 2023-02-09 10:50 ` manish.mishra 1 sibling, 0 replies; 6+ messages in thread From: manish.mishra @ 2023-02-01 10:42 UTC (permalink / raw) To: qemu-devel Cc: John Levon, Florian Schmidt, carl.waldspurger, Prerna Saxena, Aravind Retnakaran, rohit.kumar3, Daniel P . Berrange [-- Attachment #1: Type: text/plain, Size: 921 bytes --] On 31/01/23 8:17 pm, manish.mishra wrote: > > Hi Everyone, > I hope everyone is doing great. We wanted to check why we do not expose support for HyperV features in Qemu similar to what we do for normal CPU features via query-cpu-defs or cpu-model-expansion QMP commands. This support is required for live migration with HyperV features as hyperv passthrough is not an option. If users had knowledge of what features are supported by source and destination, VM can be started with an intersection of features supported by both source and destination. > If there is no specific reason for not doing this, does it make sense to add a new QMP which expose support (internally also validating with KVM or KVM_GET_SUPPORTED_HV_CPUID ioctl) for HyperV features. > Apologies in advance if i misunderstood something. > > Thanks > > Manish Mishra > Hi Everyone, Checking if there is any feedback on this. Thanks Manish Mishra [-- Attachment #2: Type: text/html, Size: 1545 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Expose support for HyperV features via QMP 2023-01-31 14:47 Expose support for HyperV features via QMP manish.mishra 2023-02-01 10:42 ` manish.mishra @ 2023-02-09 10:50 ` manish.mishra 2023-02-09 13:58 ` Alex Bennée 1 sibling, 1 reply; 6+ messages in thread From: manish.mishra @ 2023-02-09 10:50 UTC (permalink / raw) To: qemu-devel Cc: John Levon, Florian Schmidt, carl.waldspurger, Prerna Saxena, Aravind Retnakaran, rohit.kumar3, Daniel P . Berrange [-- Attachment #1: Type: text/plain, Size: 920 bytes --] Hi Everyone, Checking if there is any feedback on this. Thanks Manish Mishra On 31/01/23 8:17 pm, manish.mishra wrote: > > Hi Everyone, > I hope everyone is doing great. We wanted to check why we do not expose support for HyperV features in Qemu similar to what we do for normal CPU features via query-cpu-defs or cpu-model-expansion QMP commands. This support is required for live migration with HyperV features as hyperv passthrough is not an option. If users had knowledge of what features are supported by source and destination, VM can be started with an intersection of features supported by both source and destination. > If there is no specific reason for not doing this, does it make sense to add a new QMP which expose support (internally also validating with KVM or KVM_GET_SUPPORTED_HV_CPUID ioctl) for HyperV features. > Apologies in advance if i misunderstood something. > > Thanks > > Manish Mishra > [-- Attachment #2: Type: text/html, Size: 1999 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Expose support for HyperV features via QMP 2023-02-09 10:50 ` manish.mishra @ 2023-02-09 13:58 ` Alex Bennée 2023-02-09 14:17 ` Vitaly Kuznetsov 0 siblings, 1 reply; 6+ messages in thread From: Alex Bennée @ 2023-02-09 13:58 UTC (permalink / raw) To: manish.mishra Cc: John Levon, Florian Schmidt, carl.waldspurger, Prerna Saxena, Aravind Retnakaran, rohit.kumar3, Daniel P . Berrange, qemu-devel, Juan Quintela, Dr. David Alan Gilbert, Maciej S. Szmigiero, Sunil Muthuswamy, Paolo Bonzini, Justin Terry, Vitaly Kuznetsov "manish.mishra" <manish.mishra@nutanix.com> writes: > Hi Everyone, > > Checking if there is any feedback on this. I've expanded the CC list to some relevant maintainers and people who have touched that code in case this was missed. > Thanks > > Manish Mishra > > On 31/01/23 8:17 pm, manish.mishra wrote: > > Hi Everyone, > I hope everyone is doing great. We wanted to check why we do not expose support for HyperV features in > Qemu similar to what we do for normal CPU features via query-cpu-defs or cpu-model-expansion QMP > commands. This support is required for live migration with HyperV features as hyperv passthrough is not > an option. If users had knowledge of what features are supported by source and destination, VM can be > started with an intersection of features supported by both source and destination. > If there is no specific reason for not doing this, does it make sense to add a new QMP which expose > support (internally also validating with KVM or KVM_GET_SUPPORTED_HV_CPUID ioctl) for HyperV > features. > Apologies in advance if i misunderstood something. > > Thanks > > Manish Mishra -- Alex Bennée Virtualisation Tech Lead @ Linaro ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Expose support for HyperV features via QMP 2023-02-09 13:58 ` Alex Bennée @ 2023-02-09 14:17 ` Vitaly Kuznetsov 2023-02-10 8:42 ` manish.mishra 0 siblings, 1 reply; 6+ messages in thread From: Vitaly Kuznetsov @ 2023-02-09 14:17 UTC (permalink / raw) To: manish.mishra Cc: John Levon, Florian Schmidt, carl.waldspurger, Prerna Saxena, Aravind Retnakaran, rohit.kumar3, Daniel P. Berrange, qemu-devel, Juan Quintela, Dr. David Alan Gilbert, Maciej S. Szmigiero, Sunil Muthuswamy, Paolo Bonzini, Justin Terry, Alex Bennée Alex Bennée <alex.bennee@linaro.org> writes: > "manish.mishra" <manish.mishra@nutanix.com> writes: > >> Hi Everyone, >> >> Checking if there is any feedback on this. > > I've expanded the CC list to some relevant maintainers and people who > have touched that code in case this was missed. > >> Thanks >> >> Manish Mishra >> >> On 31/01/23 8:17 pm, manish.mishra wrote: >> >> Hi Everyone, >> I hope everyone is doing great. We wanted to check why we do not expose support for HyperV features in >> Qemu similar to what we do for normal CPU features via query-cpu-defs or cpu-model-expansion QMP >> commands. This support is required for live migration with HyperV features as hyperv passthrough is not >> an option. If users had knowledge of what features are supported by source and destination, VM can be >> started with an intersection of features supported by both source and destination. >> If there is no specific reason for not doing this, does it make sense to add a new QMP which expose >> support (internally also validating with KVM or KVM_GET_SUPPORTED_HV_CPUID ioctl) for HyperV >> features. >> Apologies in advance if i misunderstood something. >> Thanks for Ccing me. Hyper-V features should appear in QMP since commit 071ce4b03becf9e2df6b758fde9609be8ddf56f1 Author: Vitaly Kuznetsov <vkuznets@redhat.com> Date: Tue Jun 8 14:08:13 2021 +0200 i386: expand Hyper-V features during CPU feature expansion time also, the support for Hypre-V feature discovery was just added to libvirt: 903ea9370d qemu_capabilities: Report Hyper-V Enlightenments in domcapabilities 10f4784864 qemu_capabilities: Query for Hyper-V Enlightenments ff8731680b qemuMonitorJSONGetCPUModelExpansion: Introduce @hv_passthrough argument 7c12eb2397 qemuMonitorJSONMakeCPUModel: Introduce @hv_passthrough argument 7c1ecfd512 domain_capabilities: Expose Hyper-V Enlightenments 179e45d237 virDomainCapsEnumFormat: Retrun void a7789d9324 virDomainCapsEnumFormat: Switch to virXMLFormatElement() in case this is not enough, could you please elaborate on the use-case you have in mind? -- Vitaly ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Expose support for HyperV features via QMP 2023-02-09 14:17 ` Vitaly Kuznetsov @ 2023-02-10 8:42 ` manish.mishra 0 siblings, 0 replies; 6+ messages in thread From: manish.mishra @ 2023-02-10 8:42 UTC (permalink / raw) To: Vitaly Kuznetsov Cc: John Levon, Florian Schmidt, carl.waldspurger, Prerna Saxena, Aravind Retnakaran, rohit.kumar3, Daniel P. Berrange, qemu-devel, Juan Quintela, Dr. David Alan Gilbert, Maciej S. Szmigiero, Sunil Muthuswamy, Paolo Bonzini, Justin Terry, Alex Bennée On 09/02/23 7:47 pm, Vitaly Kuznetsov wrote: > Alex Bennée <alex.bennee@linaro.org> writes: > >> "manish.mishra" <manish.mishra@nutanix.com> writes: >> >>> Hi Everyone, >>> >>> Checking if there is any feedback on this. >> I've expanded the CC list to some relevant maintainers and people who >> have touched that code in case this was missed. >> >>> Thanks >>> >>> Manish Mishra >>> >>> On 31/01/23 8:17 pm, manish.mishra wrote: >>> >>> Hi Everyone, >>> I hope everyone is doing great. We wanted to check why we do not expose support for HyperV features in >>> Qemu similar to what we do for normal CPU features via query-cpu-defs or cpu-model-expansion QMP >>> commands. This support is required for live migration with HyperV features as hyperv passthrough is not >>> an option. If users had knowledge of what features are supported by source and destination, VM can be >>> started with an intersection of features supported by both source and destination. >>> If there is no specific reason for not doing this, does it make sense to add a new QMP which expose >>> support (internally also validating with KVM or KVM_GET_SUPPORTED_HV_CPUID ioctl) for HyperV >>> features. >>> Apologies in advance if i misunderstood something. >>> > Thanks for Ccing me. > > Hyper-V features should appear in QMP since > > commit 071ce4b03becf9e2df6b758fde9609be8ddf56f1 > Author: Vitaly Kuznetsov <vkuznets@redhat.com> > Date: Tue Jun 8 14:08:13 2021 +0200 > > i386: expand Hyper-V features during CPU feature expansion time > > also, the support for Hypre-V feature discovery was just added to > libvirt: > > 903ea9370d qemu_capabilities: Report Hyper-V Enlightenments in domcapabilities > 10f4784864 qemu_capabilities: Query for Hyper-V Enlightenments > ff8731680b qemuMonitorJSONGetCPUModelExpansion: Introduce @hv_passthrough argument > 7c12eb2397 qemuMonitorJSONMakeCPUModel: Introduce @hv_passthrough argument > 7c1ecfd512 domain_capabilities: Expose Hyper-V Enlightenments > 179e45d237 virDomainCapsEnumFormat: Retrun void > a7789d9324 virDomainCapsEnumFormat: Switch to virXMLFormatElement() > > in case this is not enough, could you please elaborate on the use-case > you have in mind? > Thanks Vitaly, Alex, Yes this should work. Sorry I checked qemu master code but not sure how i missed this :). Thanks Manish Mishra ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-10 8:44 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-01-31 14:47 Expose support for HyperV features via QMP manish.mishra 2023-02-01 10:42 ` manish.mishra 2023-02-09 10:50 ` manish.mishra 2023-02-09 13:58 ` Alex Bennée 2023-02-09 14:17 ` Vitaly Kuznetsov 2023-02-10 8:42 ` manish.mishra
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).