From: Richard Henderson <richard.henderson@linaro.org>
To: Max Filippov <jcmvbkbc@gmail.com>, Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, qemu-arm <qemu-arm@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation
Date: Wed, 14 Apr 2021 12:43:04 -0700 [thread overview]
Message-ID: <cfae4bbd-3068-41f6-ec38-a27cf7381fee@linaro.org> (raw)
In-Reply-To: <CAMo8Bf+s4OqYJLTkvyPvfnmH=FwxDSFn60TryKfgErxFyB+2yQ@mail.gmail.com>
On 4/14/21 11:03 AM, Max Filippov wrote:
> On Wed, Apr 14, 2021 at 9:51 AM Ilya Leoshkevich <iii@linux.ibm.com> wrote:
>> On Wed, 2021-04-14 at 16:48 +0200, David Hildenbrand wrote:
>>> Did you double-check the xtensa issue?
>>
>> Oh, I'm sorry, I completely forgot about that one. I just ran the
>> test locally, and apparently it fails because of this new assert, so
>> I'll have to write the 4th patch now. Thanks!
>
> Just curious, what xtensa issue?
Returning from xtensa_tr_translate_insn with tb->size == 0.
Basically, dc->base.pc_next needs to be incremented even for illegal
instructions, preferably by the number of bytes consumed while determining that
the insn is illegal.
r~
next prev parent reply other threads:[~2021-04-14 19:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 13:41 [PATCH v3 0/3] accel/tcg: Make sure that tb->size != 0 after translation Ilya Leoshkevich
2021-04-14 13:41 ` [PATCH v3 1/3] target/s390x: Fix translation exception on illegal instruction Ilya Leoshkevich
2021-04-14 14:47 ` David Hildenbrand
2021-04-14 13:41 ` [PATCH v3 2/3] target/arm: Make sure that commpage's tb->size != 0 Ilya Leoshkevich
2021-04-14 13:41 ` [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation Ilya Leoshkevich
2021-04-14 14:48 ` David Hildenbrand
2021-04-14 16:45 ` Ilya Leoshkevich
2021-04-14 18:03 ` Max Filippov
2021-04-14 19:43 ` Richard Henderson [this message]
2021-04-15 1:23 ` Max Filippov
2021-04-15 11:14 ` Ilya Leoshkevich
2021-04-15 14:33 ` Richard Henderson
2021-04-15 15:02 ` Peter Maydell
2021-04-15 20:20 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfae4bbd-3068-41f6-ec38-a27cf7381fee@linaro.org \
--to=richard.henderson@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).