From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9237C433B4 for ; Wed, 14 Apr 2021 19:44:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7478D61166 for ; Wed, 14 Apr 2021 19:44:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7478D61166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWlR9-0001zl-8S for qemu-devel@archiver.kernel.org; Wed, 14 Apr 2021 15:44:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWlPr-0001Ob-IF for qemu-devel@nongnu.org; Wed, 14 Apr 2021 15:43:11 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:43563) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWlPo-00013G-N1 for qemu-devel@nongnu.org; Wed, 14 Apr 2021 15:43:11 -0400 Received: by mail-pj1-x1030.google.com with SMTP id x21-20020a17090a5315b029012c4a622e4aso11377264pjh.2 for ; Wed, 14 Apr 2021 12:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eNA2Ob+heu1g2KPcoi5xolm6BDBRd/FEA1b2k9xu/jM=; b=zJqkzJ3KfU+TUbsjdcmrTfuZHi2yFkhRen4DlKZvh7fq92D7ycSzyxSGrsY+0aeTcG +/XvKOUrhM8jz0wr/CHIft1sjlOr+Xxxs7hxqMXc5B4HixVtD/ofjUcqnYIEQPfb1QOq gt/keos83cIzI2s0kUDWnIyO9Y9oY1HzlyLP7k6NStpEO3bo+LHVwbN4eJLpLFQme0/9 8vmjSa5hZ9KWPnBeRlZUF0iQS1GEmQQ+eirlvCiKxG0fGcI+dY9CQ48uahrO4faW6TFX TopRNtSMB7CeDMhFkN6plxDGM5NvX9bR8QPgC4U6MehzjcCmCReU/trQLdYxdHonIwYy fFwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eNA2Ob+heu1g2KPcoi5xolm6BDBRd/FEA1b2k9xu/jM=; b=l/KKQsrCDYvOGqnGhaYXKULnSG4rxF0jtAdo7BSRj4pn5K/gW6XgkiHGI8hmtN7qM1 A+Pq15Aw0FHU5yusRwHCUuNbn9w0dwIc7iiio+VGexvA3Slr5+7AQnLZhK5c+SNrZtjO NeKRg7gU0hpUZYmqRRDMHILGjIia/jZJchIsuH4GF+ExWaPDn7iW6iDj7nInCWTfMcjw aSHw9hDUZox3RX+LF0iXewsCmTPpzqkhPXD3VEyIboBab62Z80e6t68ot/rpJIxgGABR 7YukA0v3OzRqVGXOR6NCxgZTeMOwWJQBewzisQDEgr198zIa9WrTQOLQmRF5mgzit8a+ GuJQ== X-Gm-Message-State: AOAM530nw2UwfTtlciCKU4UUFUHk833Cs7R8HnboLCO9KXmpNT+xtEFY jxaxqURiuZ8WwfWnsbHYhRLUjPNfaUy2BQ== X-Google-Smtp-Source: ABdhPJzaFSY6RvtlxoPe2DLd5XAY8SmB1IMaQgwdVfHaKk7I15e1Ra2qQ5BwX2jAi+WcmSy0nBAx2A== X-Received: by 2002:a17:90a:ec03:: with SMTP id l3mr3341927pjy.61.1618429387138; Wed, 14 Apr 2021 12:43:07 -0700 (PDT) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id b14sm194491pft.211.2021.04.14.12.43.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Apr 2021 12:43:06 -0700 (PDT) Subject: Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation To: Max Filippov , Ilya Leoshkevich References: <20210414134112.25620-1-iii@linux.ibm.com> <20210414134112.25620-4-iii@linux.ibm.com> <28224ba9d61d0d805a162c00903559f3b99bc722.camel@linux.ibm.com> From: Richard Henderson Message-ID: Date: Wed, 14 Apr 2021 12:43:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , David Hildenbrand , Cornelia Huck , qemu-devel , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-arm , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/14/21 11:03 AM, Max Filippov wrote: > On Wed, Apr 14, 2021 at 9:51 AM Ilya Leoshkevich wrote: >> On Wed, 2021-04-14 at 16:48 +0200, David Hildenbrand wrote: >>> Did you double-check the xtensa issue? >> >> Oh, I'm sorry, I completely forgot about that one. I just ran the >> test locally, and apparently it fails because of this new assert, so >> I'll have to write the 4th patch now. Thanks! > > Just curious, what xtensa issue? Returning from xtensa_tr_translate_insn with tb->size == 0. Basically, dc->base.pc_next needs to be incremented even for illegal instructions, preferably by the number of bytes consumed while determining that the insn is illegal. r~