From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>,
"Emilio G. Cota" <cota@braap.org>,
"Pavel Dovgalyuk" <dovgaluk@ispras.ru>
Subject: Re: [Qemu-devel] TCG icount interaction with timer deadlines
Date: Thu, 5 Apr 2018 19:07:58 +0200 [thread overview]
Message-ID: <cfb5230b-ec8e-ccb7-788d-0b389a93e128@redhat.com> (raw)
In-Reply-To: <CAFEAcA9PbAr+0U1dJ22fr3+B0-KO3Oy73-mk755rJQtmY_rSKA@mail.gmail.com>
On 05/04/2018 18:01, Peter Maydell wrote:
> * however, if the guest reprograms the clock during the tcg_cpu_exec()
> run, we don't do anything to cause us to stop earlier
Anything that does this from the vCPU thread should be between
gen_icount_start and gen_icount_end. (In fact, it's the entire reason
why cpu_io_recompile exists).
For completeness, if the I/O thread does it, it should (in icount mode
only) kick the running VCPU.
Am I missing something?
Paolo
next prev parent reply other threads:[~2018-04-05 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 16:01 [Qemu-devel] TCG icount interaction with timer deadlines Peter Maydell
2018-04-05 17:07 ` Paolo Bonzini [this message]
2018-04-05 17:35 ` Peter Maydell
2018-04-05 20:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfb5230b-ec8e-ccb7-788d-0b389a93e128@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=dovgaluk@ispras.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).