From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
qemu-devel@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Aleksandar Markovic <amarkovic@wavecomp.com>,
Aleksandar Rikalo <arikalo@wavecomp.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 2/8] hw/input: Add 8042 PS/2 Keyboard Controller to Kconfig
Date: Mon, 11 Mar 2019 07:47:19 +0100 [thread overview]
Message-ID: <cfb987fd-8190-c100-80b9-657c060eb20f@redhat.com> (raw)
In-Reply-To: <20190310235351.1863-3-philmd@redhat.com>
On 11/03/2019 00.53, Philippe Mathieu-Daudé wrote:
> The Intel 8042 chipset also includes some functions unrelated to
> the keyboard, such the A20-Gate.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/input/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/input/Kconfig b/hw/input/Kconfig
> index e2e66f0858..83e4546a28 100644
> --- a/hw/input/Kconfig
> +++ b/hw/input/Kconfig
> @@ -10,6 +10,10 @@ config PCKBD
> default y
> depends on ISA_BUS
>
> +config I8042
> + bool
> + select PCKBD
I fail to see why you need this config switch. There is a "select I8042"
in a later patch, but that's it - you never use this switch to decide
anything (like including a file in the Makefiles or toggle other
switches), so this seems to be just a defunc switch to me. Or do I miss
something?
Thomas
next prev parent reply other threads:[~2019-03-11 6:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 23:53 [Qemu-devel] [PATCH 0/8] Kconfig: Clean up the PIIX southbridge devices Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 1/8] hw/i2c: The ACPI_SMBUS Kconfig depends on ACPI Philippe Mathieu-Daudé
2019-03-11 0:27 ` Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 2/8] hw/input: Add 8042 PS/2 Keyboard Controller to Kconfig Philippe Mathieu-Daudé
2019-03-11 6:47 ` Thomas Huth [this message]
2019-03-11 11:14 ` Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 3/8] hw/southbridge: Add the PIIX chipset " Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 4/8] hw/southbridge: Add the PIIX3 " Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 5/8] hw/southbridge: Cleanup the PIIX4 chipset in Kconfig Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 6/8] hw/southbridge: Add ACPI_PIIX4 to Kconfig Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 7/8] hw/i386: The 'isapc' machine is built around a PIIX3 southbridge Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 8/8] hw/i386: Move ACPI_SMBUS out of I440FX (Kconfig) Philippe Mathieu-Daudé
2019-03-11 3:54 ` [Qemu-devel] [PATCH 0/8] Kconfig: Clean up the PIIX southbridge devices no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfb987fd-8190-c100-80b9-657c060eb20f@redhat.com \
--to=thuth@redhat.com \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).