qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 23/35] kvm: x86: Do not leave halt if interrupts are disabled
Date: Tue, 15 Mar 2011 18:50:37 -0300	[thread overview]
Message-ID: <cfc53678b1c48325f038f0bbef6dea0f01993ecd.1300225848.git.mtosatti@redhat.com> (raw)
In-Reply-To: <cover.1300225848.git.mtosatti@redhat.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

When an external interrupt is pending but IF is cleared, we must not
leave the halt state prematurely.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
 target-i386/kvm.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index f7995bd..3a07fce 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -1590,7 +1590,9 @@ int kvm_arch_process_async_events(CPUState *env)
         return 0;
     }
 
-    if (env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI)) {
+    if (((env->interrupt_request & CPU_INTERRUPT_HARD) &&
+         (env->eflags & IF_MASK)) ||
+        (env->interrupt_request & CPU_INTERRUPT_NMI)) {
         env->halted = 0;
     }
     if (env->interrupt_request & CPU_INTERRUPT_INIT) {
-- 
1.7.4

  parent reply	other threads:[~2011-03-15 21:56 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15 21:50 [Qemu-devel] [PATCH 00/35] [PULL] qemu-kvm.git uq/master queue Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 01/35] kvm: ppc: Fix breakage of kvm_arch_pre_run/process_irqchip_events Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 02/35] kvm: Fix build warning when KVM_CAP_SET_GUEST_DEBUG is lacking Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 03/35] x86: Account for MCE in cpu_has_work Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 04/35] x86: Perform implicit mcg_status reset Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 05/35] x86: Small cleanups of MCE helpers Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 06/35] x86: Refine error reporting of MCE injection services Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 07/35] x86: Optionally avoid injecting AO MCEs while others are pending Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 08/35] Synchronize VCPU states before reset Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 09/35] kvm: x86: Move MCE functions together Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 10/35] kvm: Rename kvm_arch_process_irqchip_events to async_events Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 11/35] kvm: x86: Inject pending MCE events on state writeback Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 12/35] x86: Run qemu_inject_x86_mce on target VCPU Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 13/35] kvm: x86: Consolidate TCG and KVM MCE injection code Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 14/35] kvm: x86: Clean up kvm_setup_mce Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 15/35] kvm: x86: Fail kvm_arch_init_vcpu if MCE initialization fails Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 16/35] Add qemu_ram_remap Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 17/35] KVM, MCE, unpoison memory address across reboot Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 18/35] Implement qemu_kvm_eat_signals only for CONFIG_LINUX Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 19/35] x86: Unbreak TCG support for hardware breakpoints Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 20/35] s390: Detect invalid invocations of qemu_ram_free/remap Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 21/35] Break up user and system cpu_interrupt implementations Marcelo Tosatti
2011-03-16  9:02   ` [Qemu-devel] " Jan Kiszka
2011-03-16 20:13     ` Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 22/35] kvm: Add in-kernel irqchip awareness to cpu_thread_is_idle Marcelo Tosatti
2011-03-15 21:50 ` Marcelo Tosatti [this message]
2011-03-15 21:50 ` [Qemu-devel] [PATCH 24/35] kvm: Mark VCPU state dirty on creation Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 25/35] x86: Properly reset PAT MSR Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 26/35] x86: Save/restore " Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 27/35] kvm: x86: Synchronize PAT MSR with the kernel Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 28/35] kvm: Consider EXIT_DEBUG unknown without CAP_SET_GUEST_DEBUG Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 29/35] kvm: Keep KVM_RUN return value in separate variable Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 30/35] kvm: Reorder error handling of KVM_RUN Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 31/35] kvm: Rework inner loop of kvm_cpu_exec Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 32/35] kvm: Align kvm_arch_handle_exit to kvm_cpu_exec changes Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 33/35] kvm: x86: Reorder functions in kvm.c Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 34/35] kvm: x86: Push kvm_arch_debug to kvm_arch_handle_exit Marcelo Tosatti
2011-03-15 21:50 ` [Qemu-devel] [PATCH 35/35] Expose thread_id in info cpus Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfc53678b1c48325f038f0bbef6dea0f01993ecd.1300225848.git.mtosatti@redhat.com \
    --to=mtosatti@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).