qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Palmer Dabbelt <palmerdabbelt@google.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-riscv@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] RISC-V: Add a missing "," in riscv_excp_names
Date: Thu, 5 Mar 2020 18:19:10 +0100	[thread overview]
Message-ID: <cfc728aa-56a5-6a2d-a997-e1dfd871885c@redhat.com> (raw)
In-Reply-To: <20200305164839.201311-1-palmerdabbelt@google.com>

On 3/5/20 5:48 PM, Palmer Dabbelt wrote:
> THis would almost certainly cause the exception names to be reported
> incorrectly.  Covarity found the issue (CID 1420223).  As per Peter's

"This", "Coverity" typos.

Fixes: ab67a1d07a4
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> suggestion, I've also added a comma at the end of the list to avoid the issue
> reappearing in the future.
> 
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
> ---
>   target/riscv/cpu.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index c47d10b739..c0b7023100 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -66,7 +66,7 @@ const char * const riscv_excp_names[] = {
>       "exec_page_fault",
>       "load_page_fault",
>       "reserved",
> -    "store_page_fault"
> +    "store_page_fault",
>       "reserved",
>       "reserved",
>       "reserved",
> @@ -74,7 +74,7 @@ const char * const riscv_excp_names[] = {
>       "guest_exec_page_fault",
>       "guest_load_page_fault",
>       "reserved",
> -    "guest_store_page_fault"
> +    "guest_store_page_fault",
>   };
>   
>   const char * const riscv_intr_names[] = {
> 



  reply	other threads:[~2020-03-05 17:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05 16:48 [PATCH] RISC-V: Add a missing "," in riscv_excp_names Palmer Dabbelt
2020-03-05 17:19 ` Philippe Mathieu-Daudé [this message]
2020-03-05 17:20   ` Philippe Mathieu-Daudé
2020-03-05 20:06     ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfc728aa-56a5-6a2d-a997-e1dfd871885c@redhat.com \
    --to=philmd@redhat.com \
    --cc=palmerdabbelt@google.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).