From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Li Qiang" <liq3ea@gmail.com>
Cc: "Ying Fang" <fangying1@huawei.com>, 李强 <liq3ea@163.com>,
"Qemu Developers" <qemu-devel@nongnu.org>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect
Date: Mon, 9 Sep 2019 19:18:11 +0200 [thread overview]
Message-ID: <cfc93fb1-ec3c-fddc-85ac-17bb839a89c1@redhat.com> (raw)
In-Reply-To: <20190902090230.GC30123@redhat.com>
On 02/09/19 11:02, Daniel P. Berrangé wrote:
>>> === OUTPUT BEGIN ===
>>> ERROR: spaces required around that '*' (ctx:WxB)
>>> #118: FILE: ui/vnc-enc-tight.c:355:
>>> + data = (uint##bpp##_t *)vs->tight->tight.buffer; \
>>> ^
>>>
>>>
>> Hello Paolo and the Checkpatch maintainers,
>>
>> I also see this error in scripts/checkpatch.pl.
>> However when I add sapces around '*". I got following error:
>>
>> ERROR: space prohibited before that close parenthesis ')'
>>
>> #124: FILE: ui/vnc-enc-tight.c:355:
>>
>> + data = (uint##bpp##_t * )vs->tight->tight.buffer; \
>>
>>
>>
>> So I'm confused how to make checkpatch.pl happy.
>>
>>
>> Any one has suggests? Or we need a patch for checkpatch.pl?
> Either ignore this patch warning, or figure out how to fix
> checkpatch.pl though the latter quite be quite hard
checkpatch is confuesd by ##. It's probably possible to do something
like commit e20122ff0faf07cb701d35e39e106d1783c07725 to fix it, but your
patch is okay without the space after "*".
Paolo
next prev parent reply other threads:[~2019-09-09 17:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 15:39 [Qemu-devel] [PATCH] vnc: fix memory leak when vnc disconnect Li Qiang
2019-08-31 15:46 ` no-reply
2019-08-31 15:52 ` Li Qiang
2019-09-02 9:02 ` Daniel P. Berrangé
2019-09-09 17:18 ` Paolo Bonzini [this message]
2019-09-17 11:45 ` Gerd Hoffmann
2019-09-17 13:42 ` Li Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfc93fb1-ec3c-fddc-85ac-17bb839a89c1@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=fangying1@huawei.com \
--cc=kraxel@redhat.com \
--cc=liq3ea@163.com \
--cc=liq3ea@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).