From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A48DFC433DB for ; Wed, 17 Mar 2021 03:35:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F333364F96 for ; Wed, 17 Mar 2021 03:35:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F333364F96 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMMxk-0004vO-Qk for qemu-devel@archiver.kernel.org; Tue, 16 Mar 2021 23:35:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMMxB-0004Up-Aq for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:34:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lMMx8-0008TM-6o for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:34:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615952071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yV1ogZAuBcaU+cVzxa7Zw17jaTsUxLq773bxnFAhpdM=; b=LkoUYX/C1Qc5wIn4PpSBk5cqA7SO8n0s9a4tweZrHx3aPDPyCJyBZinWOZIg/BV7gMktU9 Ljr3cVri9oHzOxTyB077fMIFO5pRODQ+Qt/jTMIhkTOW0CNDBEgIsOCX2Y87ShQvk7Wv76 Yz+O+wp2FfrQC3pBf08StZjNgc1fJYU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-525-oRDI7WdbMnOeKC0DLuHfUA-1; Tue, 16 Mar 2021 23:34:29 -0400 X-MC-Unique: oRDI7WdbMnOeKC0DLuHfUA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9202C1858F1A; Wed, 17 Mar 2021 03:34:28 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-12-188.pek2.redhat.com [10.72.12.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id EEEA160875; Wed, 17 Mar 2021 03:34:26 +0000 (UTC) Subject: Re: [PULL V2 16/20] qapi: net: Add query-netdev command To: Peter Maydell References: <1615799673-31549-1-git-send-email-jasowang@redhat.com> <1615799673-31549-17-git-send-email-jasowang@redhat.com> From: Jason Wang Message-ID: Date: Wed, 17 Mar 2021 11:34:25 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kirillov , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2021/3/17 上午5:37, Peter Maydell 写道: > On Mon, 15 Mar 2021 at 09:15, Jason Wang wrote: >> From: Alexey Kirillov >> >> The query-netdev command is used to get the configuration of the current >> network device backends (netdevs). >> This is the QMP analog of the HMP command "info network" but only for >> netdevs (i.e. excluding NIC and hubports). >> >> The query-netdev command returns an array of objects of the NetdevInfo >> type, which are an extension of Netdev type. It means that response can >> be used for netdev-add after small modification. This can be useful for >> recreate the same netdev configuration. >> >> Information about the network device is filled in when it is created or >> modified and is available through the NetClientState->stored_config. >> >> Signed-off-by: Alexey Kirillov >> Acked-by: Markus Armbruster >> Signed-off-by: Jason Wang >> --- > Hi; Coverity complains about a memory leak in this code > (CID 1450842): > >> @@ -581,15 +693,25 @@ static int net_slirp_init(NetClientState *peer, const char *model, >> s->poll_notifier.notify = net_slirp_poll_notify; >> main_loop_poll_add_notifier(&s->poll_notifier); >> >> + stored_hostfwd = &stored->hostfwd; >> + stored_guestfwd = &stored->guestfwd; >> + >> for (config = slirp_configs; config; config = config->next) { >> + String *element = g_new0(String, 1); > Here we allocate memory... > >> + >> + element->str = g_strdup(config->str); >> if (config->flags & SLIRP_CFG_HOSTFWD) { >> if (slirp_hostfwd(s, config->str, errp) < 0) { >> goto error; > ...but if we take this error-exit path we have neither freed nor > kept a pointer to that memory. Yes. > >> } >> + stored->has_hostfwd = true; >> + QAPI_LIST_APPEND(stored_hostfwd, element); >> } else { >> if (slirp_guestfwd(s, config->str, errp) < 0) { >> goto error; > Similarly here. > >> } >> + stored->has_guestfwd = true; >> + QAPI_LIST_APPEND(stored_guestfwd, element); >> } >> } >> #ifndef _WIN32 > More generally, what state is the net backend init function > supposed to leave 'stored' in if it fails? Is it the backend's > responsibility to free everything that it might have allocated > and left a pointer to? eg if we did > stored->hostname = g_strdup(vhostname); > do we need to go back and free(stored->hostname) ? Or is the caller > guaranteeing to clean up 'stored' somehow ? Or is the backend > supposed to not touch 'stored' until it's sure it's going to > succeed ? (presumably not, as the current code does not do this...) Clean and free in the function that do the allocation seems better (self-conatined). > > This commit has no comments describing or documenting the > API requirements the new functionality imposes on a net backend: > could we have a followup patch which adds some documentation, > please, so that authors of future backends know what they have to > implement ? Alexey, plase send patches to fix the above issues and document the API. Thanks > > thanks > -- PMM >