From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, Tyrone Ting <kfting@nuvoton.com>,
Hao Wu <wuhaotsh@google.com>,
qemu-arm@nongnu.org
Subject: Re: [PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default
Date: Mon, 15 Jan 2024 12:36:54 +0100 [thread overview]
Message-ID: <cfdbf6d2-404c-4a63-9ee6-24f3d12d8a59@redhat.com> (raw)
In-Reply-To: <87r0iikf1o.fsf@draig.linaro.org>
On 15/01/2024 12.32, Alex Bennée wrote:
> Thomas Huth <thuth@redhat.com> writes:
>
>> The test_prescaler() part in the npcm7xx_watchdog_timer test is quite
>> repetive, testing all possible combinations of the WTCLK and WTIS
>> bitfields. Since each test spins up a new instance of QEMU, this is
>> rather an expensive test, especially on loaded host systems.
>
> I'm not against the change but I do not my home machine runs these tests
> in:
>
> 1/1 qemu:qtest+qtest-arm / qtest-arm/npcm7xx_timer-test OK 0.18s 180 subtests passed
That's a different test, I think. Look for "watchdog" in its name, please.
> so I do wonder how the system load can cause such a dramatic increase
> for a comparatively simple test.
The watchdog test is executing a new QEMU instance for each test in the
loop, and that can be quite expensive on a loaded system, I think.
Thomas
next prev parent reply other threads:[~2024-01-15 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 7:02 [PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default Thomas Huth
2024-01-15 11:07 ` Philippe Mathieu-Daudé
2024-01-15 11:32 ` Alex Bennée
2024-01-15 11:36 ` Thomas Huth [this message]
2024-01-15 11:45 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfdbf6d2-404c-4a63-9ee6-24f3d12d8a59@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kfting@nuvoton.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).